| Message ID | 20170912112124.1143-1-colin.king@canonical.com |
|---|---|
| State | New |
| Headers | show |
| Series | pinctrl: uniphier: make arrays static, reduces object code size | expand |
2017-09-12 20:21 GMT+09:00 Colin King <colin.king@canonical.com>: > From: Colin Ian King <colin.king@canonical.com> > > Don't populate const arrays on the stack, instead make them > static. Makes the object code smaller nearly 1000 bytes. Also > line break wide lines to avoid checkpatch warnings. > > Before: > text data bss dec hex filename > 13112 1996 0 15108 3b04 pinctrl-uniphier-core.o > > After: > text data bss dec hex filename > 11642 2476 0 14118 3726 pinctrl-uniphier-core.o > > Signed-off-by: Colin Ian King <colin.king@canonical.com> Acked-by: Masahiro Yamada <yamada.masahiro@socionext.com> Thanks!
On Tue, Sep 12, 2017 at 1:21 PM, Colin King <colin.king@canonical.com> wrote: > From: Colin Ian King <colin.king@canonical.com> > > Don't populate const arrays on the stack, instead make them > static. Makes the object code smaller nearly 1000 bytes. Also > line break wide lines to avoid checkpatch warnings. > > Before: > text data bss dec hex filename > 13112 1996 0 15108 3b04 pinctrl-uniphier-core.o > > After: > text data bss dec hex filename > 11642 2476 0 14118 3726 pinctrl-uniphier-core.o > > Signed-off-by: Colin Ian King <colin.king@canonical.com> Patch applied with Masahiro's ACK. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pinctrl/uniphier/pinctrl-uniphier-core.c b/drivers/pinctrl/uniphier/pinctrl-uniphier-core.c index f9267fabe6b0..26fda5c53e65 100644 --- a/drivers/pinctrl/uniphier/pinctrl-uniphier-core.c +++ b/drivers/pinctrl/uniphier/pinctrl-uniphier-core.c @@ -204,9 +204,10 @@ static int uniphier_conf_pin_drive_get(struct pinctrl_dev *pctldev, const struct pin_desc *desc = pin_desc_get(pctldev, pin); enum uniphier_pin_drv_type type = uniphier_pin_get_drv_type(desc->drv_data); - const unsigned int strength_1bit[] = {4, 8}; - const unsigned int strength_2bit[] = {8, 12, 16, 20}; - const unsigned int strength_3bit[] = {4, 5, 7, 9, 11, 12, 14, 16}; + static const unsigned int strength_1bit[] = {4, 8}; + static const unsigned int strength_2bit[] = {8, 12, 16, 20}; + static const unsigned int strength_3bit[] = {4, 5, 7, 9, 11, 12, + 14, 16}; const unsigned int *supported_strength; unsigned int drvctrl, reg, shift, mask, width, val; int ret; @@ -399,9 +400,10 @@ static int uniphier_conf_pin_drive_set(struct pinctrl_dev *pctldev, const struct pin_desc *desc = pin_desc_get(pctldev, pin); enum uniphier_pin_drv_type type = uniphier_pin_get_drv_type(desc->drv_data); - const unsigned int strength_1bit[] = {4, 8, -1}; - const unsigned int strength_2bit[] = {8, 12, 16, 20, -1}; - const unsigned int strength_3bit[] = {4, 5, 7, 9, 11, 12, 14, 16, -1}; + static const unsigned int strength_1bit[] = {4, 8, -1}; + static const unsigned int strength_2bit[] = {8, 12, 16, 20, -1}; + static const unsigned int strength_3bit[] = {4, 5, 7, 9, 11, 12, 14, + 16, -1}; const unsigned int *supported_strength; unsigned int drvctrl, reg, shift, mask, width, val;