From patchwork Wed Aug 9 12:25:04 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 799762 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=bgdev-pl.20150623.gappssmtp.com header.i=@bgdev-pl.20150623.gappssmtp.com header.b="iei3TORl"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3xS9W74dtrz9s03 for ; Wed, 9 Aug 2017 22:26:59 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753020AbdHIM03 (ORCPT ); Wed, 9 Aug 2017 08:26:29 -0400 Received: from mail-wr0-f180.google.com ([209.85.128.180]:34734 "EHLO mail-wr0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752757AbdHIMZP (ORCPT ); Wed, 9 Aug 2017 08:25:15 -0400 Received: by mail-wr0-f180.google.com with SMTP id c24so17767414wra.1 for ; Wed, 09 Aug 2017 05:25:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=HJeRpbwlo6cO4mJBEUpACoP7vUy1n0TPBpbONwgXJ4U=; b=iei3TORlLzeluyIriNI2pDp476Gb9a5D9u8iK5WdHM2H5tIcQw07TrnlnYgOYGIWcB c3ibEk1jjZy/frJuWRTJmxBwOWntCnVc33pBaqO2/s0F40oaxu8V1DHp4TEOyLr0phue +t2pqwSz6cULmeoldtGLy4OUAzHnWyOQonJEAn54JzXFhoqkU/EPxIYNTUuofYqWP8ri NFdV4j0Tyj3Lk0Zs58XRsW1S7VfXTNTTxhjkzsZg0I3KW5Gi0kypNQs+JHAjZ3NGcHIw fKQfqo1aziU5CctLlibyUODY2pdY1lIL4QMBdRX2ZxDcEqf97s5LW7l2OpIhdHkut5kz Suiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=HJeRpbwlo6cO4mJBEUpACoP7vUy1n0TPBpbONwgXJ4U=; b=hXanKmmuUalO40EJDalndBNgwvV0dX1wtZSqp5BZ+CzNWGsc9AnC3qJzGFj88ucKg2 /vjA8+7ZocjoXYMNGF9BcngLA3/0QZBHtT/1n5XZYco7td/qhsZbOHuM945wLJUGkIOp Iw3oLseeYWY0ndOLFTpqb93IgOpSgfLOxqDEsVQmYgKYUjZnRLCzCTGG5dEF7fS2CzpM SURx4vUf4P6oqLAfcw4m0ntA5uGwliCg+2G8xyGOH501K15J2i+Np4uw7qr1Z141XTNu L72q3w8DZrOFM0Ryz701BTpWrafHRTt9MgeE1+sQzVpxdKT+wLWQRndXHW4Fe8tiuZe2 Cy6Q== X-Gm-Message-State: AHYfb5gYw+OsiOYNsBnd+vKqpQFIkUBnPsqq/HbPtktOCHPkNS5KemdZ F0ESAzRhbKCWTDmm X-Received: by 10.223.152.76 with SMTP id v70mr5217087wrb.156.1502281514349; Wed, 09 Aug 2017 05:25:14 -0700 (PDT) Received: from localhost.localdomain ([90.63.244.31]) by smtp.gmail.com with ESMTPSA id p45sm5254729wrb.75.2017.08.09.05.25.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 09 Aug 2017 05:25:13 -0700 (PDT) From: Bartosz Golaszewski To: Linus Walleij Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [PATCH v2 5/8] gpio: ml-ioh: use devres for irq generic chip Date: Wed, 9 Aug 2017 14:25:04 +0200 Message-Id: <20170809122507.11149-6-brgl@bgdev.pl> X-Mailer: git-send-email 2.13.2 In-Reply-To: <20170809122507.11149-1-brgl@bgdev.pl> References: <20170809122507.11149-1-brgl@bgdev.pl> Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Use resource managed variants of irq_alloc_generic_chip() and irq_setup_generic_chip(). Signed-off-by: Bartosz Golaszewski --- drivers/gpio/gpio-ml-ioh.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/gpio/gpio-ml-ioh.c b/drivers/gpio/gpio-ml-ioh.c index 74fdce096c26..4b80e996d976 100644 --- a/drivers/gpio/gpio-ml-ioh.c +++ b/drivers/gpio/gpio-ml-ioh.c @@ -391,9 +391,10 @@ static int ioh_gpio_alloc_generic_chip(struct ioh_gpio *chip, { struct irq_chip_generic *gc; struct irq_chip_type *ct; + int rv; - gc = irq_alloc_generic_chip("ioh_gpio", 1, irq_start, chip->base, - handle_simple_irq); + gc = devm_irq_alloc_generic_chip(chip->dev, "ioh_gpio", 1, irq_start, + chip->base, handle_simple_irq); if (!gc) return -ENOMEM; @@ -406,10 +407,11 @@ static int ioh_gpio_alloc_generic_chip(struct ioh_gpio *chip, ct->chip.irq_disable = ioh_irq_disable; ct->chip.irq_enable = ioh_irq_enable; - irq_setup_generic_chip(gc, IRQ_MSK(num), IRQ_GC_INIT_MASK_CACHE, - IRQ_NOREQUEST | IRQ_NOPROBE, 0); + rv = devm_irq_setup_generic_chip(chip->dev, gc, IRQ_MSK(num), + IRQ_GC_INIT_MASK_CACHE, + IRQ_NOREQUEST | IRQ_NOPROBE, 0); - return 0; + return rv; } static int ioh_gpio_probe(struct pci_dev *pdev,