From patchwork Tue May 16 06:18:59 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stefan Agner X-Patchwork-Id: 762798 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3wRnN26s19z9s75 for ; Tue, 16 May 2017 16:19:14 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; secure) header.d=agner.ch header.i=@agner.ch header.b="uMkh80xU"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751234AbdEPGTN (ORCPT ); Tue, 16 May 2017 02:19:13 -0400 Received: from mail.kmu-office.ch ([178.209.48.109]:57771 "EHLO mail.kmu-office.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751137AbdEPGTN (ORCPT ); Tue, 16 May 2017 02:19:13 -0400 Received: from localhost.localdomain (unknown [IPv6:2601:602:8801:c3e0::127]) by mail.kmu-office.ch (Postfix) with ESMTPSA id 707825C1447; Tue, 16 May 2017 08:18:22 +0200 (CEST) From: Stefan Agner To: linus.walleij@linaro.org Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Stefan Agner Subject: [PATCH] pinctrl: core: do not explicitly free on unregister Date: Mon, 15 May 2017 23:18:59 -0700 Message-Id: <20170516061859.396-1-stefan@agner.ch> X-Mailer: git-send-email 2.13.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=agner.ch; s=dkim; t=1494915503; bh=jl/12rsBVGAn2PZBCLlMYs8yZBWRDYss3M6XVMkHMWQ=; h=From:To:Cc:Subject:Date:Message-Id; b=uMkh80xUhdLwIBSmG+8ORz4C7k14kxDq3ZHwxb5i4L+fdaumV2+IGW1AaOtBm9AostNzbVdHi+SjyO4nI7VxBy6V+9SzBzQRhN+XjHaPJcJZAvTR3aERiH4TpVZ8DGhAql8ExQjTlT8jN5ZwefreMhQou27yd6Khtxss7kYU2jo= Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org When using the resource managed version of pinctrl, resources might already been freed when pinctrl_unregister is called by the devres framework. When calling devm_kfree on such a already freed resource, devres prints a warning: WARNING: CPU: 0 PID: 1 at drivers/base/devres.c:891 pinmux_generic_free_functions+0xf4/0x128 ... Solve this by not explicitly free resources. The two affected functions (pinmux_generic_free_functions/pinctrl_generic_free_groups) are only used in pinctrl_unregister. When not using the resource managed version of pinctrl, the underlying device will presumably get freed freed soon anyway. Signed-off-by: Stefan Agner --- drivers/pinctrl/core.c | 1 - drivers/pinctrl/pinmux.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c index 1653cbda6a82..bc4c12008cd4 100644 --- a/drivers/pinctrl/core.c +++ b/drivers/pinctrl/core.c @@ -702,7 +702,6 @@ static void pinctrl_generic_free_groups(struct pinctrl_dev *pctldev) group = radix_tree_lookup(&pctldev->pin_group_tree, indices[i]); radix_tree_delete(&pctldev->pin_group_tree, indices[i]); - devm_kfree(pctldev->dev, group); } pctldev->num_groups = 0; diff --git a/drivers/pinctrl/pinmux.c b/drivers/pinctrl/pinmux.c index 9fd6d9087dc5..87098be84a3c 100644 --- a/drivers/pinctrl/pinmux.c +++ b/drivers/pinctrl/pinmux.c @@ -848,7 +848,6 @@ void pinmux_generic_free_functions(struct pinctrl_dev *pctldev) function = radix_tree_lookup(&pctldev->pin_function_tree, indices[i]); radix_tree_delete(&pctldev->pin_function_tree, indices[i]); - devm_kfree(pctldev->dev, function); } pctldev->num_functions = 0;