diff mbox

gpio: f7188x: Add a missing break

Message ID 20170426190815.vi2v3ef4j7ruspkg@mwanda
State New
Headers show

Commit Message

Dan Carpenter April 26, 2017, 7:08 p.m. UTC
A break statement was obviously intended here.

Fixes: d69843e416d3 ("gpio: f7188x: Add F71889A GPIO support.")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Linus Walleij April 28, 2017, 8:09 a.m. UTC | #1
On Wed, Apr 26, 2017 at 9:08 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:

> A break statement was obviously intended here.
>
> Fixes: d69843e416d3 ("gpio: f7188x: Add F71889A GPIO support.")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Patch applied.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Marty Plummer April 30, 2017, 11:45 p.m. UTC | #2
On Fri, Apr 28, 2017 at 10:09:39AM +0200, Linus Walleij wrote:
> On Wed, Apr 26, 2017 at 9:08 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
> 
> > A break statement was obviously intended here.
> >
> > Fixes: d69843e416d3 ("gpio: f7188x: Add F71889A GPIO support.")
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> Patch applied.
> 
> Yours,
> Linus Walleij
How embarrassing, I completely missed that. Good catch.

Marty.
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/gpio/gpio-f7188x.c b/drivers/gpio/gpio-f7188x.c
index c013ff5deb70..13350c9d7f5e 100644
--- a/drivers/gpio/gpio-f7188x.c
+++ b/drivers/gpio/gpio-f7188x.c
@@ -398,6 +398,7 @@  static int f7188x_gpio_probe(struct platform_device *pdev)
 	case f71889a:
 		data->nr_bank = ARRAY_SIZE(f71889a_gpio_bank);
 		data->bank = f71889a_gpio_bank;
+		break;
 	case f71889f:
 		data->nr_bank = ARRAY_SIZE(f71889_gpio_bank);
 		data->bank = f71889_gpio_bank;