diff mbox

gpio: mcp23s08: Select REGMAP/REGMAP_I2C to fix build error

Message ID 20170202101306.24976-1-axel.lin@ingics.com
State New
Headers show

Commit Message

Axel Lin Feb. 2, 2017, 10:13 a.m. UTC
This driver now using devm_regmap_init/devm_regmap_init_i2c, so it needs
to select REGMAP/REGMAP_I2C accordingly.

Fixes: ("3d84fdb3f0b5 gpio: mcp23s08: use regmap")
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 drivers/gpio/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

Comments

Sebastian Reichel Feb. 2, 2017, 1:56 p.m. UTC | #1
Hi,

On Thu, Feb 02, 2017 at 06:13:06PM +0800, Axel Lin wrote:
> This driver now using devm_regmap_init/devm_regmap_init_i2c, so it needs
> to select REGMAP/REGMAP_I2C accordingly.
> 
> Fixes: ("3d84fdb3f0b5 gpio: mcp23s08: use regmap")
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
>  drivers/gpio/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 2d77392..28e6219 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -1213,6 +1213,8 @@ config GPIO_MCP23S08
>  	tristate "Microchip MCP23xxx I/O expander"
>  	depends on OF_GPIO
>  	select GPIOLIB_IRQCHIP
> +	select REGMAP_I2C if I2C
> +	select REGMAP if SPI_MASTER
>  	help
>  	  SPI/I2C driver for Microchip MCP23S08/MCP23S17/MCP23008/MCP23017
>  	  I/O expanders.

Acked-By: Sebastian Reichel <sre@kernel.org>

-- Sebastian
Linus Walleij Feb. 4, 2017, 8:25 p.m. UTC | #2
On Thu, Feb 2, 2017 at 11:13 AM, Axel Lin <axel.lin@ingics.com> wrote:

> This driver now using devm_regmap_init/devm_regmap_init_i2c, so it needs
> to select REGMAP/REGMAP_I2C accordingly.
>
> Fixes: ("3d84fdb3f0b5 gpio: mcp23s08: use regmap")
> Signed-off-by: Axel Lin <axel.lin@ingics.com>

Patch applied with Sebastian's ACK.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 2d77392..28e6219 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -1213,6 +1213,8 @@  config GPIO_MCP23S08
 	tristate "Microchip MCP23xxx I/O expander"
 	depends on OF_GPIO
 	select GPIOLIB_IRQCHIP
+	select REGMAP_I2C if I2C
+	select REGMAP if SPI_MASTER
 	help
 	  SPI/I2C driver for Microchip MCP23S08/MCP23S17/MCP23008/MCP23017
 	  I/O expanders.