From patchwork Tue Jan 17 15:55:32 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 716273 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3v2vxy4CRKz9srY for ; Wed, 18 Jan 2017 03:02:30 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="prntrLKT"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751160AbdAQQC3 (ORCPT ); Tue, 17 Jan 2017 11:02:29 -0500 Received: from mail-pg0-f68.google.com ([74.125.83.68]:36863 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751152AbdAQQC2 (ORCPT ); Tue, 17 Jan 2017 11:02:28 -0500 Received: by mail-pg0-f68.google.com with SMTP id 75so8351381pgf.3 for ; Tue, 17 Jan 2017 08:02:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=hTjZfbHcUBej69nXzN3SwnTcUAWxAyDED0f0H0QsIl4=; b=prntrLKTSwDMYmKwzMiFN/PGJ5ysMYZCxE6PVT0lpOukWjEArormRNcawEKhLwUCvw WIt7Hz9D9TLScsGjUztOG6fm3RXl3z4ai4uacavmOS0p9ZxwbpdLj2N0vXy9zsFiD9xi lOl/5MhT+IvyHHCr+gDww+KPPfE9pid34K3IKT95Wixd3XnHzAZZdyVGgs77d0BUEqw4 4n9dXUzC7rSrHGQz+YsVIJog9INpxvIkV5uDt1MC/BBbnZxWygNraCiBIA+3AwXb4hx8 LOr0XQU9Y+Ucpbrev3GuSymr5Pvj/mh/guolddqfmSqSg2hjwPG+THjOP5yEthjS2HN5 ek2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=hTjZfbHcUBej69nXzN3SwnTcUAWxAyDED0f0H0QsIl4=; b=PsMHcdQiRJ2P3tiDehRRGEtMG+7kUPQ1wDobkXXa2keU67VZp5iCoMR9Ub7jLu/vSH GhPCUlB1OHwrUWq+alToNHEP5hzfgzQKvcoSld8k1zLW78ji+REhYc9hXL2q5y5DIDHY r1UBdzReFFsd02788jRneutPnMhJm+M/2btDn5Mg9eLZjIsYEHAWTJR6qrWuog1ciFa2 fnFrUqmRlITe6br6R7bKfdwxlCREQWqVAk/8lYhyp5ZqOGvBIHaGXERgTmD7jVxEZrYr 8Upg6ZX0i4DH3T4KNnT7cWNPKN8vW8YeeMJqHiu4FrEEXdULv9euAygoPQt8R02AyWLA dTdg== X-Gm-Message-State: AIkVDXIBQlFgHb/1nbuVNdPY1jmoomN0MFFzDsgh5i0YeyizjfkF9wK+ylo7vXvT3gf7Nw== X-Received: by 10.98.152.218 with SMTP id d87mr43731623pfk.17.1484668540550; Tue, 17 Jan 2017 07:55:40 -0800 (PST) Received: from 192.168.0.37 (ec2-52-192-197-227.ap-northeast-1.compute.amazonaws.com. [52.192.197.227]) by smtp.gmail.com with ESMTPSA id i82sm8194680pfk.52.2017.01.17.07.55.38 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Jan 2017 07:55:39 -0800 (PST) From: Wei Yongjun To: Linus Walleij , "Shah, Nehal-bakulchandra" Cc: Wei Yongjun , linux-gpio@vger.kernel.org Subject: [PATCH -next] pinctrl/amd: Drop pinctrl_unregister for devm_ registered device Date: Tue, 17 Jan 2017 15:55:32 +0000 Message-Id: <20170117155532.28879-1-weiyj.lk@gmail.com> X-Mailer: git-send-email 2.9.3 MIME-Version: 1.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org From: Wei Yongjun It's not necessary to unregister pin controller device registered with devm_pinctrl_register() and using pinctrl_unregister() leads to a double free. Fixes: 3bfd44306c65 ("pinctrl: amd: Add support for additional GPIO") Signed-off-by: Wei Yongjun --- drivers/pinctrl/pinctrl-amd.c | 1 - 1 file changed, 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/pinctrl/pinctrl-amd.c b/drivers/pinctrl/pinctrl-amd.c index c64ea8f..586001c 100644 --- a/drivers/pinctrl/pinctrl-amd.c +++ b/drivers/pinctrl/pinctrl-amd.c @@ -831,7 +831,6 @@ static int amd_gpio_remove(struct platform_device *pdev) gpio_dev = platform_get_drvdata(pdev); gpiochip_remove(&gpio_dev->gc); - pinctrl_unregister(gpio_dev->pctrl); return 0; }