From patchwork Tue Jan 3 08:21:19 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 710417 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3tt6PC3fsJz9ssP for ; Tue, 3 Jan 2017 19:22:07 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="JHV89A2k"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934209AbdACIV3 (ORCPT ); Tue, 3 Jan 2017 03:21:29 -0500 Received: from mail-lf0-f48.google.com ([209.85.215.48]:34149 "EHLO mail-lf0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934407AbdACIVY (ORCPT ); Tue, 3 Jan 2017 03:21:24 -0500 Received: by mail-lf0-f48.google.com with SMTP id y21so281024492lfa.1 for ; Tue, 03 Jan 2017 00:21:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id; bh=j3VuOEbSnxIQLPUrlM2jMF6LAcsYKUoQ/RdTfqjs7R0=; b=JHV89A2kAplggWaIpLl49yz9dPo9Zrkw4Q7+8v8W3Mn6A78dG2lSn1j1MUyha6tZLW R4DSILjiaSISahSDDXJoSUkMOKtRCUB6h7m9AsaWliuKwvKHGjQrGAMXfSHjgYQeI7Yz YTKJiXT37yNA82aJQnWsFbKw9KC/LOdOvLQ1w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=j3VuOEbSnxIQLPUrlM2jMF6LAcsYKUoQ/RdTfqjs7R0=; b=KuoKNO1jVC6lmQM0fae2142IdoVxCnYl1PjtR96P/UgTz+TSoqVZZYn1BMD8IN/REk 3LvnZQNTRJHbGMLKTj9fycau84mx8qmgQPGA1llA/MAVBIzuNKKeN6eddoogfxcfZwSL ZEUG5NFXkGCtIgmjBGgdmenLJjCg/xUyci/QCJlmKj6bxLTMvTsI6hAeZKD6heoucC1b t3xQSuTcIjEIiZeOeWMLdCaXYJcleliKv54NSQU6TRzFxb7FJ3p98S6s9TBcLXY8HgKS Zh8OKhVVPlgjuW72ls1h68/N4JybKCrx14h792pyhUZ5g/pmyaKtkCc8olp0ef3cjjAK NrbQ== X-Gm-Message-State: AIkVDXLzYn35oS+eP8vVjO6X6fgnxkQFpXqFCGhR6oPX7mOcTDsvao8fdlzxvan6ZccXD+db X-Received: by 10.46.74.9 with SMTP id x9mr22922695lja.40.1483431681747; Tue, 03 Jan 2017 00:21:21 -0800 (PST) Received: from localhost.localdomain (c-357171d5.014-348-6c756e10.cust.bredbandsbolaget.se. [213.113.113.53]) by smtp.gmail.com with ESMTPSA id 10sm16339593ljh.11.2017.01.03.00.21.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Jan 2017 00:21:21 -0800 (PST) From: Linus Walleij To: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: linux-gpio@vger.kernel.org, Linus Walleij , S-k Shyam-sundar , Nehal Shah Subject: [PATCH] pinctrl: amd: fix compilation warning Date: Tue, 3 Jan 2017 09:21:19 +0100 Message-Id: <20170103082119.11958-1-linus.walleij@linaro.org> X-Mailer: git-send-email 2.9.3 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org 3bfd44306c65 ("pinctrl: amd: Add support for additional GPIO") created the following warning: drivers/pinctrl/pinctrl-amd.c: In function 'amd_gpio_dbg_show': drivers/pinctrl/pinctrl-amd.c:210:3: warning: 'pin_num' may be used uninitialized in this function [-Wmaybe-uninitialized] for (; i < pin_num; i++) { ^ drivers/pinctrl/pinctrl-amd.c:172:21: warning: 'i' may be used uninitialized in this function [-Wmaybe-uninitialized] unsigned int bank, i, pin_num; ^ Fix this by adding a guarding default case for illegal bank numbers. Cc: S-k Shyam-sundar Cc: Nehal Shah Signed-off-by: Linus Walleij --- drivers/pinctrl/pinctrl-amd.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/pinctrl/pinctrl-amd.c b/drivers/pinctrl/pinctrl-amd.c index 47b17100410e..c2203699f1ab 100644 --- a/drivers/pinctrl/pinctrl-amd.c +++ b/drivers/pinctrl/pinctrl-amd.c @@ -206,6 +206,9 @@ static void amd_gpio_dbg_show(struct seq_file *s, struct gpio_chip *gc) i = 192; pin_num = AMD_GPIO_PINS_BANK3 + i; break; + default: + /* Illegal bank number, ignore */ + continue; } for (; i < pin_num; i++) { seq_printf(s, "pin%d\t", i);