From patchwork Tue Dec 20 21:18:00 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Paul Gortmaker X-Patchwork-Id: 707582 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3tjrHf6NmYz9tkH for ; Wed, 21 Dec 2016 08:18:38 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752488AbcLTVSe (ORCPT ); Tue, 20 Dec 2016 16:18:34 -0500 Received: from mail5.windriver.com ([192.103.53.11]:54622 "EHLO mail5.wrs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755599AbcLTVSd (ORCPT ); Tue, 20 Dec 2016 16:18:33 -0500 Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail5.wrs.com (8.15.2/8.15.2) with ESMTPS id uBKLI7ML027530 (version=TLSv1 cipher=AES128-SHA bits=128 verify=OK); Tue, 20 Dec 2016 13:18:07 -0800 Received: from yow-pgortmak-d1.corp.ad.wrs.com (128.224.56.57) by ALA-HCA.corp.ad.wrs.com (147.11.189.40) with Microsoft SMTP Server id 14.3.294.0; Tue, 20 Dec 2016 13:18:06 -0800 From: Paul Gortmaker To: CC: Paul Gortmaker , Hauke Mehrtens , Boris Brezillon , Linus Walleij , Alexandre Courbot , Subject: [PATCH] mtd: nand: fix implicit module.h usage in xway_nand.c Date: Tue, 20 Dec 2016 16:18:00 -0500 Message-ID: <20161220211800.4701-1-paul.gortmaker@windriver.com> X-Mailer: git-send-email 2.10.1 MIME-Version: 1.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org In commit d47529b2e9fe0ec2eb1f072afad8849f52e385c4 ("gpio: don't include module.h in shared driver header") we fixed a bunch of implicit includes and then did what the shortlog says -- remove module.h from a gpio header. In parallel, commit 024366750c2e04fdcda8bca685194ef0196b35fe ("mtd: nand: xway: convert to normal platform driver") added new modular function calls to a file that now became relying on the above module.h presence in the gpio header, since it did not explicitly include module.h header for them as part of the change. The problem only appears when the two dev streams are merged. Since the file is tristate, the fix is obvious -- it needs an explicit include of module.h header. Reported-by: kbuild test robot Cc: Hauke Mehrtens Cc: Boris Brezillon Cc: Linus Walleij Cc: Alexandre Courbot Cc: linux-gpio@vger.kernel.org Signed-off-by: Paul Gortmaker --- [Resending with all Cc: enabled/added this time ... :-( ] drivers/mtd/nand/xway_nand.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mtd/nand/xway_nand.c b/drivers/mtd/nand/xway_nand.c index 1f2948c0c458..00168d633bcf 100644 --- a/drivers/mtd/nand/xway_nand.c +++ b/drivers/mtd/nand/xway_nand.c @@ -7,6 +7,7 @@ * Copyright © 2016 Hauke Mehrtens */ +#include #include #include #include