| Message ID | 20161123132749.11666-2-quentin.schulz@free-electrons.com |
|---|---|
| State | New |
| Headers | show |
Hello, On Wed, 23 Nov 2016 14:27:48 +0100, Quentin Schulz wrote: > The GPIO input status was read from control register > (AXP20X_GPIO[210]_CTRL) instead of status register (AXP20X_GPIO20_SS). > > Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com> This smells like a bug fix, so perhaps Cc: stable? Thomas
On Wed, Nov 23, 2016 at 9:45 PM, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote: > Hello, > > On Wed, 23 Nov 2016 14:27:48 +0100, Quentin Schulz wrote: >> The GPIO input status was read from control register >> (AXP20X_GPIO[210]_CTRL) instead of status register (AXP20X_GPIO20_SS). >> >> Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com> > > This smells like a bug fix, so perhaps Cc: stable? Presently there are no in-tree boards that use the GPIOs as input. And the only user I see is the CHIP, for the headphone jack detection. Again, not supported in mainline yet. Not sure if there is value in sending it for stable. ChenYu > > Thomas > -- > Thomas Petazzoni, CTO, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/gpio/gpio-axp209.c b/drivers/gpio/gpio-axp209.c index d9c2a51..4a346b7 100644 --- a/drivers/gpio/gpio-axp209.c +++ b/drivers/gpio/gpio-axp209.c @@ -64,13 +64,9 @@ static int axp20x_gpio_get(struct gpio_chip *chip, unsigned offset) { struct axp20x_gpio *gpio = gpiochip_get_data(chip); unsigned int val; - int reg, ret; - - reg = axp20x_gpio_get_reg(offset); - if (reg < 0) - return reg; + int ret; - ret = regmap_read(gpio->regmap, reg, &val); + ret = regmap_read(gpio->regmap, AXP20X_GPIO20_SS, &val); if (ret) return ret;
The GPIO input status was read from control register (AXP20X_GPIO[210]_CTRL) instead of status register (AXP20X_GPIO20_SS). Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com> --- drivers/gpio/gpio-axp209.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-)