From patchwork Wed Feb 17 19:55:43 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Josh Cartwright X-Patchwork-Id: 584337 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 05C42140213 for ; Thu, 18 Feb 2016 06:56:26 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161738AbcBQT4Y (ORCPT ); Wed, 17 Feb 2016 14:56:24 -0500 Received: from skprod3.natinst.com ([130.164.80.24]:34010 "EHLO ni.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1161663AbcBQT4X (ORCPT ); Wed, 17 Feb 2016 14:56:23 -0500 Received: from us-aus-mgwout2.amer.corp.natinst.com (nb-chan1-1338.natinst.com [130.164.19.134]) by us-aus-skprod3.natinst.com (8.15.0.59/8.15.0.59) with ESMTP id u1HJthuA023442; Wed, 17 Feb 2016 13:55:43 -0600 Received: from jcartwri.amer.corp.natinst.com ([130.164.14.198]) by us-aus-mgwout2.amer.corp.natinst.com (Lotus Domino Release 8.5.3FP6 HF1218) with ESMTP id 2016021713554361-1091116 ; Wed, 17 Feb 2016 13:55:43 -0600 Received: by jcartwri.amer.corp.natinst.com (Postfix, from userid 1000) id 3C64A3006F7; Wed, 17 Feb 2016 13:55:43 -0600 (CST) Date: Wed, 17 Feb 2016 13:55:43 -0600 From: Josh Cartwright To: Tony Lindgren Cc: Linus Walleij , linux-gpio@vger.kernel.org, Johan Hovold , Markus Pargmann , Mark Brown , Michael Welling , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: Bunch of machines are not booting in next again, GPIO regression? Message-ID: <20160217195543.GA871@jcartwri.amer.corp.natinst.com> References: <20160217192755.GC21202@atomide.com> MIME-Version: 1.0 In-Reply-To: <20160217192755.GC21202@atomide.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-MIMETrack: Itemize by SMTP Server on US-AUS-MGWOut2/AUS/H/NIC(Release 8.5.3FP6 HF1218|December 12, 2014) at 02/17/2016 01:55:43 PM, Serialize by Router on US-AUS-MGWOut2/AUS/H/NIC(Release 8.5.3FP6 HF1218|December 12, 2014) at 02/17/2016 01:55:43 PM, Serialize complete at 02/17/2016 01:55:43 PM Content-Disposition: inline X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2016-02-17_09:, , signatures=0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Wed, Feb 17, 2016 at 11:27:55AM -0800, Tony Lindgren wrote: > Hi Linus, > > Looks like ff2b13592299 ("gpio: make the gpiochip a real device") > broke booting on all omaps, and probably other machines too according > to this: > > https://kernelci.org/boot/all/job/next/kernel/next-20160217/ > > So far we've gone from 1 failed machine with next-20160216 to > 18 failed machines with next-20160217. > > The error I'm getting on omaps is below with debug_ll enable, > any ideas? Hey Tony- Looks like the newly allocated gpio_device object isn't zeroed, confusing dev_set_name. Can you give this a try? Josh diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index d8511cd..59f0045 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -435,7 +435,7 @@ int gpiochip_add_data(struct gpio_chip *chip, void *data) * First: allocate and populate the internal stat container, and * set up the struct device. */ - gdev = kmalloc(sizeof(*gdev), GFP_KERNEL); + gdev = kzalloc(sizeof(*gdev), GFP_KERNEL); if (!gdev) return -ENOMEM; gdev->dev.bus = &gpio_bus_type;