| Message ID | 20150528025848.GA11051@aaronlu.sh.intel.com |
|---|---|
| State | New |
| Headers | show |
On Thu, May 28, 2015 at 4:58 AM, Aaron Lu <aaron.lu@intel.com> wrote: > The CrystalCove GPIO irqchip doesn't have irq_set_wake callback defined > so we should set IRQCHIP_SKIP_SET_WAKE for it or it would cause an irq > desc's wake_depth unbalanced warning during system resume phase from the > gpio_keys driver, which is the driver for the power button of the ASUS > T100 laptop. > > Signed-off-by: Aaron Lu <aaron.lu@intel.com> > Cc: <stable@vger.kernel.org> Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/gpio/gpio-crystalcove.c b/drivers/gpio/gpio-crystalcove.c index 91a7ffe83135..ab457fc00e75 100644 --- a/drivers/gpio/gpio-crystalcove.c +++ b/drivers/gpio/gpio-crystalcove.c @@ -255,6 +255,7 @@ static struct irq_chip crystalcove_irqchip = { .irq_set_type = crystalcove_irq_type, .irq_bus_lock = crystalcove_bus_lock, .irq_bus_sync_unlock = crystalcove_bus_sync_unlock, + .flags = IRQCHIP_SKIP_SET_WAKE, }; static irqreturn_t crystalcove_gpio_irq_handler(int irq, void *data)
The CrystalCove GPIO irqchip doesn't have irq_set_wake callback defined so we should set IRQCHIP_SKIP_SET_WAKE for it or it would cause an irq desc's wake_depth unbalanced warning during system resume phase from the gpio_keys driver, which is the driver for the power button of the ASUS T100 laptop. Signed-off-by: Aaron Lu <aaron.lu@intel.com> Cc: <stable@vger.kernel.org> --- drivers/gpio/gpio-crystalcove.c | 1 + 1 file changed, 1 insertion(+)