| Message ID | 1615975084-68203-2-git-send-email-zhouyanjie@wanyeetech.com |
|---|---|
| State | New |
| Headers | show |
| Series | Fix bugs and add support for new Ingenic SoCs. | expand |
Hi Zhou, Le mer. 17 mars 2021 à 17:57, 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com> a écrit : > The MII group of JZ4770's MAC should have 7 pins, add missing > pins to the MII group. > > Fixes: 5de1a73e78ed ("Pinctrl: Ingenic: Add missing parts for JZ4770 > and JZ4780.") This fixes a commit that was introduced in an older kernel (than the one in -rc phase). Therefore you need to Cc linux-stable. Like this: Cc: <stable@vger.kernel.org> # v5.0 > Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com> With that said: Reviewed-by: Paul Cercueil <paul@crapouillou.net> Cheers, -Paul > --- > > Notes: > v2: > New patch. > > v2->v3: > Add fixes tag. > > drivers/pinctrl/pinctrl-ingenic.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/pinctrl-ingenic.c > b/drivers/pinctrl/pinctrl-ingenic.c > index f274612..05dfa0a 100644 > --- a/drivers/pinctrl/pinctrl-ingenic.c > +++ b/drivers/pinctrl/pinctrl-ingenic.c > @@ -667,7 +667,9 @@ static int jz4770_pwm_pwm7_pins[] = { 0x6b, }; > static int jz4770_mac_rmii_pins[] = { > 0xa9, 0xab, 0xaa, 0xac, 0xa5, 0xa4, 0xad, 0xae, 0xa6, 0xa8, > }; > -static int jz4770_mac_mii_pins[] = { 0xa7, 0xaf, }; > +static int jz4770_mac_mii_pins[] = { > + 0x7b, 0x7a, 0x7d, 0x7c, 0xa7, 0x24, 0xaf, > +}; > > static const struct group_desc jz4770_groups[] = { > INGENIC_PIN_GROUP("uart0-data", jz4770_uart0_data, 0), > -- > 2.7.4 >
Hi Paul, On 2021/3/23 上午1:53, Paul Cercueil wrote: > Hi Zhou, > > > Le mer. 17 mars 2021 à 17:57, 周琰杰 (Zhou Yanjie) > <zhouyanjie@wanyeetech.com> a écrit : >> The MII group of JZ4770's MAC should have 7 pins, add missing >> pins to the MII group. >> >> Fixes: 5de1a73e78ed ("Pinctrl: Ingenic: Add missing parts for JZ4770 >> and JZ4780.") > > This fixes a commit that was introduced in an older kernel (than the > one in -rc phase). Therefore you need to Cc linux-stable. Like this: > > Cc: <stable@vger.kernel.org> # v5.0 > Sure, I will add it in the next version. >> Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com> > > With that said: > > Reviewed-by: Paul Cercueil <paul@crapouillou.net> > > Cheers, > -Paul > >> --- >> >> Notes: >> v2: >> New patch. >> >> v2->v3: >> Add fixes tag. >> >> drivers/pinctrl/pinctrl-ingenic.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/pinctrl/pinctrl-ingenic.c >> b/drivers/pinctrl/pinctrl-ingenic.c >> index f274612..05dfa0a 100644 >> --- a/drivers/pinctrl/pinctrl-ingenic.c >> +++ b/drivers/pinctrl/pinctrl-ingenic.c >> @@ -667,7 +667,9 @@ static int jz4770_pwm_pwm7_pins[] = { 0x6b, }; >> static int jz4770_mac_rmii_pins[] = { >> 0xa9, 0xab, 0xaa, 0xac, 0xa5, 0xa4, 0xad, 0xae, 0xa6, 0xa8, >> }; >> -static int jz4770_mac_mii_pins[] = { 0xa7, 0xaf, }; >> +static int jz4770_mac_mii_pins[] = { >> + 0x7b, 0x7a, 0x7d, 0x7c, 0xa7, 0x24, 0xaf, >> +}; >> >> static const struct group_desc jz4770_groups[] = { >> INGENIC_PIN_GROUP("uart0-data", jz4770_uart0_data, 0), >> -- >> 2.7.4 >> >
diff --git a/drivers/pinctrl/pinctrl-ingenic.c b/drivers/pinctrl/pinctrl-ingenic.c index f274612..05dfa0a 100644 --- a/drivers/pinctrl/pinctrl-ingenic.c +++ b/drivers/pinctrl/pinctrl-ingenic.c @@ -667,7 +667,9 @@ static int jz4770_pwm_pwm7_pins[] = { 0x6b, }; static int jz4770_mac_rmii_pins[] = { 0xa9, 0xab, 0xaa, 0xac, 0xa5, 0xa4, 0xad, 0xae, 0xa6, 0xa8, }; -static int jz4770_mac_mii_pins[] = { 0xa7, 0xaf, }; +static int jz4770_mac_mii_pins[] = { + 0x7b, 0x7a, 0x7d, 0x7c, 0xa7, 0x24, 0xaf, +}; static const struct group_desc jz4770_groups[] = { INGENIC_PIN_GROUP("uart0-data", jz4770_uart0_data, 0),
The MII group of JZ4770's MAC should have 7 pins, add missing pins to the MII group. Fixes: 5de1a73e78ed ("Pinctrl: Ingenic: Add missing parts for JZ4770 and JZ4780.") Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com> --- Notes: v2: New patch. v2->v3: Add fixes tag. drivers/pinctrl/pinctrl-ingenic.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)