diff mbox series

[v1] gpio: hisi: delete some unused variables in hisi_gpio_probe()

Message ID 1608539124-4914-1-git-send-email-luojiaxing@huawei.com
State New
Headers show
Series [v1] gpio: hisi: delete some unused variables in hisi_gpio_probe() | expand

Commit Message

luojiaxing Dec. 21, 2020, 8:25 a.m. UTC
kernel test rebot report that dat, set and clr in hisi_gpio_probe() is
unused variables. So delete it.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Luo Jiaxing <luojiaxing@huawei.com>
---
 drivers/gpio/gpio-hisi.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Andy Shevchenko Dec. 21, 2020, 10:35 a.m. UTC | #1
On Mon, Dec 21, 2020 at 10:25 AM Luo Jiaxing <luojiaxing@huawei.com> wrote:
>
> kernel test rebot report that dat, set and clr in hisi_gpio_probe() is
> unused variables. So delete it.

Fixes: tag?

> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Luo Jiaxing <luojiaxing@huawei.com>
luojiaxing Dec. 22, 2020, 11:33 a.m. UTC | #2
On 2020/12/21 18:35, Andy Shevchenko wrote:
> On Mon, Dec 21, 2020 at 10:25 AM Luo Jiaxing <luojiaxing@huawei.com> wrote:
>> kernel test rebot report that dat, set and clr in hisi_gpio_probe() is
>> unused variables. So delete it.
> Fixes: tag?


Fixes: 356b01a986a5 ("gpio: gpio-hisi: Add HiSilicon GPIO support")


Should I send v2 to add this tag? or we can ask linus to help to add it 
when apply this?


Thanks

Jiaxing

>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Signed-off-by: Luo Jiaxing <luojiaxing@huawei.com>
Linus Walleij Dec. 27, 2020, 9:09 p.m. UTC | #3
On Mon, Dec 21, 2020 at 9:25 AM Luo Jiaxing <luojiaxing@huawei.com> wrote:

> kernel test rebot report that dat, set and clr in hisi_gpio_probe() is
> unused variables. So delete it.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Luo Jiaxing <luojiaxing@huawei.com>

I fixed this in the tree before sending the pull request to Torvalds so this
problem is already solved.

Yours,
Linus Walleij
diff mbox series

Patch

diff --git a/drivers/gpio/gpio-hisi.c b/drivers/gpio/gpio-hisi.c
index a389780..d2971c9 100644
--- a/drivers/gpio/gpio-hisi.c
+++ b/drivers/gpio/gpio-hisi.c
@@ -254,7 +254,6 @@  static void hisi_gpio_get_pdata(struct device *dev,
 static int hisi_gpio_probe(struct platform_device *pdev)
 {
 	struct device *dev = &pdev->dev;
-	void __iomem *dat, *set, *clr;
 	struct hisi_gpio *hisi_gpio;
 	int port_num;
 	int ret;