Message ID | 1599118222-18990-2-git-send-email-dillon.minfei@gmail.com |
---|---|
State | New |
Headers | show |
Series | Fix TC35894 gpio interrupt bug | expand |
On Thu, Sep 3, 2020 at 9:30 AM <dillon.minfei@gmail.com> wrote: > > From: dillon min <dillon.minfei@gmail.com> > > The offset of regmap is incorrect, j * 8 is move to the > wrong register. > > for example: > > asume i = 0, j = 1. we want to set KPY5 as interrupt > falling edge mode, regmap[0][1] should be TC3589x_GPIOIBE1 0xcd > but, regmap[i] + j * 8 = TC3589x_GPIOIBE0 + 8 ,point to 0xd4, > this is TC3589x_GPIOIE2 not TC3589x_GPIOIBE1. > > Fixes: d88b25be3584 ("gpio: Add TC35892 GPIO driver") > Signed-off-by: dillon min <dillon.minfei@gmail.com> > --- > Queued for fixes. Thanks! Bartosz
diff --git a/drivers/gpio/gpio-tc3589x.c b/drivers/gpio/gpio-tc3589x.c index 58b0da9eb76f..ea3f68a28fea 100644 --- a/drivers/gpio/gpio-tc3589x.c +++ b/drivers/gpio/gpio-tc3589x.c @@ -212,7 +212,7 @@ static void tc3589x_gpio_irq_sync_unlock(struct irq_data *d) continue; tc3589x_gpio->oldregs[i][j] = new; - tc3589x_reg_write(tc3589x, regmap[i] + j * 8, new); + tc3589x_reg_write(tc3589x, regmap[i] + j, new); } }