| Message ID | 1537458141-29761-1-git-send-email-festevam@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | pinctrl: mxs: do not export mxs_pinctrl_probe | expand |
On 20.09.2018 08:42, Fabio Estevam wrote: > From: Fabio Estevam <fabio.estevam@nxp.com> > > No user of mxs_pinctrl_probe() can be built as a module, hence > exporting the symbol is not necessary. Drop EXPORT_SYMBOL_GPL. > > Inspired by a patch from Stefan Agner for the tegra pinctrl driver. > > Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com> Agreed, fixed a similar case in Tegra pinctrl drier. Reviewed-by: Stefan Agner <stefan@agner.ch> > --- > drivers/pinctrl/freescale/pinctrl-mxs.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/pinctrl/freescale/pinctrl-mxs.c b/drivers/pinctrl/freescale/pinctrl-mxs.c > index a612e46..641b308 100644 > --- a/drivers/pinctrl/freescale/pinctrl-mxs.c > +++ b/drivers/pinctrl/freescale/pinctrl-mxs.c > @@ -556,4 +556,3 @@ int mxs_pinctrl_probe(struct platform_device *pdev, > iounmap(d->base); > return ret; > } > -EXPORT_SYMBOL_GPL(mxs_pinctrl_probe);
On Thu, Sep 20, 2018 at 8:42 AM Fabio Estevam <festevam@gmail.com> wrote: > From: Fabio Estevam <fabio.estevam@nxp.com> > > No user of mxs_pinctrl_probe() can be built as a module, hence > exporting the symbol is not necessary. Drop EXPORT_SYMBOL_GPL. > > Inspired by a patch from Stefan Agner for the tegra pinctrl driver. > > Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com> Patch applied. Yours, Linus Walleij
diff --git a/drivers/pinctrl/freescale/pinctrl-mxs.c b/drivers/pinctrl/freescale/pinctrl-mxs.c index a612e46..641b308 100644 --- a/drivers/pinctrl/freescale/pinctrl-mxs.c +++ b/drivers/pinctrl/freescale/pinctrl-mxs.c @@ -556,4 +556,3 @@ int mxs_pinctrl_probe(struct platform_device *pdev, iounmap(d->base); return ret; } -EXPORT_SYMBOL_GPL(mxs_pinctrl_probe);