| Message ID | 1532449768-31980-1-git-send-email-fabio.estevam@nxp.com |
|---|---|
| State | New |
| Headers | show |
| Series | gpio: mxs: Fit writel() into a single line | expand |
On Tue, Jul 24, 2018 at 6:28 PM Fabio Estevam <fabio.estevam@nxp.com> wrote: > There is no need for splitting the writel() call in two lines. > > Make it fit into a single line instead. > > Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com> Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/gpio/gpio-mxs.c b/drivers/gpio/gpio-mxs.c index e2831ee..df30490 100644 --- a/drivers/gpio/gpio-mxs.c +++ b/drivers/gpio/gpio-mxs.c @@ -126,8 +126,7 @@ static int mxs_gpio_set_irq_type(struct irq_data *d, unsigned int type) else writel(pin_mask, pin_addr + MXS_CLR); - writel(pin_mask, - port->base + PINCTRL_IRQSTAT(port) + MXS_CLR); + writel(pin_mask, port->base + PINCTRL_IRQSTAT(port) + MXS_CLR); return 0; }
There is no need for splitting the writel() call in two lines. Make it fit into a single line instead. Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com> --- drivers/gpio/gpio-mxs.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)