From patchwork Fri Oct 6 05:08:09 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Phil Reid X-Patchwork-Id: 822215 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3y7d2R5vZxz9t3m for ; Fri, 6 Oct 2017 16:08:31 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751086AbdJFFI1 (ORCPT ); Fri, 6 Oct 2017 01:08:27 -0400 Received: from anchovy3.45ru.net.au ([203.30.46.155]:48931 "EHLO anchovy.45ru.net.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750970AbdJFFIU (ORCPT ); Fri, 6 Oct 2017 01:08:20 -0400 Received: (qmail 16987 invoked by uid 5089); 6 Oct 2017 05:08:18 -0000 Received: by simscan 1.2.0 ppid: 16953, pid: 16954, t: 0.0266s scanners: regex: 1.2.0 attach: 1.2.0 clamav: 0.88.3/m:40/d:1950 X-RBL: $rbltext Received: from unknown (HELO preid-centos7.electromag.com.au) (preid@electromag.com.au@203.59.230.133) by anchovy2.45ru.net.au with ESMTPA; 6 Oct 2017 05:08:17 -0000 Received: by preid-centos7.electromag.com.au (Postfix, from userid 1000) id B1D5633C1D126; Fri, 6 Oct 2017 13:08:14 +0800 (AWST) From: Phil Reid To: linus.walleij@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com, poeschel@lemonage.de, preid@electromag.com.au, sre@kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH v2 5/7] pinctrl: mcp23s08: add open drain configuration for irq pinctrl Date: Fri, 6 Oct 2017 13:08:09 +0800 Message-Id: <1507266491-73971-6-git-send-email-preid@electromag.com.au> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1507266491-73971-1-git-send-email-preid@electromag.com.au> References: <1507266491-73971-1-git-send-email-preid@electromag.com.au> Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org The mcp23s08 series device can be configured for wired and interupts using an external pullup and open drain output via the IOCON_ODR bit. And "microchip,irq-open-drain" property to enable this. Signed-off-by: Phil Reid Reviewed-by: Sebastian Reichel --- drivers/pinctrl/pinctrl-mcp23s08.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/pinctrl/pinctrl-mcp23s08.c b/drivers/pinctrl/pinctrl-mcp23s08.c index 8d356df..150f216 100644 --- a/drivers/pinctrl/pinctrl-mcp23s08.c +++ b/drivers/pinctrl/pinctrl-mcp23s08.c @@ -780,6 +780,7 @@ static int mcp23s08_probe_one(struct mcp23s08 *mcp, struct device *dev, { int status, ret; bool mirror = false; + bool open_drain = false; mutex_init(&mcp->lock); @@ -876,6 +877,8 @@ static int mcp23s08_probe_one(struct mcp23s08 *mcp, struct device *dev, "microchip,irq-active-high"); mirror = device_property_read_bool(dev, "microchip,irq-mirror"); + open_drain = device_property_read_bool(dev, + "microchip,irq-open-drain"); } if ((status & IOCON_SEQOP) || !(status & IOCON_HAEN) || mirror || @@ -891,6 +894,9 @@ static int mcp23s08_probe_one(struct mcp23s08 *mcp, struct device *dev, if (mirror) status |= IOCON_MIRROR | (IOCON_MIRROR << 8); + if (open_drain) + status |= IOCON_ODR | (IOCON_ODR << 8); + if (type == MCP_TYPE_S18 || type == MCP_TYPE_018) status |= IOCON_INTCC | (IOCON_INTCC << 8);