| Message ID | 1507266491-73971-2-git-send-email-preid@electromag.com.au |
|---|---|
| State | New |
| Headers | show |
| Series | pinctrl: mcp32s08: add support for mcp23018 | expand |
Hi, On Fri, Oct 06, 2017 at 01:08:05PM +0800, Phil Reid wrote: > This allows PINCTRL to be selected manually to allow enabling of the > mcp23s08 i2c/spi gpio driver. Which is not platform specific. FWIW with i2c/spi based pin controllers available it makes sense to have this available everywhere. I actually did test my changes using an i2c-tiny-usb controller with my x86 based notebook, so: Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk> -- Sebastian > Signed-off-by: Phil Reid <preid@electromag.com.au> > --- > drivers/pinctrl/Kconfig | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig > index 1778cf4..8da29e9 100644 > --- a/drivers/pinctrl/Kconfig > +++ b/drivers/pinctrl/Kconfig > @@ -2,11 +2,10 @@ > # PINCTRL infrastructure and drivers > # > > -config PINCTRL > - bool > +menuconfig PINCTRL > + bool "Pin controllers" > > -menu "Pin controllers" > - depends on PINCTRL > +if PINCTRL > > config GENERIC_PINCTRL_GROUPS > bool > @@ -379,4 +378,4 @@ config PINCTRL_TB10X > depends on OF && ARC_PLAT_TB10X > select GPIOLIB > > -endmenu > +endif > -- > 1.8.3.1 >
On Fri, Oct 6, 2017 at 7:08 AM, Phil Reid <preid@electromag.com.au> wrote: > This allows PINCTRL to be selected manually to allow enabling of the > mcp23s08 i2c/spi gpio driver. Which is not platform specific. > > Signed-off-by: Phil Reid <preid@electromag.com.au> Patch applied with Sebastian's review tag. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig index 1778cf4..8da29e9 100644 --- a/drivers/pinctrl/Kconfig +++ b/drivers/pinctrl/Kconfig @@ -2,11 +2,10 @@ # PINCTRL infrastructure and drivers # -config PINCTRL - bool +menuconfig PINCTRL + bool "Pin controllers" -menu "Pin controllers" - depends on PINCTRL +if PINCTRL config GENERIC_PINCTRL_GROUPS bool @@ -379,4 +378,4 @@ config PINCTRL_TB10X depends on OF && ARC_PLAT_TB10X select GPIOLIB -endmenu +endif
This allows PINCTRL to be selected manually to allow enabling of the mcp23s08 i2c/spi gpio driver. Which is not platform specific. Signed-off-by: Phil Reid <preid@electromag.com.au> --- drivers/pinctrl/Kconfig | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-)