From patchwork Fri Jan 27 11:14:02 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shailendra Verma X-Patchwork-Id: 720621 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3v8x571PFyz9tjw for ; Fri, 27 Jan 2017 22:14:35 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933503AbdA0LOQ (ORCPT ); Fri, 27 Jan 2017 06:14:16 -0500 Received: from mailout1.samsung.com ([203.254.224.24]:47135 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934053AbdA0LOO (ORCPT ); Fri, 27 Jan 2017 06:14:14 -0500 Received: from epcas4p1.samsung.com (unknown [182.195.41.31]) by mailout1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0OKF0074XR7P1B20@mailout1.samsung.com>; Fri, 27 Jan 2017 20:14:13 +0900 (KST) Received: from epsmges4p4.samsung.com (unknown [182.195.42.36]) by epcas4p2.samsung.com (KnoxPortal) with ESMTP id 20170127111412epcas4p28580bebf8e38ce72a4fa04027b7597b3~dnJ1wsHXs3218732187epcas4p22; Fri, 27 Jan 2017 11:14:12 +0000 (GMT) Received: from epcas4p1.samsung.com ( [182.195.41.31]) by epsmges4p4.samsung.com (EPCPMTA) with SMTP id F2.8F.06699.48B2B885; Fri, 27 Jan 2017 20:14:12 +0900 (KST) Received: from epsmgmsp04.samsung.com (unknown [182.195.34.25]) by epcas4p1.samsung.com (KnoxPortal) with ESMTP id 20170127111411epcas4p19f0ff2dc9c16dfa5346d1770338da8eb~dnJ06LFZK2762327623epcas4p1c; Fri, 27 Jan 2017 11:14:11 +0000 (GMT) X-AuditID: b6c32a24-f79ea6d000001a2b-62-588b2b846934 Received: from srin.p4 (Unknown_Domain [107.108.168.37]) by epsmgmsp04.samsung.com (EPCPMTA) with SMTP id 05.CC.04872.08B2B885; Fri, 27 Jan 2017 20:14:11 +0900 (KST) From: Shailendra Verma To: Linus Walleij , Alexandre Courbot , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, p.shailesh@samsung.com, ashish.kalra@samsung.com, Shailendra Verma , Shailendra Verma Subject: [PATCH] Gpio - Fix possible NULL derefrence. Date: Fri, 27 Jan 2017 16:44:02 +0530 Message-id: <1485515642-3310-1-git-send-email-shailendra.v@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrCIsWRmVeSWpSXmKPExsWy7bCmvG6LdneEwZrnLBb3p31jtzj36hGL xZQ/y5ksNs//w2hxedccNosdU1pZLG7Nm8lmsejbK2YHDo+ds+6ye9y5tofNo2/LKkaPz5vk AliiuGxSUnMyy1KL9O0SuDKuze5iKjjBWfFuwwWWBsaX7F2MnBwSAiYSHZOvsULYYhIX7q1n 62Lk4hASWMoo0fn3FQuE85lRonH2FaYuRg6wjtV3A0EahARWMkpsXaoBYrMJGEq87vvLBFIv IrCMSeLalotgG4QFTCXaWq+B2SwCqhI7H69lBJnDK+Au8WK3E8RIBYk5k2xAWiUEjrBJtH9Y yQwRl5XYdIAZ4jYXicdfuxghbGGJV8e3QN0vJXFy9gN2iN5jjBKPny9mgnAuM0psOb0Mqspe 4tqt12A2swCfxJzug1C/8Ep0tAlBlHhInLn6hAXCdpQ42XyRFeLHWIlXW6exTWCUXMDIsIpR LLWgODc9tdikwESvODG3uDQvXS85P3cTIzjutFR2MP5Y4H2IUYCDUYmH1yG0K0KINbGsuDL3 EKMEB7OSCK+uWHeEEG9KYmVValF+fFFpTmrxIUZpDhYlcd7rDdYRQgLpiSWp2ampBalFMFkm Dk6pBkbXi9lGt47o7nQyDa/Zp7o0q/IGX7HX4oTdpzn0ExZtSYm6nZTkbxt8UX/19Ja5ptoM 1wy8H6tsrE+rbb8XdXONsShn+dZpUh6qKVnyMiFp064yRvlOMxMqdZQr8y9N3vh27x+fpls+ l0MXLzBecUpT64j3s79Vf1InKZR1WJpO2bNqTvEdbSWW4oxEQy3mouJEABjru123AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrBLMWRmVeSWpSXmKPExsWSnbNCVbdZuzvCYOJRLov7076xW5x79YjF Ysqf5UwWm+f/YbS4vGsOm8WOKa0sFrfmzWSzWPTtFbMDh8fOWXfZPe5c28Pm0bdlFaPH501y ASxRbjYZqYkpqUUKqXnJ+SmZeem2SqEhbroWSgp5ibmptkoRur4hQUoKZYk5pUCekQEacHAO cA9W0rdLcMu4NruLqeAEZ8W7DRdYGhhfsncxcnBICJhIrL4b2MXICWSKSVy4t56ti5GLQ0hg OaPEu90HWUASbAKGEq/7/jKBJEQE1jBJLN60jxUkISxgKtHWeo0dxGYRUJXY+XgtI8hQXgF3 iRe7nSDmK0jMmWQzgZFzASPDKkax1ILi3PTc4gIDE73ixNzi0rx0veT83E2MwFDbdlhJcgfj qhVehxgFOBiVeHh37OuKEGJNLCuuzD3EKMHBrCTCqyvWHSHEm5JYWZValB9fVJqTWnyI0RRo +URmKdHkfGAc5JXEG5qYWlhYmFgaGxtbmCiJ88ZOfxYuJJCeWJKanZpakFoE08fEwSnVwLhW x2GXcvWsOfqLGvkae3Vfu5eU5957O2fxFP5b8Xv8CpichH/Nendd7+K5uu1cUUv++Tg9i181 QYh3fceWy617VDYG2Zn2eOzgsH/0aMfKg//v3H8Z/L+hLdalN7mm4VESQ5TI0SOWWzM3tLd4 PN55Y0WhcuzB2/ISJ06XB51u6dopVvtYMVSJpTgj0VCLuag4EQAkbq7KSwIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170127111411epcas4p19f0ff2dc9c16dfa5346d1770338da8eb X-Msg-Generator: CA X-Sender-IP: 182.195.34.25 X-Local-Sender: =?UTF-8?B?U2hhaWxlbmRyYSBWZXJtYRtTUkktTm9pZGEtQ29tbWVyY2lh?= =?UTF-8?B?bCBSJkQgIFN5c3RlbSBTL1cgR3JvdXAb7IK87ISx7KCE7J6QG0xlYWQgRW5n?= =?UTF-8?B?aW5lZXIvQ29ycG9yYXRlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?U2hhaWxlbmRyYSBWZXJtYRtTUkktTm9pZGEtQ29tbWVyY2lh?= =?UTF-8?B?bCBSJkQgIFN5c3RlbSBTL1cgR3JvdXAbU2Ftc3VuZyBFbGVjdHJvbmljcxtM?= =?UTF-8?B?ZWFkIEVuZ2luZWVyL0NvcnBvcmF0ZSBFbmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG1NXQUhRG0MxMElaMDFJWjAxODEyMA==?= CMS-TYPE: 104P X-HopCount: 7 X-CMS-RootMailID: 20170127111411epcas4p19f0ff2dc9c16dfa5346d1770338da8eb X-RootMTR: 20170127111411epcas4p19f0ff2dc9c16dfa5346d1770338da8eb References: Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org of_match_device could return NULL, and so can cause a NULL pointer dereference later. Signed-off-by: Shailendra Verma --- drivers/gpio/gpio-ge.c | 5 +++++ drivers/gpio/gpio-mxs.c | 5 +++++ 2 files changed, 10 insertions(+) diff --git a/drivers/gpio/gpio-ge.c b/drivers/gpio/gpio-ge.c index 8650b29..395a85d 100644 --- a/drivers/gpio/gpio-ge.c +++ b/drivers/gpio/gpio-ge.c @@ -59,6 +59,11 @@ static int __init gef_gpio_probe(struct platform_device *pdev) void __iomem *regs; int ret; + if (!of_id) { + dev_err(&pdev->dev, "Error: No device match found\n"); + return -ENODEV; + } + gc = devm_kzalloc(&pdev->dev, sizeof(*gc), GFP_KERNEL); if (!gc) return -ENOMEM; diff --git a/drivers/gpio/gpio-mxs.c b/drivers/gpio/gpio-mxs.c index ee17248..e28097f 100644 --- a/drivers/gpio/gpio-mxs.c +++ b/drivers/gpio/gpio-mxs.c @@ -272,6 +272,11 @@ static int mxs_gpio_probe(struct platform_device *pdev) int irq_base; int err; + if (!of_id) { + dev_err(&pdev->dev, "Error: No device match found\n"); + return -ENODEV; + } + port = devm_kzalloc(&pdev->dev, sizeof(*port), GFP_KERNEL); if (!port) return -ENOMEM;