From patchwork Fri Sep 9 09:19:29 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 667942 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3sVs9T6fMdz9ryv for ; Fri, 9 Sep 2016 19:19:57 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b=SVnR7WfF; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750839AbcIIJTk (ORCPT ); Fri, 9 Sep 2016 05:19:40 -0400 Received: from mail-wm0-f46.google.com ([74.125.82.46]:38159 "EHLO mail-wm0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752452AbcIIJTh (ORCPT ); Fri, 9 Sep 2016 05:19:37 -0400 Received: by mail-wm0-f46.google.com with SMTP id 1so21515972wmz.1 for ; Fri, 09 Sep 2016 02:19:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=4MQn8bWeRCA0eUKzxWVI6zIqvgt0SweSu2s6G+MTazE=; b=SVnR7WfFAgK+bfqi0pYdZaeD6d15MrY/mqPfGBAiNx2yCt42rugmZjoCty9keVHVyk ec0v6kWpF5QF0q1TLW2++yxRxHklGwrT/VTv7zqyZNn4JW3HMvheodLNgxCeKfCaMr6z 35dx1v+QNikRLhmVChs1F1dJPVXG6hJfk4wWAxhphH/QUNmXS0ObneSFyO48KSEHubq/ AxJJjUC+MezIQyPndnNdEdodkHExG57cq14mTshfHrFCDDk9bRIGeNfBZRn63h06QKzE jfHjurd5PErdEzaBWbQmV6L8+fm0TCM0g77pyV67CMBmXVQc7lleT7UItEP8i+jc/2+M TeNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=4MQn8bWeRCA0eUKzxWVI6zIqvgt0SweSu2s6G+MTazE=; b=ju6yEGLjRxcgByPM0dPa4bYMoMhqWiUFHAWAkyjlcfUZSo28koeCqoHZ2ebv51Q8ql 8H6qTQpyh6lX5BaOZVgaVvFS3KkzjLCbHXr2ozlTf1M07CgqkBuQa0YRDgEAh9iwhuqr xwMqV5tmJ5CMMz2AVFxqGIN4yJOMF2fI+9hBUQZDOX9LZCsoVBv3ChiWLIzH6OSUhgL5 NRApoo9xX1xHmb0wK/3PL8RRBj3tWoNAowOTHVCRJqLe2Ls5UG7GfWaPm9SZu4cOuH0l efBxQxp5xaQ0eZ2N86FocVbO+pUMgFCNTKURVMfYiPeJI04hj+Z5qul3w2mwqr8sD+jZ +Jgw== X-Gm-Message-State: AE9vXwMq+GWyk4HKlwxui8gTW6wHXHXIT85DZK5tjx0BpTZCndcvAaHNTCpJyNt3wOsRKk1K X-Received: by 10.194.8.226 with SMTP id u2mr2364274wja.153.1473412776051; Fri, 09 Sep 2016 02:19:36 -0700 (PDT) Received: from bgdev-debian.lan (jua06-1-82-242-157-225.fbx.proxad.net. [82.242.157.225]) by smtp.gmail.com with ESMTPSA id f8sm2366737wjh.45.2016.09.09.02.19.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 09 Sep 2016 02:19:35 -0700 (PDT) From: Bartosz Golaszewski To: Linus Walleij , Alexandre Courbot , Andy Shevchenko , Vignesh R , Yong Li , Geert Uytterhoeven Cc: linux-gpio , LKML , Bartosz Golaszewski Subject: [PATCH] gpio: gpiolib: fix an incorrect use of WARN_ON() Date: Fri, 9 Sep 2016 11:19:29 +0200 Message-Id: <1473412769-17428-1-git-send-email-bgolaszewski@baylibre.com> X-Mailer: git-send-email 2.1.4 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org This breaks the build due to the format string being passed as argument. Fix it by using WARN(). Signed-off-by: Bartosz Golaszewski --- NOTE This patch applies on top of linux-gpio devel branch. drivers/gpio/gpiolib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 95effec..384ed0a 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -1618,8 +1618,8 @@ int _gpiochip_irqchip_add(struct gpio_chip *gpiochip, * used to configure the interrupts, as you may end-up with * conflicting triggers. Tell the user, and reset to NONE. */ - if (WARN_ON(of_node && type != IRQ_TYPE_NONE, - "%s: Ignoring %d default trigger\n", of_node->full_name)) + if (WARN(of_node && type != IRQ_TYPE_NONE, + "%s: Ignoring default trigger\n", of_node->full_name)) type = IRQ_TYPE_NONE; gpiochip->irqchip = irqchip;