diff mbox

[1/2] gpio: mmio: add brcm,bcm6345 support

Message ID 1470222135-4731-1-git-send-email-noltari@gmail.com
State Superseded
Headers show

Commit Message

Álvaro Fernández Rojas Aug. 3, 2016, 11:02 a.m. UTC 
From: Christian Lamparter <chunkeey@googlemail.com>

This patch adds support for the GPIO found in Broadcom's bcm63xx-gpio
chips.
This GPIOs is used in the following Broadcom SoCs: BCM6338, BCM6345.
It shouldn't be used in newer Broadcom SoCs since they need a proper pinctrl driver.

Signed-off-by: Christian Lamparter <chunkeey@googlemail.com>
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
---
 drivers/gpio/gpio-mmio.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

kernel test robot Aug. 3, 2016, 11:28 a.m. UTC | #1 
Hi Christian,

[auto build test ERROR on gpio/for-next]
[also build test ERROR on next-20160803]
[cannot apply to v4.7]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/lvaro-Fern-ndez-Rojas/gpio-mmio-add-brcm-bcm6345-support/20160803-191501
base:   https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git for-next
config: sparc64-allyesconfig (attached as .config)
compiler: sparc64-linux-gnu-gcc (Debian 5.4.0-6) 5.4.0 20160609
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=sparc64 

All errors (new ones prefixed by >>):

   drivers/gpio/gpio-mmio.c: In function 'bgpio_parse_dt':
>> drivers/gpio/gpio-mmio.c:597:30: error: 'dev' undeclared (first use in this function)
     if (of_device_is_big_endian(dev->of_node))
                                 ^
   drivers/gpio/gpio-mmio.c:597:30: note: each undeclared identifier is reported only once for each function it appears in

vim +/dev +597 drivers/gpio/gpio-mmio.c

   591				     GFP_KERNEL);
   592		if (!pdata)
   593			return ERR_PTR(-ENOMEM);
   594	
   595		pdata->base = -1;
   596	
 > 597		if (of_device_is_big_endian(dev->of_node))
   598			*flags |= BGPIOF_BIG_ENDIAN_BYTE_ORDER;
   599	
   600		if (of_property_read_bool(pdev->dev.of_node, "no-output"))

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
kernel test robot Aug. 3, 2016, 11:38 a.m. UTC | #2 
Hi Christian,

[auto build test WARNING on gpio/for-next]
[also build test WARNING on next-20160803]
[cannot apply to v4.7]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/lvaro-Fern-ndez-Rojas/gpio-mmio-add-brcm-bcm6345-support/20160803-191501
base:   https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git for-next
config: x86_64-randconfig-x002-201631 (attached as .config)
compiler: gcc-6 (Debian 6.1.1-9) 6.1.1 20160705
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All warnings (new ones prefixed by >>):

   In file included from include/linux/init.h:4:0,
                    from drivers/gpio/gpio-mmio.c:47:
   drivers/gpio/gpio-mmio.c: In function 'bgpio_parse_dt':
   drivers/gpio/gpio-mmio.c:597:30: error: 'dev' undeclared (first use in this function)
     if (of_device_is_big_endian(dev->of_node))
                                 ^
   include/linux/compiler.h:149:30: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                 ^~~~
>> drivers/gpio/gpio-mmio.c:597:2: note: in expansion of macro 'if'
     if (of_device_is_big_endian(dev->of_node))
     ^~
   drivers/gpio/gpio-mmio.c:597:30: note: each undeclared identifier is reported only once for each function it appears in
     if (of_device_is_big_endian(dev->of_node))
                                 ^
   include/linux/compiler.h:149:30: note: in definition of macro '__trace_if'
     if (__builtin_constant_p(!!(cond)) ? !!(cond) :   \
                                 ^~~~
>> drivers/gpio/gpio-mmio.c:597:2: note: in expansion of macro 'if'
     if (of_device_is_big_endian(dev->of_node))
     ^~

vim +/if +597 drivers/gpio/gpio-mmio.c

   581	
   582	static struct bgpio_pdata *bgpio_parse_dt(struct platform_device *pdev,
   583						  unsigned long *flags)
   584	{
   585		struct bgpio_pdata *pdata;
   586	
   587		if (!of_match_device(bgpio_of_match, &pdev->dev))
   588			return NULL;
   589	
   590		pdata = devm_kzalloc(&pdev->dev, sizeof(struct bgpio_pdata),
   591				     GFP_KERNEL);
   592		if (!pdata)
   593			return ERR_PTR(-ENOMEM);
   594	
   595		pdata->base = -1;
   596	
 > 597		if (of_device_is_big_endian(dev->of_node))
   598			*flags |= BGPIOF_BIG_ENDIAN_BYTE_ORDER;
   599	
   600		if (of_property_read_bool(pdev->dev.of_node, "no-output"))
   601			*flags |= BGPIOF_NO_OUTPUT;
   602	
   603		return pdata;
   604	}
   605	#else

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
diff mbox

Patch

diff --git a/drivers/gpio/gpio-mmio.c b/drivers/gpio/gpio-mmio.c
index 6ec144b..4a4830d 100644
--- a/drivers/gpio/gpio-mmio.c
+++ b/drivers/gpio/gpio-mmio.c
@@ -573,6 +573,7 @@  static void __iomem *bgpio_map(struct platform_device *pdev,
 
 #ifdef CONFIG_OF
 static const struct of_device_id bgpio_of_match[] = {
+	{ .compatible = "brcm,bcm6345-gpio" },
 	{ .compatible = "wd,mbl-gpio" },
 	{ }
 };
@@ -593,6 +594,9 @@  static struct bgpio_pdata *bgpio_parse_dt(struct platform_device *pdev,
 
 	pdata->base = -1;
 
+	if (of_device_is_big_endian(dev->of_node))
+		*flags |= BGPIOF_BIG_ENDIAN_BYTE_ORDER;
+
 	if (of_property_read_bool(pdev->dev.of_node, "no-output"))
 		*flags |= BGPIOF_NO_OUTPUT;