From patchwork Sun Jul 10 02:17:36 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: weiyj_lk@163.com X-Patchwork-Id: 646717 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3rnBj24L6Nz9s9G for ; Sun, 10 Jul 2016 12:18:12 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=163.com header.i=@163.com header.b=JaB6kuPg; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932101AbcGJCSI (ORCPT ); Sat, 9 Jul 2016 22:18:08 -0400 Received: from m12-11.163.com ([220.181.12.11]:43862 "EHLO m12-11.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932100AbcGJCSH (ORCPT ); Sat, 9 Jul 2016 22:18:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=kzF3d BgCosBnaEGD5PwcEcmneXBhgGXSl99nquK9hpk=; b=JaB6kuPg2g8WOF2O5Ojis Te7QTECGK/P7727UxApk3a73yq0jSY5Hxm3SDu2W9cyekahapiMi9AtJr/vo0HLk vTnqePgO/ukXBD/meduX+/RWlxY41RF2mOsM9wyVZQr3qB4nBJoqf57IXjivCaly f8kSyADJQDhnZJpeekvJFU= Received: from localhost.localdomain.localdomain (unknown [49.77.231.212]) by smtp7 (Coremail) with SMTP id C8CowADHm11BsIFXH1kWCA--.58935S2; Sun, 10 Jul 2016 10:17:38 +0800 (CST) From: weiyj_lk@163.com To: Linus Walleij , Alexandre Courbot , Jiang Qiu Cc: Wei Yongjun , linux-gpio@vger.kernel.org Subject: [PATCH -next] gpio: dwapb: add missing fwnode_handle_put() in dwapb_gpio_get_pdata() Date: Sun, 10 Jul 2016 02:17:36 +0000 Message-Id: <1468117056-14370-1-git-send-email-weiyj_lk@163.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-CM-TRANSID: C8CowADHm11BsIFXH1kWCA--.58935S2 X-Coremail-Antispam: 1Uf129KBjvdXoW7WryUXr1xuw47Aw4fur4fuFg_yoWfXFg_C3 s8Zr43Xrn8AFZ2qrZIkFyavF9avr4kZr4ruw1kKrs3K3Wq9rW5Gr1Dua4fJr9rXr45KrZI vw10qr4I9w47WjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IU0bTmDUUUUU== X-Originating-IP: [49.77.231.212] X-CM-SenderInfo: pzhl5yxbonqiywtou0bp/1tbiGQKi1lXlTyn-iQAAsP Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org From: Wei Yongjun fwnode_handle_put() should be used when terminating device_for_each_child_node() iteration with break or return to prevent stale device node references from being left behind. Generated by Coccinelle. Fixes: 4ba8cfa79f44 ("gpio: dwapb: convert device node to fwnode") Signed-off-by: Wei Yongjun --- drivers/gpio/gpio-dwapb.c | 1 + 1 file changed, 1 insertion(+) -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c index 34779bb..6193f62 100644 --- a/drivers/gpio/gpio-dwapb.c +++ b/drivers/gpio/gpio-dwapb.c @@ -486,6 +486,7 @@ dwapb_gpio_get_pdata(struct device *dev) pp->idx >= DWAPB_MAX_PORTS) { dev_err(dev, "missing/invalid port index for port%d\n", i); + fwnode_handle_put(fwnode); return ERR_PTR(-EINVAL); }