Message ID | 1461353935-8078-1-git-send-email-ville.syrjala@linux.intel.com |
---|---|
State | New |
Headers | show |
On Fri, 22 Apr 2016, ville.syrjala@linux.intel.com wrote: > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > GPIO lookup tables are supposed to be zero terminated. Let's do that > and avoid accidentally walking off the end. > > Cc: Shobhit Kumar <shobhit.kumar@intel.com> > Cc: Samuel Ortiz <sameo@linux.intel.com> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Alexandre Courbot <gnurou@gmail.com> > Cc: Thierry Reding <thierry.reding@gmail.com> > Cc: Lee Jones <lee.jones@linaro.org> > Cc: stable@vger.kernel.org > Fixes: 61dd2ca2d44e ("mfd: intel_soc_pmic_core: Add lookup table for Panel Control as GPIO signal") > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Reviewed-by: Jani Nikula <jani.nikula@intel.com> > --- > drivers/mfd/intel_soc_pmic_core.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mfd/intel_soc_pmic_core.c b/drivers/mfd/intel_soc_pmic_core.c > index d9e15cf7c6c8..12d6ebb4ae5d 100644 > --- a/drivers/mfd/intel_soc_pmic_core.c > +++ b/drivers/mfd/intel_soc_pmic_core.c > @@ -35,6 +35,7 @@ static struct gpiod_lookup_table panel_gpio_table = { > .table = { > /* Panel EN/DISABLE */ > GPIO_LOOKUP("gpio_crystalcove", 94, "panel", GPIO_ACTIVE_HIGH), > + { }, > }, > };
On Fri, Apr 22, 2016 at 10:38:55PM +0300, ville.syrjala@linux.intel.com wrote: > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > GPIO lookup tables are supposed to be zero terminated. Let's do that > and avoid accidentally walking off the end. > > Cc: Shobhit Kumar <shobhit.kumar@intel.com> > Cc: Samuel Ortiz <sameo@linux.intel.com> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Alexandre Courbot <gnurou@gmail.com> > Cc: Thierry Reding <thierry.reding@gmail.com> > Cc: Lee Jones <lee.jones@linaro.org> > Cc: stable@vger.kernel.org > Fixes: 61dd2ca2d44e ("mfd: intel_soc_pmic_core: Add lookup table for Panel Control as GPIO signal") > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > --- > drivers/mfd/intel_soc_pmic_core.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Thierry Reding <treding@nvidia.com>
On Fri, Apr 22, 2016 at 9:38 PM, <ville.syrjala@linux.intel.com> wrote: > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > GPIO lookup tables are supposed to be zero terminated. Let's do that > and avoid accidentally walking off the end. > > Cc: Shobhit Kumar <shobhit.kumar@intel.com> > Cc: Samuel Ortiz <sameo@linux.intel.com> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Alexandre Courbot <gnurou@gmail.com> > Cc: Thierry Reding <thierry.reding@gmail.com> > Cc: Lee Jones <lee.jones@linaro.org> > Cc: stable@vger.kernel.org > Fixes: 61dd2ca2d44e ("mfd: intel_soc_pmic_core: Add lookup table for Panel Control as GPIO signal") > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> Acked-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Apr 29, 2016 at 11:31:44AM +0200, Linus Walleij wrote: > On Fri, Apr 22, 2016 at 9:38 PM, <ville.syrjala@linux.intel.com> wrote: > > > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > > > GPIO lookup tables are supposed to be zero terminated. Let's do that > > and avoid accidentally walking off the end. > > > > Cc: Shobhit Kumar <shobhit.kumar@intel.com> > > Cc: Samuel Ortiz <sameo@linux.intel.com> > > Cc: Linus Walleij <linus.walleij@linaro.org> > > Cc: Alexandre Courbot <gnurou@gmail.com> > > Cc: Thierry Reding <thierry.reding@gmail.com> > > Cc: Lee Jones <lee.jones@linaro.org> > > Cc: stable@vger.kernel.org > > Fixes: 61dd2ca2d44e ("mfd: intel_soc_pmic_core: Add lookup table for Panel Control as GPIO signal") > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > > Acked-by: Linus Walleij <linus.walleij@linaro.org> Applied to drm-intel trees, thanks for patch, reviews&acks. -Daniel
On Mon, 02 May 2016, Daniel Vetter wrote: > On Fri, Apr 29, 2016 at 11:31:44AM +0200, Linus Walleij wrote: > > On Fri, Apr 22, 2016 at 9:38 PM, <ville.syrjala@linux.intel.com> wrote: > > > > > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > > > > > GPIO lookup tables are supposed to be zero terminated. Let's do that > > > and avoid accidentally walking off the end. > > > > > > Cc: Shobhit Kumar <shobhit.kumar@intel.com> > > > Cc: Samuel Ortiz <sameo@linux.intel.com> > > > Cc: Linus Walleij <linus.walleij@linaro.org> > > > Cc: Alexandre Courbot <gnurou@gmail.com> > > > Cc: Thierry Reding <thierry.reding@gmail.com> > > > Cc: Lee Jones <lee.jones@linaro.org> > > > Cc: stable@vger.kernel.org > > > Fixes: 61dd2ca2d44e ("mfd: intel_soc_pmic_core: Add lookup table for Panel Control as GPIO signal") > > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > > > > Acked-by: Linus Walleij <linus.walleij@linaro.org> > > Applied to drm-intel trees, thanks for patch, reviews&acks. Do what now? How can you apply a patch for a subsystem you don't have responsibility for? This is bound to cause merge conflicts.
On Wed, May 04, 2016 at 08:32:17AM +0100, Lee Jones wrote: > On Mon, 02 May 2016, Daniel Vetter wrote: > > > On Fri, Apr 29, 2016 at 11:31:44AM +0200, Linus Walleij wrote: > > > On Fri, Apr 22, 2016 at 9:38 PM, <ville.syrjala@linux.intel.com> wrote: > > > > > > > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > > > > > > > GPIO lookup tables are supposed to be zero terminated. Let's do that > > > > and avoid accidentally walking off the end. > > > > > > > > Cc: Shobhit Kumar <shobhit.kumar@intel.com> > > > > Cc: Samuel Ortiz <sameo@linux.intel.com> > > > > Cc: Linus Walleij <linus.walleij@linaro.org> > > > > Cc: Alexandre Courbot <gnurou@gmail.com> > > > > Cc: Thierry Reding <thierry.reding@gmail.com> > > > > Cc: Lee Jones <lee.jones@linaro.org> > > > > Cc: stable@vger.kernel.org > > > > Fixes: 61dd2ca2d44e ("mfd: intel_soc_pmic_core: Add lookup table for Panel Control as GPIO signal") > > > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > > > > > > Acked-by: Linus Walleij <linus.walleij@linaro.org> > > > > Applied to drm-intel trees, thanks for patch, reviews&acks. > > Do what now? How can you apply a patch for a subsystem you don't have > responsibility for? This is bound to cause merge conflicts. Oh crap, I thought Linus' ack was for the mfd stuff and didn't bother double-checking with MAINTAINTERS. Should I throw it out again and you'll pick it up, or ok as such? Thanks, Daniel
On Mon, 09 May 2016, Daniel Vetter wrote: > On Wed, May 04, 2016 at 08:32:17AM +0100, Lee Jones wrote: > > On Mon, 02 May 2016, Daniel Vetter wrote: > > > > > On Fri, Apr 29, 2016 at 11:31:44AM +0200, Linus Walleij wrote: > > > > On Fri, Apr 22, 2016 at 9:38 PM, <ville.syrjala@linux.intel.com> wrote: > > > > > > > > > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > > > > > > > > > GPIO lookup tables are supposed to be zero terminated. Let's do that > > > > > and avoid accidentally walking off the end. > > > > > > > > > > Cc: Shobhit Kumar <shobhit.kumar@intel.com> > > > > > Cc: Samuel Ortiz <sameo@linux.intel.com> > > > > > Cc: Linus Walleij <linus.walleij@linaro.org> > > > > > Cc: Alexandre Courbot <gnurou@gmail.com> > > > > > Cc: Thierry Reding <thierry.reding@gmail.com> > > > > > Cc: Lee Jones <lee.jones@linaro.org> > > > > > Cc: stable@vger.kernel.org > > > > > Fixes: 61dd2ca2d44e ("mfd: intel_soc_pmic_core: Add lookup table for Panel Control as GPIO signal") > > > > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > > > > > > > > Acked-by: Linus Walleij <linus.walleij@linaro.org> > > > > > > Applied to drm-intel trees, thanks for patch, reviews&acks. > > > > Do what now? How can you apply a patch for a subsystem you don't have > > responsibility for? This is bound to cause merge conflicts. > > Oh crap, I thought Linus' ack was for the mfd stuff and didn't bother > double-checking with MAINTAINTERS. Should I throw it out again and you'll > pick it up, or ok as such? Yes please.
On Fri, 22 Apr 2016, ville.syrjala@linux.intel.com wrote: > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > > GPIO lookup tables are supposed to be zero terminated. Let's do that > and avoid accidentally walking off the end. > > Cc: Shobhit Kumar <shobhit.kumar@intel.com> > Cc: Samuel Ortiz <sameo@linux.intel.com> > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Alexandre Courbot <gnurou@gmail.com> > Cc: Thierry Reding <thierry.reding@gmail.com> > Cc: Lee Jones <lee.jones@linaro.org> > Cc: stable@vger.kernel.org > Fixes: 61dd2ca2d44e ("mfd: intel_soc_pmic_core: Add lookup table for Panel Control as GPIO signal") > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com> > --- > drivers/mfd/intel_soc_pmic_core.c | 1 + > 1 file changed, 1 insertion(+) Applied with Linus' and Daniel's Ack. > diff --git a/drivers/mfd/intel_soc_pmic_core.c b/drivers/mfd/intel_soc_pmic_core.c > index d9e15cf7c6c8..12d6ebb4ae5d 100644 > --- a/drivers/mfd/intel_soc_pmic_core.c > +++ b/drivers/mfd/intel_soc_pmic_core.c > @@ -35,6 +35,7 @@ static struct gpiod_lookup_table panel_gpio_table = { > .table = { > /* Panel EN/DISABLE */ > GPIO_LOOKUP("gpio_crystalcove", 94, "panel", GPIO_ACTIVE_HIGH), > + { }, > }, > }; >
diff --git a/drivers/mfd/intel_soc_pmic_core.c b/drivers/mfd/intel_soc_pmic_core.c index d9e15cf7c6c8..12d6ebb4ae5d 100644 --- a/drivers/mfd/intel_soc_pmic_core.c +++ b/drivers/mfd/intel_soc_pmic_core.c @@ -35,6 +35,7 @@ static struct gpiod_lookup_table panel_gpio_table = { .table = { /* Panel EN/DISABLE */ GPIO_LOOKUP("gpio_crystalcove", 94, "panel", GPIO_ACTIVE_HIGH), + { }, }, };