| Message ID | 1459408452-3483-1-git-send-email-linus.walleij@linaro.org |
|---|---|
| State | New |
| Headers | show |
On Thu, 2016-03-31 at 09:14 +0200, Linus Walleij wrote: > commit 0d36fe65f58391712e11a6621075f373216e5f00 > "powerpc: ppc4xx: use gpiochip data pointer" > made the mm_gc local variable in ppc4xx_gpio_set() > redundant, and when GCC treats warnings as errors this > happens: > > arch/powerpc/sysdev/ppc4xx_gpio.c: In function 'ppc4xx_gpio_set': > arch/powerpc/sysdev/ppc4xx_gpio.c:93:26: error: > unused variable 'mm_gc' [-Werror=unused-variable] > struct of_mm_gpio_chip *mm_gc = to_of_mm_gpio_chip(gc); > ^ > cc1: all warnings being treated as errors > > Reported-by: kbuild test robot <fengguang.wu@intel.com> > Cc: Anatolij Gustschin <agust@denx.de> > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> > Cc: Paul Mackerras <paulus@samba.org> > Cc: Michael Ellerman <mpe@ellerman.id.au> > Cc: linuxppc-dev@lists.ozlabs.org > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > --- > I've applied this to the GPIO tree where the offending > commit is now merged. Thanks. If you feel like cross building powerpc in future it should be as simple as: $ dnf install gcc-powerpc64-linux-gnu || apt-get install gcc-powerpc-linux-gnu $ make ARCH=powerpc CROSS_COMPILE=powerpc-linux-gnu- ... :) cheers -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Mar 31, 2016 at 12:09 PM, Michael Ellerman <mpe@ellerman.id.au> wrote: > If you feel like cross building powerpc in future it should be as simple as: > > $ dnf install gcc-powerpc64-linux-gnu || apt-get install gcc-powerpc-linux-gnu > $ make ARCH=powerpc CROSS_COMPILE=powerpc-linux-gnu- ... Ah hm yeah I guess everyone "should", it's just that these days I mainly rely on Fenguang's kautobuild to do this job for me and get back with the result from a plethora of arches. Sometimes a buggy bit slips through the cracks though, sorry about that. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 2016-03-31 at 14:57 +0200, Linus Walleij wrote: > On Thu, Mar 31, 2016 at 12:09 PM, Michael Ellerman <mpe@ellerman.id.au> wrote: > > > If you feel like cross building powerpc in future it should be as simple as: > > > > $ dnf install gcc-powerpc64-linux-gnu || apt-get install gcc-powerpc-linux-gnu > > $ make ARCH=powerpc CROSS_COMPILE=powerpc-linux-gnu- ... > > Ah hm yeah I guess everyone "should", it's just that these days I > mainly rely on Fenguang's kautobuild to do this job for me and > get back with the result from a plethora of arches. Sure. That makes sense for all the silly little architectures. But for powerpc you should really cross compile. .. :P > Sometimes a buggy bit slips through the cracks though, sorry > about that. No stress. cheers -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Apr 1, 2016 at 4:31 AM, Michael Ellerman <mpe@ellerman.id.au> wrote: > On Thu, 2016-03-31 at 14:57 +0200, Linus Walleij wrote: >> On Thu, Mar 31, 2016 at 12:09 PM, Michael Ellerman <mpe@ellerman.id.au> wrote: >> >> > If you feel like cross building powerpc in future it should be as simple as: >> > >> > $ dnf install gcc-powerpc64-linux-gnu || apt-get install gcc-powerpc-linux-gnu >> > $ make ARCH=powerpc CROSS_COMPILE=powerpc-linux-gnu- ... >> >> Ah hm yeah I guess everyone "should", it's just that these days I >> mainly rely on Fenguang's kautobuild to do this job for me and >> get back with the result from a plethora of arches. > > Sure. That makes sense for all the silly little architectures. > > But for powerpc you should really cross compile. I think kautobuild cross compiles? The only thing that happens IIUC is I let somebody else do the job at the Intel server farm. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/powerpc/sysdev/ppc4xx_gpio.c b/arch/powerpc/sysdev/ppc4xx_gpio.c index 4ab83cd04785..5382d04dd872 100644 --- a/arch/powerpc/sysdev/ppc4xx_gpio.c +++ b/arch/powerpc/sysdev/ppc4xx_gpio.c @@ -90,7 +90,6 @@ __ppc4xx_gpio_set(struct gpio_chip *gc, unsigned int gpio, int val) static void ppc4xx_gpio_set(struct gpio_chip *gc, unsigned int gpio, int val) { - struct of_mm_gpio_chip *mm_gc = to_of_mm_gpio_chip(gc); struct ppc4xx_gpio_chip *chip = gpiochip_get_data(gc); unsigned long flags;
commit 0d36fe65f58391712e11a6621075f373216e5f00 "powerpc: ppc4xx: use gpiochip data pointer" made the mm_gc local variable in ppc4xx_gpio_set() redundant, and when GCC treats warnings as errors this happens: arch/powerpc/sysdev/ppc4xx_gpio.c: In function 'ppc4xx_gpio_set': arch/powerpc/sysdev/ppc4xx_gpio.c:93:26: error: unused variable 'mm_gc' [-Werror=unused-variable] struct of_mm_gpio_chip *mm_gc = to_of_mm_gpio_chip(gc); ^ cc1: all warnings being treated as errors Reported-by: kbuild test robot <fengguang.wu@intel.com> Cc: Anatolij Gustschin <agust@denx.de> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: Paul Mackerras <paulus@samba.org> Cc: Michael Ellerman <mpe@ellerman.id.au> Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- I've applied this to the GPIO tree where the offending commit is now merged. --- arch/powerpc/sysdev/ppc4xx_gpio.c | 1 - 1 file changed, 1 deletion(-)