From patchwork Fri Mar 11 17:06:02 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "qipeng.zha" X-Patchwork-Id: 596103 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id EA2FC1402BC for ; Fri, 11 Mar 2016 20:00:53 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964898AbcCKJAx (ORCPT ); Fri, 11 Mar 2016 04:00:53 -0500 Received: from mga03.intel.com ([134.134.136.65]:63297 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964786AbcCKJAx (ORCPT ); Fri, 11 Mar 2016 04:00:53 -0500 Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP; 11 Mar 2016 01:00:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,320,1455004800"; d="scan'208";a="64159131" Received: from shbuild999.sh.intel.com ([10.239.146.206]) by fmsmga004.fm.intel.com with ESMTP; 11 Mar 2016 01:00:52 -0800 From: Qipeng Zha To: linux-gpio@vger.kernel.org Cc: linus.walleij@linaro.org, mika.westerberg@intel.com, Qi Zheng Subject: [PATCH 3/3] pinctrl:Intel: make the high level interrupt working Date: Sat, 12 Mar 2016 01:06:02 +0800 Message-Id: <1457715962-108484-3-git-send-email-qipeng.zha@intel.com> X-Mailer: git-send-email 1.8.3.2 In-Reply-To: <1457715962-108484-1-git-send-email-qipeng.zha@intel.com> References: <1457715962-108484-1-git-send-email-qipeng.zha@intel.com> Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org High level trigger mode of GPIO interrupt is not set correctly in intel_gpio_irq_type(), and will make this kind of interrupt not respond. Signed-off-by: Qi Zheng Signed-off-by: Qipeng Zha --- drivers/pinctrl/intel/pinctrl-intel.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c index d6fe659..706a21f 100644 --- a/drivers/pinctrl/intel/pinctrl-intel.c +++ b/drivers/pinctrl/intel/pinctrl-intel.c @@ -790,6 +790,8 @@ static int intel_gpio_irq_type(struct irq_data *d, unsigned type) value |= PADCFG0_RXEVCFG_EDGE << PADCFG0_RXEVCFG_SHIFT; } else if (type & IRQ_TYPE_LEVEL_LOW) { value |= PADCFG0_RXINV; + } else if (type & IRQ_TYPE_LEVEL_HIGH) { + ; } else { value |= PADCFG0_RXEVCFG_DISABLED << PADCFG0_RXEVCFG_SHIFT; }