| Message ID | 1456762997-7607-1-git-send-email-marex@denx.de |
|---|---|
| State | New |
| Headers | show |
On 1/03/2016 12:23 AM, Marek Vasut wrote: > The altr,interrupt-trigger property is not used by the driver. > Instead, altr,interrupt-type is used by the driver and the driver > does not probe if this property is not specified. Therefore, it > is expected that there are no users of the -trigger property in > the wild and that this is a typo in the documentation for the > altera-pio controller. This patch fixes the typo. > On a related note. The Altera QSYS 15.0 device tree tools generate this label this as altr,interrupt_type Note: '_' instead of '-'. I've locally patch the driver to look for both names. Not sure if this is something that should be fixed in the driver or require user to to post process the generated dts. I haven't reported the issue to Altera either.
On 03/01/2016 02:22 AM, Phil Reid wrote: > On 1/03/2016 12:23 AM, Marek Vasut wrote: >> The altr,interrupt-trigger property is not used by the driver. >> Instead, altr,interrupt-type is used by the driver and the driver >> does not probe if this property is not specified. Therefore, it >> is expected that there are no users of the -trigger property in >> the wild and that this is a typo in the documentation for the >> altera-pio controller. This patch fixes the typo. >> > > On a related note. The Altera QSYS 15.0 device tree tools generate this > label this as altr,interrupt_type Aaaaaaargh :-( > Note: '_' instead of '-'. > I've locally patch the driver to look for both names. > Not sure if this is something that should be fixed in the driver or > require user to to post process the generated dts. > > I haven't reported the issue to Altera either. It's the tools which should be fixed in this case. Since mainline does not mention this binding with '_' anywhere, it's not part of ABI and I would really go for fixing the tools in this case. Thanks for the report!
Hey Marex, Phil Sorry for the late reply, something went wrong with my open source mail account. Yes the tool needs to be fixed, we're expecting to fix it once socfpga-4.1 LTSi branch is ready to be released. We don't fix it now to keep it compatible with the "old and released" socfpga-3.10-ltsi branch. Thanks On Tue, 2016-03-01 at 02:29 +0100, marex@denx.de wrote: > On 03/01/2016 02:22 AM, Phil Reid wrote: > > On 1/03/2016 12:23 AM, Marek Vasut wrote: > >> The altr,interrupt-trigger property is not used by the driver. > >> Instead, altr,interrupt-type is used by the driver and the driver > >> does not probe if this property is not specified. Therefore, it > >> is expected that there are no users of the -trigger property in > >> the wild and that this is a typo in the documentation for the > >> altera-pio controller. This patch fixes the typo. > >> > > > > On a related note. The Altera QSYS 15.0 device tree tools generate this > > label this as altr,interrupt_type > > Aaaaaaargh :-( > > > Note: '_' instead of '-'. > > I've locally patch the driver to look for both names. > > Not sure if this is something that should be fixed in the driver or > > require user to to post process the generated dts. > > > > I haven't reported the issue to Altera either. > > It's the tools which should be fixed in this case. > > Since mainline does not mention this binding with '_' anywhere, it's not > part of ABI and I would really go for fixing the tools in this case. > > Thanks for the report! -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 03/01/2016 09:17 AM, Tien Hock Loh wrote: > Hey Marek, Phil Hi Tien, > Sorry for the late reply, something went wrong with my open source mail > account. No problem. > Yes the tool needs to be fixed, we're expecting to fix it once > socfpga-4.1 LTSi branch is ready to be released. We don't fix it now to > keep it compatible with the "old and released" socfpga-3.10-ltsi branch. You can patch the old and released branch to support both bindings :) > Thanks > > On Tue, 2016-03-01 at 02:29 +0100, marex@denx.de wrote: >> On 03/01/2016 02:22 AM, Phil Reid wrote: >>> On 1/03/2016 12:23 AM, Marek Vasut wrote: >>>> The altr,interrupt-trigger property is not used by the driver. >>>> Instead, altr,interrupt-type is used by the driver and the driver >>>> does not probe if this property is not specified. Therefore, it >>>> is expected that there are no users of the -trigger property in >>>> the wild and that this is a typo in the documentation for the >>>> altera-pio controller. This patch fixes the typo. >>>> >>> >>> On a related note. The Altera QSYS 15.0 device tree tools generate this >>> label this as altr,interrupt_type >> >> Aaaaaaargh :-( >> >>> Note: '_' instead of '-'. >>> I've locally patch the driver to look for both names. >>> Not sure if this is something that should be fixed in the driver or >>> require user to to post process the generated dts. >>> >>> I haven't reported the issue to Altera either. >> >> It's the tools which should be fixed in this case. >> >> Since mainline does not mention this binding with '_' anywhere, it's not >> part of ABI and I would really go for fixing the tools in this case. >> >> Thanks for the report! >
On Mon, Feb 29, 2016 at 11:23 PM, Marek Vasut <marex@denx.de> wrote: > The altr,interrupt-trigger property is not used by the driver. > Instead, altr,interrupt-type is used by the driver and the driver > does not probe if this property is not specified. Therefore, it > is expected that there are no users of the -trigger property in > the wild and that this is a typo in the documentation for the > altera-pio controller. This patch fixes the typo. > > Signed-off-by: Marek Vasut <marex@denx.de> > Cc: Tien Hock Loh <thloh@altera.com> > Cc: Linus Walleij <linus.walleij@linaro.org> Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/gpio/gpio-altera.txt b/Documentation/devicetree/bindings/gpio/gpio-altera.txt index 12f5014..826a720 100644 --- a/Documentation/devicetree/bindings/gpio/gpio-altera.txt +++ b/Documentation/devicetree/bindings/gpio/gpio-altera.txt @@ -12,7 +12,7 @@ Required properties: - #interrupt-cells : Should be 1. The interrupt type is fixed in the hardware. - The first cell is the GPIO offset number within the GPIO controller. - interrupts: Specify the interrupt. -- altr,interrupt-trigger: Specifies the interrupt trigger type the GPIO +- altr,interrupt-type: Specifies the interrupt trigger type the GPIO hardware is synthesized. This field is required if the Altera GPIO controller used has IRQ enabled as the interrupt type is not software controlled, but hardware synthesized. Required if GPIO is used as an interrupt @@ -35,7 +35,7 @@ gpio_altr: gpio@0xff200000 { reg = <0xff200000 0x10>; interrupts = <0 45 4>; altr,ngpio = <32>; - altr,interrupt-trigger = <IRQ_TYPE_EDGE_RISING>; + altr,interrupt-type = <IRQ_TYPE_EDGE_RISING>; #gpio-cells = <2>; gpio-controller; #interrupt-cells = <1>;
The altr,interrupt-trigger property is not used by the driver. Instead, altr,interrupt-type is used by the driver and the driver does not probe if this property is not specified. Therefore, it is expected that there are no users of the -trigger property in the wild and that this is a typo in the documentation for the altera-pio controller. This patch fixes the typo. Signed-off-by: Marek Vasut <marex@denx.de> Cc: Tien Hock Loh <thloh@altera.com> Cc: Linus Walleij <linus.walleij@linaro.org> --- Documentation/devicetree/bindings/gpio/gpio-altera.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)