From patchwork Wed Feb 24 13:31:14 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Axel Lin X-Patchwork-Id: 587379 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id CF77914032F for ; Thu, 25 Feb 2016 00:31:46 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ingics-com.20150623.gappssmtp.com header.i=@ingics-com.20150623.gappssmtp.com header.b=Xn/uiEY8; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932614AbcBXNb1 (ORCPT ); Wed, 24 Feb 2016 08:31:27 -0500 Received: from mail-pa0-f41.google.com ([209.85.220.41]:34550 "EHLO mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932528AbcBXNbT (ORCPT ); Wed, 24 Feb 2016 08:31:19 -0500 Received: by mail-pa0-f41.google.com with SMTP id fy10so12829881pac.1 for ; Wed, 24 Feb 2016 05:31:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ingics-com.20150623.gappssmtp.com; s=20150623; h=message-id:subject:from:to:cc:date:content-type:mime-version :content-transfer-encoding; bh=dK/vfC9Omo4eTDy0zDV1VxsIScG2CBRJ0FlkMzeJOe8=; b=Xn/uiEY8OblSUHbqkkHrpbCGQ+XPfMxPWCzoEVg4HaK5A6jXPkN7Gr+cEJ18FT8H9q E/Cmg4WapVDBD8yoeFpiY8eBmKYCLz7TX9t5G+zytzTHK5CBtEPXaaC7/Sf5LK0Qqq4I kcxVZgBjoKLlMYvD2mX4vxSMt+DW8viNW0IBFLcYjZjfRvXtRlSrUcQ0wCcNUPTod1Dj /neFIBfwxLCScs28W5/2JbcyDcjJypiO8bVRNNyuN1f+bqPqvjx7IDxntfnCe4XXzZKR OIvR2noJ6d7hjUoo/raX9iW2kP2U+Tb5JczFY9G/KUKWTMFJvtB6ZyQsU7D9cWmqoEoA 4zng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:subject:from:to:cc:date:content-type :mime-version:content-transfer-encoding; bh=dK/vfC9Omo4eTDy0zDV1VxsIScG2CBRJ0FlkMzeJOe8=; b=lf1mZXtmDYpf7LYf270Z/+JVQaY39q6ssPsDYuwPPxHu1IZwfvWYaN+7xq+habjxgu VSyCL8KjTa2QKUXvoij+UVqHe1fmjslEYf0xcLFLv3xm/oec5oFO+gBMr7Hzmzjx4Jbh ODIuCRUxMjn7pu+H7kqjzmcAaOoPoXWiQpkEU/vLetLabaEcGRLoCTCSim1MlIVeTjpR fmJMFCZm6qtUyknqR+vZw6qdqlu0+X760awbg/QphfubD97RhppY2jRFT0EqXaxWlcvu lCiw4SUFjebIhe/iypTSh1lbbYbV6cunr4Aax0fzqhBsW1TAzzsYDNX/v0RR5LXguaMI oEGA== X-Gm-Message-State: AG10YOQDaSn+sPpuMrngZaUv6PZLeq4eUSzoHcxvOjzgD3nlMfMZI+pgu3zTB5kmsA1OFA== X-Received: by 10.66.155.232 with SMTP id vz8mr54653232pab.53.1456320678717; Wed, 24 Feb 2016 05:31:18 -0800 (PST) Received: from phoenix (36-239-224-75.dynamic-ip.hinet.net. [36.239.224.75]) by smtp.gmail.com with ESMTPSA id 82sm5229278pfn.89.2016.02.24.05.31.16 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 24 Feb 2016 05:31:17 -0800 (PST) Message-ID: <1456320674.8959.1.camel@ingics.com> Subject: [PATCH RFT] gpio: pisosr: Use gpiod_set_value_cansleep in pisosr_gpio_refresh() From: Axel Lin To: Linus Walleij Cc: "Andrew F. Davis" , Alexandre Courbot , linux-gpio@vger.kernel.org Date: Wed, 24 Feb 2016 21:31:14 +0800 X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org This driver has .can_sleep flag set. So the pisosr_gpio_get() can be called from contexts that can sleep. Thus use the cansleep() variant in pisosr_gpio_refresh(). Signed-off-by: Axel Lin --- drivers/gpio/gpio-pisosr.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpio-pisosr.c b/drivers/gpio/gpio-pisosr.c index f9f1074..597cec6 100644 --- a/drivers/gpio/gpio-pisosr.c +++ b/drivers/gpio/gpio-pisosr.c @@ -46,9 +46,9 @@ static int pisosr_gpio_refresh(struct pisosr_gpio *gpio) mutex_lock(&gpio->lock); if (gpio->load_gpio) { - gpiod_set_value(gpio->load_gpio, 1); + gpiod_set_value_cansleep(gpio->load_gpio, 1); udelay(1); /* registers load time (~10ns) */ - gpiod_set_value(gpio->load_gpio, 0); + gpiod_set_value_cansleep(gpio->load_gpio, 0); udelay(1); /* registers recovery time (~5ns) */ }