diff mbox

[3/3] mfd: lpc_ich: add GPIO support for Baytrail

Message ID 1453566729-30220-4-git-send-email-antoine.tenart@free-electrons.com
State New
Headers show

Commit Message

Antoine Tenart Jan. 23, 2016, 4:32 p.m. UTC
This patch adds the GPIO support for the Baytrail family.

Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
---
 drivers/mfd/lpc_ich.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Lee Jones Jan. 25, 2016, 12:45 p.m. UTC | #1
On Sat, 23 Jan 2016, Antoine Tenart wrote:

> This patch adds the GPIO support for the Baytrail family.
> 
> Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
> ---
>  drivers/mfd/lpc_ich.c | 1 +
>  1 file changed, 1 insertion(+)

I can't take this yet, as it has a dependency on the GPIO patch.

For my own reference:
  Acked-by: Lee Jones <lee.jones@linaro.org>

> diff --git a/drivers/mfd/lpc_ich.c b/drivers/mfd/lpc_ich.c
> index f13a5ded3958..d86b496874df 100644
> --- a/drivers/mfd/lpc_ich.c
> +++ b/drivers/mfd/lpc_ich.c
> @@ -508,6 +508,7 @@ static struct lpc_ich_info lpc_chipset_info[] = {
>  	[LPC_BAYTRAIL] = {
>  		.name = "Bay Trail SoC",
>  		.iTCO_version = 3,
> +		.gpio_version = ICH_BAYTRAIL_GPIO,
>  	},
>  	[LPC_COLETO] = {
>  		.name = "Coleto Creek",
Linus Walleij Jan. 28, 2016, 10:34 a.m. UTC | #2
On Sat, Jan 23, 2016 at 5:32 PM, Antoine Tenart
<antoine.tenart@free-electrons.com> wrote:

> This patch adds the GPIO support for the Baytrail family.
>
> Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>

I'm confused by this and Mika's comment on patch 0.

Is the BayTrail an ICH variant or not? Or does it have
two GPIO controllers? Or um ....

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
mika.westerberg@linux.intel.com Jan. 28, 2016, 3:48 p.m. UTC | #3
On Thu, Jan 28, 2016 at 11:34:40AM +0100, Linus Walleij wrote:
> On Sat, Jan 23, 2016 at 5:32 PM, Antoine Tenart
> <antoine.tenart@free-electrons.com> wrote:
> 
> > This patch adds the GPIO support for the Baytrail family.
> >
> > Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com>
> 
> I'm confused by this and Mika's comment on patch 0.
> 
> Is the BayTrail an ICH variant or not? Or does it have
> two GPIO controllers? Or um ....

It is not compatible with ICH and there is only one GPIO controller in
the SoC.
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/mfd/lpc_ich.c b/drivers/mfd/lpc_ich.c
index f13a5ded3958..d86b496874df 100644
--- a/drivers/mfd/lpc_ich.c
+++ b/drivers/mfd/lpc_ich.c
@@ -508,6 +508,7 @@  static struct lpc_ich_info lpc_chipset_info[] = {
 	[LPC_BAYTRAIL] = {
 		.name = "Bay Trail SoC",
 		.iTCO_version = 3,
+		.gpio_version = ICH_BAYTRAIL_GPIO,
 	},
 	[LPC_COLETO] = {
 		.name = "Coleto Creek",