From patchwork Tue Dec 8 15:01:07 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Axel Lin X-Patchwork-Id: 553935 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 632311402D2 for ; Wed, 9 Dec 2015 02:01:22 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ingics-com.20150623.gappssmtp.com header.i=@ingics-com.20150623.gappssmtp.com header.b=Xn5BWmKX; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965096AbbLHPBQ (ORCPT ); Tue, 8 Dec 2015 10:01:16 -0500 Received: from mail-pa0-f47.google.com ([209.85.220.47]:35171 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965072AbbLHPBN (ORCPT ); Tue, 8 Dec 2015 10:01:13 -0500 Received: by pacej9 with SMTP id ej9so13290959pac.2 for ; Tue, 08 Dec 2015 07:01:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ingics-com.20150623.gappssmtp.com; s=20150623; h=message-id:subject:from:to:cc:date:content-type:mime-version :content-transfer-encoding; bh=hOTwAgTez+P+9cljTyfBfGOXTuDzjOj+ClzHEASHjgE=; b=Xn5BWmKXo4YfY5k+wypc7ac83OjiUzQqr59b/bRW05EXgQysd3/Zi2EpXsGw7pcz7h TQb6gNYMil6e9J4YzJKX2A6JWVAcnhnKkbfarq8adwtGKztKzmKai/UPeduPaTqZcdT/ 2DSsPnCakifTCXS3zp/stjc4I+npcy0NvN8JMWhCaodUEBTEyN+OFq6b5imeYQXz9YMI dSMlt2jf1+VLuSPFEDTAVKrEWq4cX28RjiZ2BkzkucpBeNBG3D+/tSpXb9PwnkVEhBy7 UOf9xbVFLJYLKDeixuIeWDLGn/fWT4bdXdRjlHkQbb6rPIUUeioaB+q5Oe9x5xepslyE 6I0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:subject:from:to:cc:date:content-type :mime-version:content-transfer-encoding; bh=hOTwAgTez+P+9cljTyfBfGOXTuDzjOj+ClzHEASHjgE=; b=ZwyBIYRTesQafISvvuH4Q64PRGKtcBJAbY0Ynt6lAW13NSkV7is0BaMXExLIPZCka5 X43GwGrCfDd7iLK3qpBIwFEAYY4DA/p1rZmfZTWuZRwmSjrpBCpjJgjtXpQTqYolC/W3 h8QFv6VXljJwTatLSqqZVA/LcslwCWNef+5pkM6MNpcLCPHLO5GIfpHoI/OuvltqfTSR xsYqyvAcejmBQkhUOvlrgitBQestndbwlue1cTE7vm4AJ90AmcQI/muvph088BadgkNq hSpHkko85hQKXf6CfW8kKR1t4L0cT7UnX9J8Tr+woZfBoTaXKxSGMacIGtKseILLkyH0 tJwQ== X-Gm-Message-State: ALoCoQnhu2bsWFSfz12XW6/GqBFvB6lQfLgWEubKvETLIGkC2rgRVMwXw3ZFVuXQ98pjTWMcMuGy+spG6MkeQJbJ8YyB1f8fCA== X-Received: by 10.66.119.237 with SMTP id kx13mr447890pab.158.1449586872360; Tue, 08 Dec 2015 07:01:12 -0800 (PST) Received: from phoenix ([60.245.65.112]) by smtp.gmail.com with ESMTPSA id mj1sm5482543pab.34.2015.12.08.07.01.09 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 08 Dec 2015 07:01:10 -0800 (PST) Message-ID: <1449586867.5555.1.camel@ingics.com> Subject: [PATCH RFT] gpio: ath79: Fix the logic to clear offset bit of AR71XX_GPIO_REG_OE register From: Axel Lin To: Linus Walleij , Alexandre Courbot Cc: Alban Bedel , linux-gpio@vger.kernel.org Date: Tue, 08 Dec 2015 23:01:07 +0800 X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Signed-off-by: Axel Lin Acked-by: Alban Bedel --- drivers/gpio/gpio-ath79.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-ath79.c b/drivers/gpio/gpio-ath79.c index e5827a5..5eaea8b 100644 --- a/drivers/gpio/gpio-ath79.c +++ b/drivers/gpio/gpio-ath79.c @@ -113,7 +113,7 @@ static int ar934x_gpio_direction_output(struct gpio_chip *chip, unsigned offset, __raw_writel(BIT(offset), ctrl->base + AR71XX_GPIO_REG_CLEAR); __raw_writel( - __raw_readl(ctrl->base + AR71XX_GPIO_REG_OE) & BIT(offset), + __raw_readl(ctrl->base + AR71XX_GPIO_REG_OE) & ~BIT(offset), ctrl->base + AR71XX_GPIO_REG_OE); spin_unlock_irqrestore(&ctrl->lock, flags);