From patchwork Wed Dec 2 16:19:55 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thierry Reding X-Patchwork-Id: 551446 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 8D4AC14031B for ; Thu, 3 Dec 2015 03:20:17 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=fp93SLhe; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758863AbbLBQUA (ORCPT ); Wed, 2 Dec 2015 11:20:00 -0500 Received: from mail-wm0-f43.google.com ([74.125.82.43]:33434 "EHLO mail-wm0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750973AbbLBQT6 (ORCPT ); Wed, 2 Dec 2015 11:19:58 -0500 Received: by wmec201 with SMTP id c201so261227773wme.0; Wed, 02 Dec 2015 08:19:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=+nGccLi/r9zyM0F/EYo03KFRti0S+dfO+NOD0/oqggI=; b=fp93SLhe23dGWZStZr4kwQPAUOttcUexQn/hXNrbTqZs48snmd32h7rLNL4iAOK5N3 +X+fC1EPYWNndzCWS/gBgo3aVwWZK0Z8ymeXhj1UjxIA5jvt6t7ow7akEW4tnPYG9XVc H3Q9EKVBxPUHunT0DCg+AJ5U9DyjYScFYrpmholxmpPx0QEOszu73P0aQ7hXjsCF4zHo kdn1ZcpkipZA9xvsFLwwle9Ifq2EQRQOYJcEQkyqr3nMm58lroW73KQ/AhIyHnkDhTUq VqmUIZAvv2S9agArEc8xC0HB6pk5OOqDOU/5/OXTAn5aePtc1JaMWzP4gAM++/BjERmF J7BA== X-Received: by 10.194.117.228 with SMTP id kh4mr5616525wjb.171.1449073197039; Wed, 02 Dec 2015 08:19:57 -0800 (PST) Received: from localhost (port-973.pppoe.wtnet.de. [84.46.3.208]) by smtp.gmail.com with ESMTPSA id u205sm3855264wmb.12.2015.12.02.08.19.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 02 Dec 2015 08:19:56 -0800 (PST) From: Thierry Reding To: Linus Walleij , Alexandre Courbot Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] gpio: mpc5200: Use platform_register/unregister_drivers() Date: Wed, 2 Dec 2015 17:19:55 +0100 Message-Id: <1449073195-11054-1-git-send-email-thierry.reding@gmail.com> X-Mailer: git-send-email 2.5.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org From: Thierry Reding These new helpers simplify implementing multi-driver modules and properly handle failure to register one driver by unregistering all previously registered drivers. Signed-off-by: Thierry Reding --- drivers/gpio/gpio-mpc5200.c | 17 +++++++---------- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/drivers/gpio/gpio-mpc5200.c b/drivers/gpio/gpio-mpc5200.c index 4c542153e923..044bbbb747f2 100644 --- a/drivers/gpio/gpio-mpc5200.c +++ b/drivers/gpio/gpio-mpc5200.c @@ -360,15 +360,14 @@ static struct platform_driver mpc52xx_simple_gpiochip_driver = { .remove = mpc52xx_gpiochip_remove, }; +static struct platform_driver * const drivers[] = { + &mpc52xx_wkup_gpiochip_driver, + &mpc52xx_simple_gpiochip_driver, +}; + static int __init mpc52xx_gpio_init(void) { - if (platform_driver_register(&mpc52xx_wkup_gpiochip_driver)) - printk(KERN_ERR "Unable to register wakeup GPIO driver\n"); - - if (platform_driver_register(&mpc52xx_simple_gpiochip_driver)) - printk(KERN_ERR "Unable to register simple GPIO driver\n"); - - return 0; + return platform_register_drivers(drivers, ARRAY_SIZE(drivers)); } /* Make sure we get initialised before anyone else tries to use us */ @@ -376,9 +375,7 @@ subsys_initcall(mpc52xx_gpio_init); static void __exit mpc52xx_gpio_exit(void) { - platform_driver_unregister(&mpc52xx_wkup_gpiochip_driver); - - platform_driver_unregister(&mpc52xx_simple_gpiochip_driver); + platform_unregister_drivers(drivers, ARRAY_SIZE(drivers)); } module_exit(mpc52xx_gpio_exit);