diff mbox

[1/3] pinctrl: berlin: guard sub-directory with CONFIG_PINCTRL_BERLIN

Message ID 1448365524-12605-2-git-send-email-yamada.masahiro@socionext.com
State New
Headers show

Commit Message

Masahiro Yamada Nov. 24, 2015, 11:45 a.m. UTC
CONFIG_PINCTRL_BERLIN is more suitable than CONFIG_ARCH_BERLIN
to guard the drivers/pinctrl/berlin/ directory.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 drivers/pinctrl/Makefile        | 2 +-
 drivers/pinctrl/berlin/Makefile | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Jisheng Zhang Nov. 24, 2015, 12:02 p.m. UTC | #1
On Tue, 24 Nov 2015 20:45:22 +0900
Masahiro Yamada wrote:

> CONFIG_PINCTRL_BERLIN is more suitable than CONFIG_ARCH_BERLIN
> to guard the drivers/pinctrl/berlin/ directory.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

I'm not maintainers, but this patch looks good to me. So if you need, 

Acked-by: Jisheng Zhang <jszhang@marvell.com>

> ---
> 
>  drivers/pinctrl/Makefile        | 2 +-
>  drivers/pinctrl/berlin/Makefile | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/pinctrl/Makefile b/drivers/pinctrl/Makefile
> index 738cb49..17c0206 100644
> --- a/drivers/pinctrl/Makefile
> +++ b/drivers/pinctrl/Makefile
> @@ -41,7 +41,7 @@ obj-$(CONFIG_PINCTRL_ST) 	+= pinctrl-st.o
>  obj-$(CONFIG_PINCTRL_ZYNQ)	+= pinctrl-zynq.o
>  
>  obj-$(CONFIG_ARCH_BCM)		+= bcm/
> -obj-$(CONFIG_ARCH_BERLIN)	+= berlin/
> +obj-$(CONFIG_PINCTRL_BERLIN)	+= berlin/
>  obj-y				+= freescale/
>  obj-$(CONFIG_X86)		+= intel/
>  obj-$(CONFIG_PLAT_ORION)        += mvebu/
> diff --git a/drivers/pinctrl/berlin/Makefile b/drivers/pinctrl/berlin/Makefile
> index 06f9402..6f641ce 100644
> --- a/drivers/pinctrl/berlin/Makefile
> +++ b/drivers/pinctrl/berlin/Makefile
> @@ -1,4 +1,4 @@
> -obj-$(CONFIG_PINCTRL_BERLIN)		+= berlin.o
> +obj-y					+= berlin.o
>  obj-$(CONFIG_PINCTRL_BERLIN_BG2)	+= berlin-bg2.o
>  obj-$(CONFIG_PINCTRL_BERLIN_BG2CD)	+= berlin-bg2cd.o
>  obj-$(CONFIG_PINCTRL_BERLIN_BG2Q)	+= berlin-bg2q.o

--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sebastian Hesselbarth Nov. 28, 2015, 11:22 a.m. UTC | #2
On 24.11.2015 13:02, Jisheng Zhang wrote:
> On Tue, 24 Nov 2015 20:45:22 +0900
> Masahiro Yamada wrote:
> 
>> CONFIG_PINCTRL_BERLIN is more suitable than CONFIG_ARCH_BERLIN
>> to guard the drivers/pinctrl/berlin/ directory.
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> 
> I'm not maintainers, but this patch looks good to me. So if you need, 
> 
> Acked-by: Jisheng Zhang <jszhang@marvell.com>

And here comes the maintainer's

Acked-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>

Thanks!

>> ---
>>
>>  drivers/pinctrl/Makefile        | 2 +-
>>  drivers/pinctrl/berlin/Makefile | 2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/pinctrl/Makefile b/drivers/pinctrl/Makefile
>> index 738cb49..17c0206 100644
>> --- a/drivers/pinctrl/Makefile
>> +++ b/drivers/pinctrl/Makefile
>> @@ -41,7 +41,7 @@ obj-$(CONFIG_PINCTRL_ST) 	+= pinctrl-st.o
>>  obj-$(CONFIG_PINCTRL_ZYNQ)	+= pinctrl-zynq.o
>>  
>>  obj-$(CONFIG_ARCH_BCM)		+= bcm/
>> -obj-$(CONFIG_ARCH_BERLIN)	+= berlin/
>> +obj-$(CONFIG_PINCTRL_BERLIN)	+= berlin/
>>  obj-y				+= freescale/
>>  obj-$(CONFIG_X86)		+= intel/
>>  obj-$(CONFIG_PLAT_ORION)        += mvebu/
>> diff --git a/drivers/pinctrl/berlin/Makefile b/drivers/pinctrl/berlin/Makefile
>> index 06f9402..6f641ce 100644
>> --- a/drivers/pinctrl/berlin/Makefile
>> +++ b/drivers/pinctrl/berlin/Makefile
>> @@ -1,4 +1,4 @@
>> -obj-$(CONFIG_PINCTRL_BERLIN)		+= berlin.o
>> +obj-y					+= berlin.o
>>  obj-$(CONFIG_PINCTRL_BERLIN_BG2)	+= berlin-bg2.o
>>  obj-$(CONFIG_PINCTRL_BERLIN_BG2CD)	+= berlin-bg2cd.o
>>  obj-$(CONFIG_PINCTRL_BERLIN_BG2Q)	+= berlin-bg2q.o
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Linus Walleij Dec. 1, 2015, 9:40 a.m. UTC | #3
On Tue, Nov 24, 2015 at 12:45 PM, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:

> CONFIG_PINCTRL_BERLIN is more suitable than CONFIG_ARCH_BERLIN
> to guard the drivers/pinctrl/berlin/ directory.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Patch applied with the ACKs.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/pinctrl/Makefile b/drivers/pinctrl/Makefile
index 738cb49..17c0206 100644
--- a/drivers/pinctrl/Makefile
+++ b/drivers/pinctrl/Makefile
@@ -41,7 +41,7 @@  obj-$(CONFIG_PINCTRL_ST) 	+= pinctrl-st.o
 obj-$(CONFIG_PINCTRL_ZYNQ)	+= pinctrl-zynq.o
 
 obj-$(CONFIG_ARCH_BCM)		+= bcm/
-obj-$(CONFIG_ARCH_BERLIN)	+= berlin/
+obj-$(CONFIG_PINCTRL_BERLIN)	+= berlin/
 obj-y				+= freescale/
 obj-$(CONFIG_X86)		+= intel/
 obj-$(CONFIG_PLAT_ORION)        += mvebu/
diff --git a/drivers/pinctrl/berlin/Makefile b/drivers/pinctrl/berlin/Makefile
index 06f9402..6f641ce 100644
--- a/drivers/pinctrl/berlin/Makefile
+++ b/drivers/pinctrl/berlin/Makefile
@@ -1,4 +1,4 @@ 
-obj-$(CONFIG_PINCTRL_BERLIN)		+= berlin.o
+obj-y					+= berlin.o
 obj-$(CONFIG_PINCTRL_BERLIN_BG2)	+= berlin-bg2.o
 obj-$(CONFIG_PINCTRL_BERLIN_BG2CD)	+= berlin-bg2cd.o
 obj-$(CONFIG_PINCTRL_BERLIN_BG2Q)	+= berlin-bg2q.o