From patchwork Tue Nov 17 02:34:50 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hongzhou Yang X-Patchwork-Id: 545318 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 74EF6141448 for ; Tue, 17 Nov 2015 13:35:05 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751498AbbKQCfE (ORCPT ); Mon, 16 Nov 2015 21:35:04 -0500 Received: from mailgw01.mediatek.com ([210.61.82.183]:60403 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751421AbbKQCfD (ORCPT ); Mon, 16 Nov 2015 21:35:03 -0500 X-Listener-Flag: 11101 Received: from mtkhts09.mediatek.inc [(172.21.101.70)] by mailgw01.mediatek.com (envelope-from ) (mhqrelay.mediatek.com ESMTP with TLS) with ESMTP id 1996466906; Tue, 17 Nov 2015 10:34:58 +0800 Received: from mussux00.eus.mediatek.inc (172.29.97.100) by mtkhts09.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 14.3.181.6; Tue, 17 Nov 2015 10:34:56 +0800 From: Hongzhou Yang To: Linus Walleij , Matthias Brugger CC: Hongzhou Yang , Yingjoe Chen , Axel Lin , Maoguang Meng , Colin Ian King , , , , , , Sascha Hauer , Subject: [PATCH] pinctrl: mediatek: fix a memleak when do dt maps. Date: Mon, 16 Nov 2015 18:34:50 -0800 Message-ID: <1447727690-15251-1-git-send-email-hongzhou.yang@mediatek.com> X-Mailer: git-send-email 1.7.9.5 MIME-Version: 1.0 X-MTK: N Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org configs will kmemdup to dup_configs in pictrl util function. So configs need to be freed. Signed-off-by: Hongzhou Yang --- Fix a memleak issue. drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c index bbf0230..0000b5a 100644 --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c @@ -568,9 +568,10 @@ static int mtk_pctrl_dt_subnode_to_map(struct pinctrl_dev *pctldev, } } - return 0; + err = 0; fail: + kfree(configs); return err; }