From patchwork Wed Aug 5 14:37:41 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Axel Lin X-Patchwork-Id: 504033 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id D7AAF1402B9 for ; Thu, 6 Aug 2015 00:37:49 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752101AbbHEOhs (ORCPT ); Wed, 5 Aug 2015 10:37:48 -0400 Received: from mail-pa0-f43.google.com ([209.85.220.43]:33481 "EHLO mail-pa0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752007AbbHEOhs (ORCPT ); Wed, 5 Aug 2015 10:37:48 -0400 Received: by pabyb7 with SMTP id yb7so5783634pab.0 for ; Wed, 05 Aug 2015 07:37:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:subject:from:to:cc:date:content-type :mime-version:content-transfer-encoding; bh=LZqcZ3ZeVIiqPLHdEGg9JI26V07UG66llgl+u4zPvTg=; b=OEWeQWSsf8j8vfYQPp4inv93HlgCR4zvh2SemfqPfKLryrZtyoR60JYsNOrHshj5wf ya/KapF3pXkOIaGRQofMXfzsWUQiIbZPVe5CI0zrzm/N1D+xKC4JWchILrKpdkXMxo06 OvW4jY/OnbQU+hs+/6Cn5PEx3vNghMg7GLFIQT24G0Z9mpokODGi+btXWHj8F/hOw6Ns X4z74UQQw5i86kWs2+pND08FxEdIYJwsiKS94zdw3frJ+5Zlgf9AYat/VZbiaVCg2kto JMirdLbgqq25JDgj4ZNTO8RfM3qw533kXs4l9EOFUVoKUAz50lKGbne18wvpvU5Nv95X Ka7Q== X-Gm-Message-State: ALoCoQn44nybg2EZqeBfNheutLJBFBH3dCbUcSWqKzpG3Z0KcnwQtZhWs5AxtFgeIFriPHKKfCyU X-Received: by 10.67.5.2 with SMTP id ci2mr19839726pad.97.1438785467459; Wed, 05 Aug 2015 07:37:47 -0700 (PDT) Received: from phoenix.local ([60.245.65.112]) by smtp.gmail.com with ESMTPSA id rt6sm3138378pbb.62.2015.08.05.07.37.44 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 05 Aug 2015 07:37:46 -0700 (PDT) Message-ID: <1438785461.9624.1.camel@ingics.com> Subject: [PATCH] gpio: omap: Fix missing raw locks conversion From: Axel Lin To: Linus Walleij Cc: Sebastian Andrzej Siewior , Javier Martinez Canillas , Santosh Shilimkar , Kevin Hilman , Alexandre Courbot , linux-omap@vger.kernel.org, linux-gpio@vger.kernel.org Date: Wed, 05 Aug 2015 22:37:41 +0800 X-Mailer: Evolution 3.12.10-0ubuntu1~14.10.1 Mime-Version: 1.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Fix below build warning: CC drivers/gpio/gpio-omap.o drivers/gpio/gpio-omap.c: In function 'omap_gpio_irq_type': drivers/gpio/gpio-omap.c:504:3: warning: passing argument 1 of 'spin_unlock_irqrestore' from incompatible pointer type [enabled by default] include/linux/spinlock.h:360:29: note: expected 'struct spinlock_t *' but argument is of type 'struct raw_spinlock_t *' Fixes: commit 4dbada2be460 ("gpio: omap: use raw locks for locking") Signed-off-by: Axel Lin --- drivers/gpio/gpio-omap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-omap.c b/drivers/gpio/gpio-omap.c index dba67b2..466fe70 100644 --- a/drivers/gpio/gpio-omap.c +++ b/drivers/gpio/gpio-omap.c @@ -501,7 +501,7 @@ static int omap_gpio_irq_type(struct irq_data *d, unsigned type) raw_spin_lock_irqsave(&bank->lock, flags); retval = omap_set_gpio_triggering(bank, offset, type); if (retval) { - spin_unlock_irqrestore(&bank->lock, flags); + raw_spin_unlock_irqrestore(&bank->lock, flags); goto error; } omap_gpio_init_irq(bank, offset);