diff mbox

[1/3] gpio: etraxfs: fix set register flag

Message ID 1437570319-25297-1-git-send-email-rabin@rab.in
State New
Headers show

Commit Message

Rabin Vincent July 22, 2015, 1:05 p.m. UTC 
BGPIO_F_UNREADABLE_REG_SET is incorrect, since the set register _is_
readable.  What's really required is BGPIO_F_READ_OUTPUT_REG_SET:
reading the set register reads the set output value.

Signed-off-by: Rabin Vincent <rabin@rab.in>
---
 drivers/gpio/gpio-etraxfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Linus Walleij July 27, 2015, 12:59 p.m. UTC | #1 
On Wed, Jul 22, 2015 at 3:05 PM, Rabin Vincent <rabin@rab.in> wrote:

> BGPIO_F_UNREADABLE_REG_SET is incorrect, since the set register _is_
> readable.  What's really required is BGPIO_F_READ_OUTPUT_REG_SET:
> reading the set register reads the set output value.
>
> Signed-off-by: Rabin Vincent <rabin@rab.in>

Patch applied.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/gpio/gpio-etraxfs.c b/drivers/gpio/gpio-etraxfs.c
index 28071f4..c1ce80d 100644
--- a/drivers/gpio/gpio-etraxfs.c
+++ b/drivers/gpio/gpio-etraxfs.c
@@ -140,7 +140,7 @@  static int etraxfs_gpio_probe(struct platform_device *pdev)
 				 NULL,			/* clr */
 				 regs + port->oe,	/* dirout */
 				 NULL,			/* dirin */
-				 BGPIOF_UNREADABLE_REG_SET);
+				 BGPIOF_READ_OUTPUT_REG_SET);
 		if (ret)
 			return ret;