diff mbox

gpio: remove unneeded initializer in gpiochip_add_to_list()

Message ID 1437457540-1778-1-git-send-email-yamada.masahiro@socionext.com
State New
Headers show

Commit Message

Masahiro Yamada July 21, 2015, 5:45 a.m. UTC
This variable is used as an iterator and initialized in the
list_for_each() loop.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 drivers/gpio/gpiolib.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Alexandre Courbot July 21, 2015, 5:50 a.m. UTC | #1
On Tue, Jul 21, 2015 at 2:45 PM, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:
> This variable is used as an iterator and initialized in the
> list_for_each() loop.
>

Looks good, thanks!

Reviewed-by: Alexandre Courbot <acourbot@nvidia.com>

> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
>  drivers/gpio/gpiolib.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index bf4bd1d..adb03c6 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -190,7 +190,7 @@ EXPORT_SYMBOL_GPL(gpiod_get_direction);
>   */
>  static int gpiochip_add_to_list(struct gpio_chip *chip)
>  {
> -       struct list_head *pos = &gpio_chips;
> +       struct list_head *pos;
>         struct gpio_chip *_chip;
>         int err = 0;
>
> --
> 1.9.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Linus Walleij July 27, 2015, 12:40 p.m. UTC | #2
On Tue, Jul 21, 2015 at 7:45 AM, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:

> This variable is used as an iterator and initialized in the
> list_for_each() loop.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Patch applied with Alex' review tag.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index bf4bd1d..adb03c6 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -190,7 +190,7 @@  EXPORT_SYMBOL_GPL(gpiod_get_direction);
  */
 static int gpiochip_add_to_list(struct gpio_chip *chip)
 {
-	struct list_head *pos = &gpio_chips;
+	struct list_head *pos;
 	struct gpio_chip *_chip;
 	int err = 0;