Message ID | 1435253451-19817-1-git-send-email-grygorii.strashko@ti.com |
---|---|
State | New |
Headers | show |
On Fri, Jun 26, 2015 at 2:30 AM, Grygorii Strashko <grygorii.strashko@ti.com> wrote: > Now nothing prevents GPIO driver from being unloaded if its gpios > were requested as GPIO IRQs only (without calling gpio_request()). > > Hence, add calls of try_module_get()/module_put() into > gpiochip_irq_reqres/relres() to track such scenario properly. Bad things could happen indeed. Reviewed-by: Alexandre Courbot <acourbot@nvidia.com> > > Cc: Johan Hovold <johan@kernel.org> > Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> > --- > drivers/gpio/gpiolib.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c > index be42ab3..9b1d247 100644 > --- a/drivers/gpio/gpiolib.c > +++ b/drivers/gpio/gpiolib.c > @@ -522,10 +522,14 @@ static int gpiochip_irq_reqres(struct irq_data *d) > { > struct gpio_chip *chip = irq_data_get_irq_chip_data(d); > > + if (!try_module_get(chip->owner)) > + return -ENODEV; > + > if (gpiochip_lock_as_irq(chip, d->hwirq)) { > chip_err(chip, > "unable to lock HW IRQ %lu for IRQ\n", > d->hwirq); > + module_put(chip->owner); > return -EINVAL; > } > return 0; > @@ -536,6 +540,7 @@ static void gpiochip_irq_relres(struct irq_data *d) > struct gpio_chip *chip = irq_data_get_irq_chip_data(d); > > gpiochip_unlock_as_irq(chip, d->hwirq); > + module_put(chip->owner); > } > > static int gpiochip_to_irq(struct gpio_chip *chip, unsigned offset) > -- > 2.4.4 > -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Jun 25, 2015 at 7:30 PM, Grygorii Strashko <grygorii.strashko@ti.com> wrote: > Now nothing prevents GPIO driver from being unloaded if its gpios > were requested as GPIO IRQs only (without calling gpio_request()). > > Hence, add calls of try_module_get()/module_put() into > gpiochip_irq_reqres/relres() to track such scenario properly. > > Cc: Johan Hovold <johan@kernel.org> > Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> Patch applied with Alexandre's review tag. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index be42ab3..9b1d247 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -522,10 +522,14 @@ static int gpiochip_irq_reqres(struct irq_data *d) { struct gpio_chip *chip = irq_data_get_irq_chip_data(d); + if (!try_module_get(chip->owner)) + return -ENODEV; + if (gpiochip_lock_as_irq(chip, d->hwirq)) { chip_err(chip, "unable to lock HW IRQ %lu for IRQ\n", d->hwirq); + module_put(chip->owner); return -EINVAL; } return 0; @@ -536,6 +540,7 @@ static void gpiochip_irq_relres(struct irq_data *d) struct gpio_chip *chip = irq_data_get_irq_chip_data(d); gpiochip_unlock_as_irq(chip, d->hwirq); + module_put(chip->owner); } static int gpiochip_to_irq(struct gpio_chip *chip, unsigned offset)
Now nothing prevents GPIO driver from being unloaded if its gpios were requested as GPIO IRQs only (without calling gpio_request()). Hence, add calls of try_module_get()/module_put() into gpiochip_irq_reqres/relres() to track such scenario properly. Cc: Johan Hovold <johan@kernel.org> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com> --- drivers/gpio/gpiolib.c | 5 +++++ 1 file changed, 5 insertions(+)