diff mbox

[2/2] gpio: mvebu: kill bogus dependency on GPIO_GENERIC

Message ID 1434713464-32069-2-git-send-email-yamada.masahiro@socionext.com
State New
Headers show

Commit Message

Masahiro Yamada June 19, 2015, 11:31 a.m. UTC
The driver gpio-mvebu.c does not depend on gpio-generic.c at all.
Drop unneeded "select GPIO_GENERIC".

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 drivers/gpio/Kconfig | 1 -
 1 file changed, 1 deletion(-)

Comments

Masahiro Yamada June 20, 2015, 11:54 p.m. UTC | #1
Adding more people.

I'd like them to check if this patch is correct.


2015-06-19 20:31 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
> The driver gpio-mvebu.c does not depend on gpio-generic.c at all.
> Drop unneeded "select GPIO_GENERIC".
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
>  drivers/gpio/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 25c232e..241d441 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -283,7 +283,6 @@ config GPIO_MVEBU
>         def_bool y
>         depends on PLAT_ORION
>         depends on OF
> -       select GPIO_GENERIC
>         select GENERIC_IRQ_CHIP
>
>  config GPIO_MXC
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> Please read the FAQ at  http://www.tux.org/lkml/
Gregory CLEMENT June 29, 2015, 12:25 p.m. UTC | #2
Hi Masahiro,

On 21/06/2015 01:54, Masahiro Yamada wrote:
> Adding more people.
> 
> I'd like them to check if this patch is correct.
> 
> 
> 2015-06-19 20:31 GMT+09:00 Masahiro Yamada <yamada.masahiro@socionext.com>:
>> The driver gpio-mvebu.c does not depend on gpio-generic.c at all.
>> Drop unneeded "select GPIO_GENERIC".
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

This would have come from a wrong copy and paste, because indeed we
have never used the gpio-generic.

Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>


Thanks,

Gregory

>> ---
>>
>>  drivers/gpio/Kconfig | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
>> index 25c232e..241d441 100644
>> --- a/drivers/gpio/Kconfig
>> +++ b/drivers/gpio/Kconfig
>> @@ -283,7 +283,6 @@ config GPIO_MVEBU
>>         def_bool y
>>         depends on PLAT_ORION
>>         depends on OF
>> -       select GPIO_GENERIC
>>         select GENERIC_IRQ_CHIP
>>
>>  config GPIO_MXC
>> --
>> 1.9.1
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> Please read the FAQ at  http://www.tux.org/lkml/
> 
> 
>
Linus Walleij July 15, 2015, 9:47 a.m. UTC | #3
On Fri, Jun 19, 2015 at 1:31 PM, Masahiro Yamada
<yamada.masahiro@socionext.com> wrote:

> The driver gpio-mvebu.c does not depend on gpio-generic.c at all.
> Drop unneeded "select GPIO_GENERIC".
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Patch applied with Gregory's ACK.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 25c232e..241d441 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -283,7 +283,6 @@  config GPIO_MVEBU
 	def_bool y
 	depends on PLAT_ORION
 	depends on OF
-	select GPIO_GENERIC
 	select GENERIC_IRQ_CHIP
 
 config GPIO_MXC