From patchwork Fri Jun 5 09:10:21 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 481123 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 6D99C1402AC for ; Fri, 5 Jun 2015 19:10:36 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932429AbbFEJKe (ORCPT ); Fri, 5 Jun 2015 05:10:34 -0400 Received: from mail-la0-f52.google.com ([209.85.215.52]:35120 "EHLO mail-la0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932320AbbFEJK3 (ORCPT ); Fri, 5 Jun 2015 05:10:29 -0400 Received: by labko7 with SMTP id ko7so49705858lab.2 for ; Fri, 05 Jun 2015 02:10:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=6bW6rCefwKh1ykvZ+Vxd8OoU3tNHe8E0WgLoKGv70k0=; b=JJJm6pc8HnYKLkxbuzKm7MvYOn5Q+f++1wAuNaE8pXW58pSOjx4eXwLIexT7Yi09mm G8RS3hN9DFy0HgEsjiosQJcOcqW4zt348vVVc9X6Ua6IsTnhHB5KA6mHkt4o7rBojQL1 LsfWy7l8eFoKPSAZqR6VzUaU8MWQt8Fj7fR7FY3Nh45Hc5VAkYwzgczDGegZLF+6zY85 WnLW+f4RGPjH/Ti00JfAeFBExBf5No6U4a63WnxvqYQThydWXUC8OHGR2+Zag+gMLHzY jFUT3FWlC0zkItZvZbMUaKGRJ7sCBemjWkBmBEbf7Q5yPsDt6mlXOovvUXvvVgEUF4r+ QUmA== X-Gm-Message-State: ALoCoQnTe9nX+fLoAQO0cvPyfw61E1KxSrBHburIJrszUDOP8OTfcT2e7QqZly1TcvehhvG3QQ0V X-Received: by 10.152.245.138 with SMTP id xo10mr2404235lac.108.1433495427789; Fri, 05 Jun 2015 02:10:27 -0700 (PDT) Received: from localhost.localdomain.localdomain (c-d37f71d5.01-192-6c756e10.cust.bredbandsbolaget.se. [213.113.127.211]) by mx.google.com with ESMTPSA id ky7sm1605205lab.37.2015.06.05.02.10.25 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 05 Jun 2015 02:10:26 -0700 (PDT) From: Linus Walleij To: linux-gpio@vger.kernel.org Cc: Alexandre Courbot , Linus Walleij Subject: [PATCH] gpio: promote own request failure to pr_err() Date: Fri, 5 Jun 2015 11:10:21 +0200 Message-Id: <1433495421-16267-1-git-send-email-linus.walleij@linaro.org> X-Mailer: git-send-email 2.4.2 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org These error messages are helpful to see that we fail to get hogs. Promote them to real errors so they appear in the boot crawl. Signed-off-by: Linus Walleij --- drivers/gpio/gpiolib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c index 6bc612b8a49f..4861b2db2edc 100644 --- a/drivers/gpio/gpiolib.c +++ b/drivers/gpio/gpiolib.c @@ -2118,13 +2118,13 @@ int gpiod_hog(struct gpio_desc *desc, const char *name, local_desc = gpiochip_request_own_desc(chip, hwnum, name); if (IS_ERR(local_desc)) { - pr_debug("requesting own GPIO %s failed\n", name); + pr_err("requesting own GPIO %s failed\n", name); return PTR_ERR(local_desc); } status = gpiod_configure_flags(desc, name, lflags, dflags); if (status < 0) { - pr_debug("setup of GPIO %s failed\n", name); + pr_err("setup of GPIO %s failed\n", name); gpiochip_free_own_desc(desc); return status; }