From patchwork Tue May 5 16:32:18 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Geert Uytterhoeven X-Patchwork-Id: 468171 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 790F91402AB for ; Wed, 6 May 2015 02:38:08 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761443AbbEEQgD (ORCPT ); Tue, 5 May 2015 12:36:03 -0400 Received: from baptiste.telenet-ops.be ([195.130.132.51]:38595 "EHLO baptiste.telenet-ops.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1761368AbbEEQc4 (ORCPT ); Tue, 5 May 2015 12:32:56 -0400 Received: from ayla.of.borg ([84.193.93.87]) by baptiste.telenet-ops.be with bizsmtp id QGYs1q00Q1t5w8s01GYsbD; Tue, 05 May 2015 18:32:55 +0200 Received: from ramsan.of.borg ([192.168.97.29] helo=ramsan) by ayla.of.borg with esmtp (Exim 4.82) (envelope-from ) id 1Ypfm8-0003LV-Em; Tue, 05 May 2015 18:32:52 +0200 Received: from geert by ramsan with local (Exim 4.82) (envelope-from ) id 1Ypfm8-0004rK-Ng; Tue, 05 May 2015 18:32:52 +0200 From: Geert Uytterhoeven To: Linus Walleij , Alexandre Courbot , Arnd Bergmann Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven , David Airlie , dri-devel@lists.freedesktop.org Subject: [PATCH 02/27] drm/bridge: ps8622: #include , depend on GPIOLIB Date: Tue, 5 May 2015 18:32:18 +0200 Message-Id: <1430843563-18615-2-git-send-email-geert@linux-m68k.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1430843563-18615-1-git-send-email-geert@linux-m68k.org> References: <1430836404-15513-1-git-send-email-geert@linux-m68k.org> <1430843563-18615-1-git-send-email-geert@linux-m68k.org> MIME-Version: 1.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org If GPIOLIB=n and asm-generic/gpio.h is not used: drivers/gpu/drm/bridge/ps8622.c: In function ‘ps8622_pre_enable’: drivers/gpu/drm/bridge/ps8622.c:368: error: implicit declaration of function ‘gpiod_set_value’ drivers/gpu/drm/bridge/ps8622.c: In function ‘ps8622_probe’: drivers/gpu/drm/bridge/ps8622.c:584: error: implicit declaration of function ‘devm_gpiod_get’ drivers/gpu/drm/bridge/ps8622.c:584: warning: assignment makes pointer from integer without a cast drivers/gpu/drm/bridge/ps8622.c:590: error: implicit declaration of function ‘gpiod_direction_output’ drivers/gpu/drm/bridge/ps8622.c:596: warning: assignment makes pointer from integer without a cast Add the missing #include to fix this. As the resulting driver won't work with GPIOLIB=n anyway, make DRM_PS8622 depend on GPIOLIB || COMPILE_TEST. Signed-off-by: Geert Uytterhoeven Cc: David Airlie Cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/bridge/Kconfig | 4 ++-- drivers/gpu/drm/bridge/ps8622.c | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig index 6cdcd2ec4848edec..3e562d3f37973efc 100644 --- a/drivers/gpu/drm/bridge/Kconfig +++ b/drivers/gpu/drm/bridge/Kconfig @@ -14,8 +14,8 @@ config DRM_PTN3460 config DRM_PS8622 tristate "Parade eDP/LVDS bridge" - depends on DRM - depends on OF + depends on DRM && OF + depends on GPIOLIB || COMPILE_TEST select DRM_PANEL select DRM_KMS_HELPER select BACKLIGHT_LCD_SUPPORT diff --git a/drivers/gpu/drm/bridge/ps8622.c b/drivers/gpu/drm/bridge/ps8622.c index e895aa7ea353164a..a9c38f8edf172bb9 100644 --- a/drivers/gpu/drm/bridge/ps8622.c +++ b/drivers/gpu/drm/bridge/ps8622.c @@ -18,6 +18,7 @@ #include #include #include +#include #include #include #include