From patchwork Fri Feb 6 16:30:56 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Stefan Agner X-Patchwork-Id: 437354 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id C8FF8140151 for ; Sat, 7 Feb 2015 03:31:03 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751486AbbBFQbC (ORCPT ); Fri, 6 Feb 2015 11:31:02 -0500 Received: from mail.kmu-office.ch ([178.209.48.109]:54303 "EHLO mail.kmu-office.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751485AbbBFQbB (ORCPT ); Fri, 6 Feb 2015 11:31:01 -0500 Received: from trochilidae.toradex.int (unknown [46.140.72.82]) by mail.kmu-office.ch (Postfix) with ESMTPSA id 4F06E5C0EFE; Fri, 6 Feb 2015 17:28:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=agner.ch; s=dkim; t=1423240125; bh=ByFArIHL/LKrBPJKOvU54WnrT06MNHO0gnlxOSxucPA=; h=From:To:Cc:Subject:Date:From; b=aaT7I5TEd88XFnhMfCufkvsXM9L0Gty3o/leRMTEVkq7B5Iyw9TsmKwHjK4/1TB4c dKGYvqYjkhoxxEnLfLbbReNRsB/on5so61YignPD5p4dJo4M6GYrSdRwRYoopdPm11 +td4uUKTclFniRZwYjjoRyj/mZ2DlDDhB1ICgA4I= From: Stefan Agner To: linus.walleij@linaro.org Cc: u.kleine-koenig@pengutronix.de, kernel@pengutronix.de, shawn.guo@linaro.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stefan@agner.ch Subject: [PATCH] pinctrl: imx: do not implicitly set pin regs to -1 Date: Fri, 6 Feb 2015 17:30:56 +0100 Message-Id: <1423240256-27210-1-git-send-email-stefan@agner.ch> X-Mailer: git-send-email 2.2.2 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Commit 3dac1918a491 ("pinctrl: imx: detect uninitialized pins") needs the values in struct imx_pin_reg to be -1. This has been done in a rather unorthodox way by setting the memory to 0xff using memset... Use a proper for loop to initialize the whole array with -1. Signed-off-by: Stefan Agner Acked-by: Uwe Kleine-König Acked-by: Shawn Guo --- drivers/pinctrl/freescale/pinctrl-imx.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/freescale/pinctrl-imx.c b/drivers/pinctrl/freescale/pinctrl-imx.c index 52f2b94..95041b6 100644 --- a/drivers/pinctrl/freescale/pinctrl-imx.c +++ b/drivers/pinctrl/freescale/pinctrl-imx.c @@ -645,7 +645,7 @@ int imx_pinctrl_probe(struct platform_device *pdev, { struct imx_pinctrl *ipctl; struct resource *res; - int ret; + int ret, i; if (!info || !info->pins || !info->npins) { dev_err(&pdev->dev, "wrong pinctrl info\n"); @@ -662,7 +662,11 @@ int imx_pinctrl_probe(struct platform_device *pdev, info->npins, GFP_KERNEL); if (!info->pin_regs) return -ENOMEM; - memset(info->pin_regs, 0xff, sizeof(*info->pin_regs) * info->npins); + + for (i = 0; i < info->npins; i++) { + info->pin_regs[i].mux_reg = -1; + info->pin_regs[i].conf_reg = -1; + } res = platform_get_resource(pdev, IORESOURCE_MEM, 0); ipctl->base = devm_ioremap_resource(&pdev->dev, res);