From patchwork Mon Jan 26 11:02:46 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Johan Hovold X-Patchwork-Id: 432711 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 60F5E14019D for ; Mon, 26 Jan 2015 22:04:39 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754533AbbAZLEg (ORCPT ); Mon, 26 Jan 2015 06:04:36 -0500 Received: from mail-la0-f53.google.com ([209.85.215.53]:40585 "EHLO mail-la0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754138AbbAZLEW (ORCPT ); Mon, 26 Jan 2015 06:04:22 -0500 Received: by mail-la0-f53.google.com with SMTP id gq15so6984374lab.12; Mon, 26 Jan 2015 03:04:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=fASeUVtu9VdcRuL4IdgPbOrnt1qVZNg8YyQt49dP3ko=; b=HmUnPl8cKRVmLttXE0J9moBKTvVHADkfGLial3Qg1PAB7UTfzfiEy6saK4HsaXElMG LsXjoHjbOxBNlARTmL8soq2iLm1f/jDLj4Rp2foqD4CUETVNVdCGMPMUp+nuTImLayto RFkk5iiMi2sgqaxPcZgb/Lu8oZ/5Fd0nUTAffb3z4SXQoDyKqaM+kaP5jcy0pDWMHuJu UkeztP1cmtT+AHcqN1LW9y/A2s+8kOZZzzFlAf6AbgljDJjr8oaevQeQn9xJzXxP2bfM CfkM1oU/v0NYFPqdj5LA6ecmVLP4WMNpF+zE9b6MwI+xcwsXu2g+MM4KVcF27/FLiPsa m/1A== X-Received: by 10.112.47.135 with SMTP id d7mr20423036lbn.54.1422270260381; Mon, 26 Jan 2015 03:04:20 -0800 (PST) Received: from xi.terra (s83-177-171-8.cust.tele2.se. [83.177.171.8]) by mx.google.com with ESMTPSA id g5sm2731602lag.11.2015.01.26.03.04.17 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Jan 2015 03:04:18 -0800 (PST) Received: from johan by xi.terra with local (Exim 4.84) (envelope-from ) id 1YFhSq-0004ZT-Fb; Mon, 26 Jan 2015 12:04:16 +0100 From: Johan Hovold To: Linus Walleij Cc: Alexandre Courbot , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Johan Hovold , stable Subject: [PATCH 2/2] gpio: sysfs: fix memory leak in gpiod_sysfs_set_active_low Date: Mon, 26 Jan 2015 12:02:46 +0100 Message-Id: <1422270166-17525-3-git-send-email-johan@kernel.org> X-Mailer: git-send-email 2.0.5 In-Reply-To: <1422270166-17525-1-git-send-email-johan@kernel.org> References: <1422270166-17525-1-git-send-email-johan@kernel.org> Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Fix memory leak in the gpio sysfs interface due to failure to drop reference to device returned by class_find_device when setting the gpio-line polarity. Fixes: 0769746183ca ("gpiolib: add support for changing value polarity in sysfs") Cc: stable # v2.6.33 Signed-off-by: Johan Hovold --- drivers/gpio/gpiolib-sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpiolib-sysfs.c b/drivers/gpio/gpiolib-sysfs.c index 820b1e70ddfe..4908d09873e5 100644 --- a/drivers/gpio/gpiolib-sysfs.c +++ b/drivers/gpio/gpiolib-sysfs.c @@ -696,7 +696,7 @@ int gpiod_sysfs_set_active_low(struct gpio_desc *desc, int value) } status = sysfs_set_active_low(desc, dev, value); - + put_device(dev); unlock: mutex_unlock(&sysfs_lock);