| Message ID | 1421161778-5671-1-git-send-email-md.jamalmohiuddin@gmail.com |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Jan 13, 2015 at 4:09 PM, Mohammad Jamal <md.jamalmohiuddin@gmail.com> wrote: > Fix the coding style issue by adding a blank line after declaration > > Signed-off-by: Mohammad Jamal <md.jamalmohiuddin@gmail.com> Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Jan 15, 2015 at 06:20:43PM +0100, Linus Walleij wrote: > On Tue, Jan 13, 2015 at 4:09 PM, Mohammad Jamal > <md.jamalmohiuddin@gmail.com> wrote: > > > Fix the coding style issue by adding a blank line after declaration > > > > Signed-off-by: Mohammad Jamal <md.jamalmohiuddin@gmail.com> > > Patch applied. This one looks bogus; it's adding a random newline within the declarations not after. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
I think you are write ... checkpatch.pl was giving the error at the line so i added a blank line... i will send an updated patch.. On Thu, Jan 15, 2015 at 11:40 PM, Johan Hovold <johan@kernel.org> wrote: > On Thu, Jan 15, 2015 at 06:20:43PM +0100, Linus Walleij wrote: >> On Tue, Jan 13, 2015 at 4:09 PM, Mohammad Jamal >> <md.jamalmohiuddin@gmail.com> wrote: >> >> > Fix the coding style issue by adding a blank line after declaration >> > >> > Signed-off-by: Mohammad Jamal <md.jamalmohiuddin@gmail.com> >> >> Patch applied. > > This one looks bogus; it's adding a random newline within the > declarations not after. > > Johan -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[ Please do not top-post. ] On Fri, Jan 16, 2015 at 10:22:56AM +0530, Jamal Mohammad wrote: > I think you are write ... checkpatch.pl was giving the error at the > line so i added a blank line... i will send an updated patch.. You should not trust checkpatch.pl blindly, and not run it on in-kernel files either. Use it on your own patches as a way to find (possible) mistakes before submission. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/gpio/gpio-dln2.c b/drivers/gpio/gpio-dln2.c index ce3c155..dbdb4de 100644 --- a/drivers/gpio/gpio-dln2.c +++ b/drivers/gpio/gpio-dln2.c @@ -396,6 +396,7 @@ static void dln2_gpio_event(struct platform_device *pdev, u16 echo, const void *data, int len) { int pin, irq; + const struct { __le16 count; __u8 type;
Fix the coding style issue by adding a blank line after declaration Signed-off-by: Mohammad Jamal <md.jamalmohiuddin@gmail.com> --- drivers/gpio/gpio-dln2.c | 1 + 1 file changed, 1 insertion(+)