From patchwork Mon Dec 29 08:39:01 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Varka Bhadram X-Patchwork-Id: 424398 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id BE41B1400DD for ; Mon, 29 Dec 2014 19:43:36 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751232AbaL2In0 (ORCPT ); Mon, 29 Dec 2014 03:43:26 -0500 Received: from mail-pd0-f177.google.com ([209.85.192.177]:51824 "EHLO mail-pd0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751941AbaL2InR (ORCPT ); Mon, 29 Dec 2014 03:43:17 -0500 Received: by mail-pd0-f177.google.com with SMTP id ft15so16633342pdb.36 for ; Mon, 29 Dec 2014 00:43:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=mJEMXQDJV+H0xHiBk72nRSsQEnIYFX9NzoyPY0H0Lfc=; b=RNZNPaVbFoOMV1oIRBbHGIow3AqOFXzkg7HoVk3iniiPaMzmdHlPyNbremCpVD/1QB aktuLicoyzfIC4EL/B0L3paEETjXr4kSNEevd5hVvFr87QOnESN9OZs0XPR2krIKYRhV 1n5CsqbXiaSHuBHTj+5X4+mojQEz42xmrOByXHJ48HOJPUvoUrFsw/jOlHsca2/IYcM6 57wBlBB8A2fVgdLTHKuiUA9bt33dcrnSiHqUiwjJsbs5X7R7gNGxurdSgURfU4aJLOkP +wgTHZfk04LGlnFOIrHwseq6KEQE34pWApKypRv1Wu2uKGg3Nt183fCfxZqmflnWxnbp NEIA== X-Received: by 10.69.1.37 with SMTP id bd5mr20634636pbd.129.1419842596922; Mon, 29 Dec 2014 00:43:16 -0800 (PST) Received: from cdac.hyderabad.cdac.in ([196.12.45.164]) by mx.google.com with ESMTPSA id je4sm34762472pbd.94.2014.12.29.00.43.13 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 29 Dec 2014 00:43:15 -0800 (PST) From: Varka Bhadram X-Google-Original-From: Varka Bhadram To: linux-gpio@vger.kernel.org Cc: linus.walleij@linaro.org, Varka Bhadram Subject: [PATCH gpio] gpio-amd8111: check ioport_map return value Date: Mon, 29 Dec 2014 14:09:01 +0530 Message-Id: <1419842341-22694-1-git-send-email-varkab@cdac.in> X-Mailer: git-send-email 1.7.9.5 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org ioport_map() may fail. Its safe to check the return value. Signed-off-by: Varka Bhadram --- drivers/gpio/gpio-amd8111.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/gpio/gpio-amd8111.c b/drivers/gpio/gpio-amd8111.c index 3c09f1a6..a0585c3 100644 --- a/drivers/gpio/gpio-amd8111.c +++ b/drivers/gpio/gpio-amd8111.c @@ -213,6 +213,11 @@ found: goto out; } gp.pm = ioport_map(gp.pmbase + PMBASE_OFFSET, PMBASE_SIZE); + if (!gp.pm) { + dev_err(&pdev->dev, "Couldn't map io port into io memory\n"); + err = -ENOMEM; + goto out; + } gp.pdev = pdev; gp.chip.dev = &pdev->dev;