| Message ID | 1418831474-24428-8-git-send-email-ricardo.ribalda@gmail.com |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Dec 17, 2014 at 4:51 PM, Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> wrote: > Use the newly created of_mm_gpiochip_remove function for cleaning up > of_mm_gpiochip_add > > Suggested-by: Alexandre Courbot <gnurou@gmail.com> > Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> Patch applied. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-gpio" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/gpio/gpio-xilinx.c b/drivers/gpio/gpio-xilinx.c index e89fb42..61243d1 100644 --- a/drivers/gpio/gpio-xilinx.c +++ b/drivers/gpio/gpio-xilinx.c @@ -236,10 +236,7 @@ static int xgpio_remove(struct platform_device *pdev) { struct xgpio_instance *chip = platform_get_drvdata(pdev); - gpiochip_remove(&chip->mmchip.gc); - - iounmap(chip->mmchip.regs); - kfree(chip->mmchip.gc.label); + of_mm_gpiochip_remove(&chip->mmchip); return 0; }
Use the newly created of_mm_gpiochip_remove function for cleaning up of_mm_gpiochip_add Suggested-by: Alexandre Courbot <gnurou@gmail.com> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> --- drivers/gpio/gpio-xilinx.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)