From patchwork Sun Mar 3 07:51:43 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: William Breathitt Gray X-Patchwork-Id: 1050805 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-gpio-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="ojfxmGFw"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 44BwM54sNVz9sBF for ; Sun, 3 Mar 2019 18:50:57 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725993AbfCCHu4 (ORCPT ); Sun, 3 Mar 2019 02:50:56 -0500 Received: from mail-pg1-f193.google.com ([209.85.215.193]:36554 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725877AbfCCHu4 (ORCPT ); Sun, 3 Mar 2019 02:50:56 -0500 Received: by mail-pg1-f193.google.com with SMTP id r124so1031831pgr.3; Sat, 02 Mar 2019 23:50:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=UifkzEkFRqXu3yixaaw6yvTChu7M21y6ZQxvlg1zFMs=; b=ojfxmGFwRLFyuJDYOF9Bd8zYmbOX5hRQmO1fjeBXHYEdxDNCk6flfMYPtIFbF/Sosu QjwqzgGRRzUR/gH75F37vldJ64FXGmkznZTBs/I8bp7wJi+x6UTMG5/Uq3nl79IMn2HJ VRogi8HkGoEN2YeXoVDyWsCBHU+6x3Wv0ETXILjP7Jea3MPDNcl1LiVEel0zJR/QS5FM xlFADQCDFaLDH4BPluMBDDnyxXr2SEFY2i424dUS8hQE+ClDNnYTrltlMfApDQOmqTvz bw8Eb8gsTf8s32czH9FAQdATV0ueUid+zPCUt1o3lcs7tbuTUAt1jxHsgLoGa8BxD2A0 7L8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=UifkzEkFRqXu3yixaaw6yvTChu7M21y6ZQxvlg1zFMs=; b=nmvxPPgLBS8eUeDUPsoe6iMEZ3G1M70ZQtdoNd36R70TSR8MJN+9eIwLdHGpqvKuxR oAc6lmy5+YEDiAS2DPP3f5fmp48G9yTly8VTKtGHA2+2fKRncMkMHvaNbLdVyRzgdV8f gMYhVjUuJ86S65iLTz5zHT1mVgKIdxliCSufV5b6SBNwbno88yPe+tga/zFVCtMwXN2W IkPT2aOKS0Bnk8a9Ptpoq2vSiXtwkU4sNN5qQ+5eJsrWBwXzMymhDRH/Buj4P2o8Blaw nH2rp4bBaTzh69ANodsoxftN+kjTeURGG5t72gB9rtHEeeLBAbeuqpBWJ7K0ViTzUdnK rhHA== X-Gm-Message-State: APjAAAXkRSiSPMdbYCLLQzEKjJBEqcg/+1UmtJEgQkQ3isxKQi+paK8t rgCWHsCgVSwJKmCQVc4fTEg= X-Google-Smtp-Source: AHgI3IaRcnUNGGrMNo351mYUWL3BWUGU+5ZHcEvSSM8aSjLkbPbmGgKncncfSHeoBVILcIaVCq+gbA== X-Received: by 2002:aa7:8299:: with SMTP id s25mr14222435pfm.56.1551599455604; Sat, 02 Mar 2019 23:50:55 -0800 (PST) Received: from localhost.localdomain ([2001:268:c0a5:3b5c:c70:4af9:86e2:2]) by smtp.gmail.com with ESMTPSA id y6sm4735357pfy.87.2019.03.02.23.50.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 02 Mar 2019 23:50:55 -0800 (PST) From: William Breathitt Gray To: linus.walleij@linaro.org Cc: akpm@linux-foundation.org, linux-gpio@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, andriy.shevchenko@linux.intel.com, linux@rasmusvillemoes.dk, yamada.masahiro@socionext.com, bgolaszewski@baylibre.com, linux-arm-kernel@lists.infradead.org, William Breathitt Gray Subject: [PATCH v9 9/9] gpio: uniphier: Utilize for_each_set_clump8 macro Date: Sun, 3 Mar 2019 16:51:43 +0900 Message-Id: <0840d55707dacd1121659723246fa9f55737f426.1551598603.git.vilhelm.gray@gmail.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: References: MIME-Version: 1.0 Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Replace verbose implementation in set_multiple callback with for_each_set_clump8 macro to simplify code and improve clarity. An improvement in this case is that banks that are not masked will now be skipped. Cc: Masahiro Yamada Signed-off-by: William Breathitt Gray --- drivers/gpio/gpio-uniphier.c | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/drivers/gpio/gpio-uniphier.c b/drivers/gpio/gpio-uniphier.c index 0f662b297a95..df640cb29b9c 100644 --- a/drivers/gpio/gpio-uniphier.c +++ b/drivers/gpio/gpio-uniphier.c @@ -15,9 +15,6 @@ #include #include -#define UNIPHIER_GPIO_BANK_MASK \ - GENMASK((UNIPHIER_GPIO_LINES_PER_BANK) - 1, 0) - #define UNIPHIER_GPIO_IRQ_MAX_NUM 24 #define UNIPHIER_GPIO_PORT_DATA 0x0 /* data */ @@ -147,15 +144,14 @@ static void uniphier_gpio_set(struct gpio_chip *chip, static void uniphier_gpio_set_multiple(struct gpio_chip *chip, unsigned long *mask, unsigned long *bits) { - unsigned int bank, shift, bank_mask, bank_bits; - int i; + unsigned int i; + unsigned long bank_mask; + unsigned int bank; + unsigned int bank_bits; - for (i = 0; i < chip->ngpio; i += UNIPHIER_GPIO_LINES_PER_BANK) { + for_each_set_clump8(i, bank_mask, mask, chip->ngpio) { bank = i / UNIPHIER_GPIO_LINES_PER_BANK; - shift = i % BITS_PER_LONG; - bank_mask = (mask[BIT_WORD(i)] >> shift) & - UNIPHIER_GPIO_BANK_MASK; - bank_bits = bits[BIT_WORD(i)] >> shift; + bank_bits = bitmap_get_value8(bits, chip->ngpio, i); uniphier_gpio_bank_write(chip, bank, UNIPHIER_GPIO_PORT_DATA, bank_mask, bank_bits);