| Message ID | 0723049c70dd9c90b30137b704c82db27d0ac4df.1640528330.git.christophe.jaillet@wanadoo.fr |
|---|---|
| State | New |
| Headers | show |
| Series | gpio: max3191x: Use bitmap_free() to free bitmap | expand |
On Sun, Dec 26, 2021 at 3:19 PM Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote: > > kfree() and bitmap_free() are the same. But using the later is more > consistent when freeing memory allocated with bitmap_alloc(). > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > drivers/gpio/gpio-max3191x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpio/gpio-max3191x.c b/drivers/gpio/gpio-max3191x.c > index 310d1a248cae..51cd6f98d1c7 100644 > --- a/drivers/gpio/gpio-max3191x.c > +++ b/drivers/gpio/gpio-max3191x.c > @@ -326,7 +326,7 @@ static void gpiod_set_array_single_value_cansleep(unsigned int ndescs, > bitmap_zero(values, ndescs); > > gpiod_set_array_value_cansleep(ndescs, desc, info, values); > - kfree(values); > + bitmap_free(values); > } > > static struct gpio_descs *devm_gpiod_get_array_optional_count( > -- > 2.32.0 > Good point, applied. Bart
diff --git a/drivers/gpio/gpio-max3191x.c b/drivers/gpio/gpio-max3191x.c index 310d1a248cae..51cd6f98d1c7 100644 --- a/drivers/gpio/gpio-max3191x.c +++ b/drivers/gpio/gpio-max3191x.c @@ -326,7 +326,7 @@ static void gpiod_set_array_single_value_cansleep(unsigned int ndescs, bitmap_zero(values, ndescs); gpiod_set_array_value_cansleep(ndescs, desc, info, values); - kfree(values); + bitmap_free(values); } static struct gpio_descs *devm_gpiod_get_array_optional_count(
kfree() and bitmap_free() are the same. But using the later is more consistent when freeing memory allocated with bitmap_alloc(). Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- drivers/gpio/gpio-max3191x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)