| Message ID | cover.1550148989.git.matti.vaittinen@fi.rohmeurope.com |
|---|---|
| Headers | show |
| Series | support ROHM BD70528 PMIC | expand |
Hello Lee and Mark, On Thu, Feb 14, 2019 at 03:02:37PM +0200, Matti Vaittinen wrote: > Patch series introducing support for ROHM BD70528 PMIC > > ROHM BD70528 is a programmable Power Management IC for battery > powered 'ultra low power' systems like the pre-announced NXP > i.MX7 ULP. This patch series introduces support for the PMIC. Please > note that this driver only supports HW setup where PMIC is connected > to I2C on A7 core. The other scenario is to use M4 as a power manager > and connect pmic to M4. On such setups the A7 can only access pmic > via M4 core using RPMSG virtio. Such setup depends on RPMSG > implementation on M4 core and is currently not supported by this > patch series. > I was wondering if there is anything that could be done to allow the MFD part of this series to end up in upstream without having to wait the regmap-irq changes (https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git/commit/?h=topic/irq) to be merged from Linus' tree to MFD tree? If I see it correctly, the regmap-irq (main-irq-reg support) changes are not targeted to linux 5.1. To me it looks like getting them to MFD via Linus' tree will take a while. The MFD part depends on the regmap-irq changes and I think that most other subsystems want to have the MFD changes in before taking rest of the driver in their trees. So it will be a while untill all the changes are in. It would really be nice to have the drive in-tree sooner - hence I ask if theres a way. (I don't want to push, just ask if it is possible :]) Best Regards Matti Vaittinen
On Thu, 28 Feb 2019, Matti Vaittinen wrote: > Hello Lee and Mark, > > On Thu, Feb 14, 2019 at 03:02:37PM +0200, Matti Vaittinen wrote: > > Patch series introducing support for ROHM BD70528 PMIC > > > > ROHM BD70528 is a programmable Power Management IC for battery > > powered 'ultra low power' systems like the pre-announced NXP > > i.MX7 ULP. This patch series introduces support for the PMIC. Please > > note that this driver only supports HW setup where PMIC is connected > > to I2C on A7 core. The other scenario is to use M4 as a power manager > > and connect pmic to M4. On such setups the A7 can only access pmic > > via M4 core using RPMSG virtio. Such setup depends on RPMSG > > implementation on M4 core and is currently not supported by this > > patch series. > > > > I was wondering if there is anything that could be done to allow the MFD > part of this series to end up in upstream without having to wait the > regmap-irq changes > (https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git/commit/?h=topic/irq) > to be merged from Linus' tree to MFD tree? If I see it correctly, the > regmap-irq (main-irq-reg support) changes are not targeted to linux 5.1. > To me it looks like getting them to MFD via Linus' tree will take a while. > > The MFD part depends on the regmap-irq changes and I think that most > other subsystems want to have the MFD changes in before taking rest of > the driver in their trees. So it will be a while untill all the changes > are in. It would really be nice to have the drive in-tree sooner - hence > I ask if theres a way. (I don't want to push, just ask if it is possible :]) It's possible, so long as there aren't any build-time dependencies between the subsystems. Immediate acceptance however isn't possible due to the impending merge-window which opens in 3 days.
Hello Lee, Mark, On Thu, Feb 28, 2019 at 08:10:55AM +0000, Lee Jones wrote: > On Thu, 28 Feb 2019, Matti Vaittinen wrote: > > > Hello Lee and Mark, > > > > On Thu, Feb 14, 2019 at 03:02:37PM +0200, Matti Vaittinen wrote: > > > Patch series introducing support for ROHM BD70528 PMIC > > > > > I was wondering if there is anything that could be done to allow the MFD > > part of this series to end up in upstream without having to wait the > > regmap-irq changes > > (https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git/commit/?h=topic/irq) > > to be merged from Linus' tree to MFD tree? If I see it correctly, the > > regmap-irq (main-irq-reg support) changes are not targeted to linux 5.1. > > To me it looks like getting them to MFD via Linus' tree will take a while. > > > > The MFD part depends on the regmap-irq changes and I think that most > > other subsystems want to have the MFD changes in before taking rest of > > the driver in their trees. So it will be a while untill all the changes > > are in. It would really be nice to have the drive in-tree sooner - hence > > I ask if theres a way. (I don't want to push, just ask if it is possible :]) > > It's possible, so long as there aren't any build-time dependencies > between the subsystems. Immediate acceptance however isn't possible > due to the impending merge-window which opens in 3 days. Thanks for reply Lee. So merge-window is opening - meaning the 5.1 is being baked now(?) Anyays to make it clear - there is build time dependency between MFD and regmap-irq changes. MFD part won't compile without the changes in regmap tree. And theres no new Kconfig to depend on or other compile time checks. So REGMAP changes are required for this MFD portion to compile. So my question actually is if the MFD portion must wait untill REGMAP goes to Linus tree (at 5.2(?))- and then get merged to MFD tree later - or if the regmap-irq changes can go to MFD via some other route (sorry - I don't really know how you guys do maintain the trees - I really lack of the insight/skills on that area :]) Rest of the subsystems (regulator, clk, watchdog, gpio) do all depend on MFD - but they should have 'depends on' KConfig to MFD meaning they won't be built without MFD. Br, Matti Vaittinen
On Thu, Feb 28, 2019 at 09:04:50AM +0200, Matti Vaittinen wrote: > On Thu, Feb 14, 2019 at 03:02:37PM +0200, Matti Vaittinen wrote: >> Patch series introducing support for ROHM BD70528 PMIC > > I was wondering if there is anything that could be done to allow the MFD > part of this series to end up in upstream without having to wait the > regmap-irq changes > (https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git/commit/?h=topic/irq) > to be merged from Linus' tree to MFD tree? If I see it correctly, the > regmap-irq (main-irq-reg support) changes are not targeted to linux 5.1. > To me it looks like getting them to MFD via Linus' tree will take a while. They're targeted for v5.1 and I sent a pull request to Lee for that branch IIRC.
On Thu, Feb 28, 2019 at 11:40:26AM +0000, Mark Brown wrote: > On Thu, Feb 28, 2019 at 09:04:50AM +0200, Matti Vaittinen wrote: > > On Thu, Feb 14, 2019 at 03:02:37PM +0200, Matti Vaittinen wrote: > > >> Patch series introducing support for ROHM BD70528 PMIC > > > > I was wondering if there is anything that could be done to allow the MFD > > part of this series to end up in upstream without having to wait the > > regmap-irq changes > > (https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git/commit/?h=topic/irq) > > to be merged from Linus' tree to MFD tree? If I see it correctly, the > > regmap-irq (main-irq-reg support) changes are not targeted to linux 5.1. > > To me it looks like getting them to MFD via Linus' tree will take a while. > > They're targeted for v5.1 and I sent a pull request to Lee for that > branch IIRC. Thanks Mark. I think I have misunderstood how you deliver changes to 5.1 - or then I have done some other mistake. I thought these changes were not going to 5.1 as I did not see them in your for-5.1 branch. But I probably did some error there. Thanks for explaining this :) Br, Matti Vaittinen
Hello again Lee & all, On Thu, Feb 28, 2019 at 10:22:48AM +0200, Matti Vaittinen wrote: > On Thu, Feb 28, 2019 at 08:10:55AM +0000, Lee Jones wrote: > > On Thu, 28 Feb 2019, Matti Vaittinen wrote: > > > > > Hello Lee and Mark, > > > > > > On Thu, Feb 14, 2019 at 03:02:37PM +0200, Matti Vaittinen wrote: > > > > Patch series introducing support for ROHM BD70528 PMIC //snip > > > > > > The MFD part depends on the regmap-irq changes and I think that most > > > other subsystems want to have the MFD changes in before taking rest of > > > the driver in their trees. So it will be a while untill all the changes > > > are in. It would really be nice to have the drive in-tree sooner - hence > > > I ask if theres a way. (I don't want to push, just ask if it is possible :]) > > > > It's possible, so long as there aren't any build-time dependencies > > between the subsystems. Immediate acceptance however isn't possible > > due to the impending merge-window which opens in 3 days. > > Thanks for reply Lee. So merge-window is opening - meaning the 5.1 is > being baked now(?) > > Anyays to make it clear - there is build time dependency between MFD and > regmap-irq changes. MFD part won't compile without the changes in regmap > tree. And theres no new Kconfig to depend on or other compile time > checks. So REGMAP changes are required for this MFD portion to compile. //snip > Rest of the subsystems (regulator, clk, watchdog, gpio) do all depend on > MFD - but they should have 'depends on' KConfig to MFD meaning they > won't be built without MFD. I see the 5.1-rc1 and 5.1-rc2 are out. Those contain the regmap-irq changes the BD70528 MFD driver depends on. Would you like me to rebase the series to some other tree (which tree/branch? I don't see updated for-mfd-next branch in kernel.org yet) and resend it? Original patch series was created on top of the regulator tree. Br, Matti Vaittinen
On Mon, 25 Mar 2019, Matti Vaittinen wrote: > Hello again Lee & all, > > On Thu, Feb 28, 2019 at 10:22:48AM +0200, Matti Vaittinen wrote: > > On Thu, Feb 28, 2019 at 08:10:55AM +0000, Lee Jones wrote: > > > On Thu, 28 Feb 2019, Matti Vaittinen wrote: > > > > > > > Hello Lee and Mark, > > > > > > > > On Thu, Feb 14, 2019 at 03:02:37PM +0200, Matti Vaittinen wrote: > > > > > Patch series introducing support for ROHM BD70528 PMIC > > //snip > > > > > > > > > The MFD part depends on the regmap-irq changes and I think that most > > > > other subsystems want to have the MFD changes in before taking rest of > > > > the driver in their trees. So it will be a while untill all the changes > > > > are in. It would really be nice to have the drive in-tree sooner - hence > > > > I ask if theres a way. (I don't want to push, just ask if it is possible :]) > > > > > > It's possible, so long as there aren't any build-time dependencies > > > between the subsystems. Immediate acceptance however isn't possible > > > due to the impending merge-window which opens in 3 days. > > > > Thanks for reply Lee. So merge-window is opening - meaning the 5.1 is > > being baked now(?) > > > > Anyays to make it clear - there is build time dependency between MFD and > > regmap-irq changes. MFD part won't compile without the changes in regmap > > tree. And theres no new Kconfig to depend on or other compile time > > checks. So REGMAP changes are required for this MFD portion to compile. > > //snip > > > Rest of the subsystems (regulator, clk, watchdog, gpio) do all depend on > > MFD - but they should have 'depends on' KConfig to MFD meaning they > > won't be built without MFD. > > I see the 5.1-rc1 and 5.1-rc2 are out. Those contain the regmap-irq > changes the BD70528 MFD driver depends on. Would you like me to rebase > the series to some other tree (which tree/branch? I don't see updated > for-mfd-next branch in kernel.org yet) and resend it? Original patch > series was created on top of the regulator tree. If you could rebase and resend, that would be great. You should (very nearly) always base on an upstream tag, so v5.1-rc2 would be best in this case.
On Mon, Mar 25, 2019 at 08:02:06AM +0000, Lee Jones wrote: > On Mon, 25 Mar 2019, Matti Vaittinen wrote: > > > Hello again Lee & all, > > > > On Thu, Feb 28, 2019 at 10:22:48AM +0200, Matti Vaittinen wrote: > > > On Thu, Feb 28, 2019 at 08:10:55AM +0000, Lee Jones wrote: > > > > On Thu, 28 Feb 2019, Matti Vaittinen wrote: > > > > > > > > > Hello Lee and Mark, > > > > > > > > > > On Thu, Feb 14, 2019 at 03:02:37PM +0200, Matti Vaittinen wrote: > > > > > > Patch series introducing support for ROHM BD70528 PMIC > > > > I see the 5.1-rc1 and 5.1-rc2 are out. Those contain the regmap-irq > > changes the BD70528 MFD driver depends on. Would you like me to rebase > > the series to some other tree (which tree/branch? I don't see updated > > for-mfd-next branch in kernel.org yet) and resend it? Original patch > > series was created on top of the regulator tree. > > If you could rebase and resend, that would be great. > > You should (very nearly) always base on an upstream tag, so v5.1-rc2 > would be best in this case. So always use tag from "kernel/git/torvalds/linux.git" tree? Thanks for this guidance :) I'll try getting this rebased and resent today or tomorrow. Br, Matti Vaittinen > > -- > Lee Jones [李琼斯] > Linaro Services Technical Lead > Linaro.org │ Open source software for ARM SoCs > Follow Linaro: Facebook | Twitter | Blog