mbox series

[v1,0/4] gpiolib: acpi: Use con_id in acpi_dev_gpio_irq_get_by()

Message ID 20240411172540.4122581-2-andriy.shevchenko@linux.intel.com
Headers show
Series gpiolib: acpi: Use con_id in acpi_dev_gpio_irq_get_by() | expand

Message

Andy Shevchenko April 11, 2024, 5:22 p.m. UTC
Use con_id instead of property in the acpi_dev_gpio_irq_get_by().
It will be aligned with other GPIO library functions.

Assumed to go via my GPIO ACPI library tree follwoed by GPIO subsystem.

Andy Shevchenko (4):
  gpiolib: acpi: Extract __acpi_find_gpio() helper
  gpiolib: acpi: Simplify error handling in __acpi_find_gpio()
  gpiolib: acpi: Move acpi_can_fallback_to_crs() out of
    __acpi_find_gpio()
  gpiolib: acpi: Pass con_id instead of property into
    acpi_dev_gpio_irq_get_by()

 drivers/gpio/gpio-pca953x.c                   |  2 +-
 drivers/gpio/gpiolib-acpi.c                   | 52 +++++++++++--------
 .../mellanox/mlxbf_gige/mlxbf_gige_main.c     |  2 +-
 drivers/pinctrl/pinctrl-cy8c95x0.c            |  2 +-
 include/linux/acpi.h                          |  8 +--
 5 files changed, 37 insertions(+), 29 deletions(-)

Comments

Mika Westerberg April 12, 2024, 10:19 a.m. UTC | #1
On Thu, Apr 11, 2024 at 08:22:28PM +0300, Andy Shevchenko wrote:
> Use con_id instead of property in the acpi_dev_gpio_irq_get_by().
> It will be aligned with other GPIO library functions.
> 
> Assumed to go via my GPIO ACPI library tree follwoed by GPIO subsystem.
> 
> Andy Shevchenko (4):
>   gpiolib: acpi: Extract __acpi_find_gpio() helper
>   gpiolib: acpi: Simplify error handling in __acpi_find_gpio()
>   gpiolib: acpi: Move acpi_can_fallback_to_crs() out of
>     __acpi_find_gpio()
>   gpiolib: acpi: Pass con_id instead of property into
>     acpi_dev_gpio_irq_get_by()
> 
>  drivers/gpio/gpio-pca953x.c                   |  2 +-
>  drivers/gpio/gpiolib-acpi.c                   | 52 +++++++++++--------

For the gpiolib-acpi.c parts,

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Andy Shevchenko April 12, 2024, 4:03 p.m. UTC | #2
On Fri, Apr 12, 2024 at 01:19:44PM +0300, Mika Westerberg wrote:
> On Thu, Apr 11, 2024 at 08:22:28PM +0300, Andy Shevchenko wrote:
> > Use con_id instead of property in the acpi_dev_gpio_irq_get_by().
> > It will be aligned with other GPIO library functions.
> > 
> > Assumed to go via my GPIO ACPI library tree follwoed by GPIO subsystem.
> > 
> > Andy Shevchenko (4):
> >   gpiolib: acpi: Extract __acpi_find_gpio() helper
> >   gpiolib: acpi: Simplify error handling in __acpi_find_gpio()
> >   gpiolib: acpi: Move acpi_can_fallback_to_crs() out of
> >     __acpi_find_gpio()
> >   gpiolib: acpi: Pass con_id instead of property into
> >     acpi_dev_gpio_irq_get_by()
> > 
> >  drivers/gpio/gpio-pca953x.c                   |  2 +-
> >  drivers/gpio/gpiolib-acpi.c                   | 52 +++++++++++--------
> 
> For the gpiolib-acpi.c parts,
> 
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Pushed to my review and testing queue, thanks!

Note, I'll will wait for Acks for Mellanox and ACPI code
for a while, the series will appear in Linux Next for the
testing purposes, but if anybody objects, please let me
know.