| Message ID | 20220902-get_gpiod_from_child-remove-v1-0-1e47125df20f@gmail.com |
|---|---|
| Headers | show |
| Series | Get rid of devm_fwnode_get_[index_]gpiod_from_child() | expand |
On Sat, Sep 3, 2022 at 3:59 AM Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote: > > This drops the last uses of devm_fwnode_get_[index_]gpiod_from_child() > from the tree and drops the stubs implementing this API on top of > devm_fwnode_gpiod_get_index(). > > Note that the bulk of users were converted in 2019, the couple of LED > drivers are all that have remained. Full support and green light from me, thanks! Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> P.S. More of the similar is welcome, if you have any! > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
On Sat, Sep 3, 2022 at 2:56 AM Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote: > This drops the last uses of devm_fwnode_get_[index_]gpiod_from_child() > from the tree and drops the stubs implementing this API on top of > devm_fwnode_gpiod_get_index(). > > Note that the bulk of users were converted in 2019, the couple of LED > drivers are all that have remained. > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Oh that's neat. Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Yours, Linus Walleij
Hi Pavel, Marek, On Fri, Sep 02, 2022 at 05:55:24PM -0700, Dmitry Torokhov wrote: > This drops the last uses of devm_fwnode_get_[index_]gpiod_from_child() > from the tree and drops the stubs implementing this API on top of > devm_fwnode_gpiod_get_index(). > > Note that the bulk of users were converted in 2019, the couple of LED > drivers are all that have remained. > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > > --- > Dmitry Torokhov (3): > leds: gpio: switch to using devm_fwnode_gpiod_get() > leds: lgm-sso: switch to using devm_fwnode_gpiod_get() > gpiolib: remove devm_fwnode_get_[index_]gpiod_from_child() > > drivers/leds/blink/leds-lgm-sso.c | 5 ++--- > drivers/leds/leds-gpio.c | 5 ++--- > include/linux/gpio/consumer.h | 21 --------------------- > 3 files changed, 4 insertions(+), 27 deletions(-) > --- > base-commit: 7fd22855300e693668c3397771b3a2b3948f827a > change-id: 20220902-get_gpiod_from_child-remove-a62638849e91 > Could you please consider picking this up for 6.1? Or would you be OK with this going through other tree (GPIO maybe)? Thanks.
On Thu, Sep 22, 2022 at 02:48:26PM -0700, Dmitry Torokhov wrote: > Hi Pavel, Marek, > > On Fri, Sep 02, 2022 at 05:55:24PM -0700, Dmitry Torokhov wrote: > > This drops the last uses of devm_fwnode_get_[index_]gpiod_from_child() > > from the tree and drops the stubs implementing this API on top of > > devm_fwnode_gpiod_get_index(). > > > > Note that the bulk of users were converted in 2019, the couple of LED > > drivers are all that have remained. > > > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > > > > --- > > Dmitry Torokhov (3): > > leds: gpio: switch to using devm_fwnode_gpiod_get() > > leds: lgm-sso: switch to using devm_fwnode_gpiod_get() > > gpiolib: remove devm_fwnode_get_[index_]gpiod_from_child() > > > > drivers/leds/blink/leds-lgm-sso.c | 5 ++--- > > drivers/leds/leds-gpio.c | 5 ++--- > > include/linux/gpio/consumer.h | 21 --------------------- > > 3 files changed, 4 insertions(+), 27 deletions(-) > > --- > > base-commit: 7fd22855300e693668c3397771b3a2b3948f827a > > change-id: 20220902-get_gpiod_from_child-remove-a62638849e91 > > > > Could you please consider picking this up for 6.1? Or would you be OK > with this going through other tree (GPIO maybe)? *ping* Could this go through GPIO tree? Dropping this API helps with some outstanding work that I have... Thanks.
On Mon, Oct 24, 2022 at 2:18 PM Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote: > > On Thu, Sep 22, 2022 at 02:48:26PM -0700, Dmitry Torokhov wrote: > > Hi Pavel, Marek, > > > > On Fri, Sep 02, 2022 at 05:55:24PM -0700, Dmitry Torokhov wrote: > > > This drops the last uses of devm_fwnode_get_[index_]gpiod_from_child() > > > from the tree and drops the stubs implementing this API on top of > > > devm_fwnode_gpiod_get_index(). > > > > > > Note that the bulk of users were converted in 2019, the couple of LED > > > drivers are all that have remained. > > > > > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > > > > > > --- > > > Dmitry Torokhov (3): > > > leds: gpio: switch to using devm_fwnode_gpiod_get() > > > leds: lgm-sso: switch to using devm_fwnode_gpiod_get() > > > gpiolib: remove devm_fwnode_get_[index_]gpiod_from_child() > > > > > > drivers/leds/blink/leds-lgm-sso.c | 5 ++--- > > > drivers/leds/leds-gpio.c | 5 ++--- > > > include/linux/gpio/consumer.h | 21 --------------------- > > > 3 files changed, 4 insertions(+), 27 deletions(-) > > > --- > > > base-commit: 7fd22855300e693668c3397771b3a2b3948f827a > > > change-id: 20220902-get_gpiod_from_child-remove-a62638849e91 > > > > > > > Could you please consider picking this up for 6.1? Or would you be OK > > with this going through other tree (GPIO maybe)? > > *ping* Could this go through GPIO tree? Dropping this API helps with > some outstanding work that I have... > Sure! I'll let it wait for another week - it would be great to get an ack from Pavel - but in case of no response I'll take it through my tree. Bart
On Tue, Oct 25, 2022 at 05:48:02PM +0200, Bartosz Golaszewski wrote: > On Mon, Oct 24, 2022 at 2:18 PM Dmitry Torokhov > <dmitry.torokhov@gmail.com> wrote: > > > > On Thu, Sep 22, 2022 at 02:48:26PM -0700, Dmitry Torokhov wrote: > > > Hi Pavel, Marek, > > > > > > On Fri, Sep 02, 2022 at 05:55:24PM -0700, Dmitry Torokhov wrote: > > > > This drops the last uses of devm_fwnode_get_[index_]gpiod_from_child() > > > > from the tree and drops the stubs implementing this API on top of > > > > devm_fwnode_gpiod_get_index(). > > > > > > > > Note that the bulk of users were converted in 2019, the couple of LED > > > > drivers are all that have remained. > > > > > > > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > > > > > > > > --- > > > > Dmitry Torokhov (3): > > > > leds: gpio: switch to using devm_fwnode_gpiod_get() > > > > leds: lgm-sso: switch to using devm_fwnode_gpiod_get() > > > > gpiolib: remove devm_fwnode_get_[index_]gpiod_from_child() > > > > > > > > drivers/leds/blink/leds-lgm-sso.c | 5 ++--- > > > > drivers/leds/leds-gpio.c | 5 ++--- > > > > include/linux/gpio/consumer.h | 21 --------------------- > > > > 3 files changed, 4 insertions(+), 27 deletions(-) > > > > --- > > > > base-commit: 7fd22855300e693668c3397771b3a2b3948f827a > > > > change-id: 20220902-get_gpiod_from_child-remove-a62638849e91 > > > > > > > > > > Could you please consider picking this up for 6.1? Or would you be OK > > > with this going through other tree (GPIO maybe)? > > > > *ping* Could this go through GPIO tree? Dropping this API helps with > > some outstanding work that I have... > > > > Sure! I'll let it wait for another week - it would be great to get an > ack from Pavel - but in case of no response I'll take it through my > tree. Pavel, any chance we could get an Ack for this? Thanks!
On Tue, Oct 25, 2022 at 5:48 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > On Mon, Oct 24, 2022 at 2:18 PM Dmitry Torokhov > <dmitry.torokhov@gmail.com> wrote: > > > > On Thu, Sep 22, 2022 at 02:48:26PM -0700, Dmitry Torokhov wrote: > > > Hi Pavel, Marek, > > > > > > On Fri, Sep 02, 2022 at 05:55:24PM -0700, Dmitry Torokhov wrote: > > > > This drops the last uses of devm_fwnode_get_[index_]gpiod_from_child() > > > > from the tree and drops the stubs implementing this API on top of > > > > devm_fwnode_gpiod_get_index(). > > > > > > > > Note that the bulk of users were converted in 2019, the couple of LED > > > > drivers are all that have remained. > > > > > > > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > > > > > > > > --- > > > > Dmitry Torokhov (3): > > > > leds: gpio: switch to using devm_fwnode_gpiod_get() > > > > leds: lgm-sso: switch to using devm_fwnode_gpiod_get() > > > > gpiolib: remove devm_fwnode_get_[index_]gpiod_from_child() > > > > > > > > drivers/leds/blink/leds-lgm-sso.c | 5 ++--- > > > > drivers/leds/leds-gpio.c | 5 ++--- > > > > include/linux/gpio/consumer.h | 21 --------------------- > > > > 3 files changed, 4 insertions(+), 27 deletions(-) > > > > --- > > > > base-commit: 7fd22855300e693668c3397771b3a2b3948f827a > > > > change-id: 20220902-get_gpiod_from_child-remove-a62638849e91 > > > > > > > > > > Could you please consider picking this up for 6.1? Or would you be OK > > > with this going through other tree (GPIO maybe)? > > > > *ping* Could this go through GPIO tree? Dropping this API helps with > > some outstanding work that I have... > > > > Sure! I'll let it wait for another week - it would be great to get an > ack from Pavel - but in case of no response I'll take it through my > tree. I'd say just apply it at this point. Yours, Linus Walleij
On Tue, Nov 8, 2022 at 11:54 AM Linus Walleij <linus.walleij@linaro.org> wrote: > > On Tue, Oct 25, 2022 at 5:48 PM Bartosz Golaszewski <brgl@bgdev.pl> wrote: > > > On Mon, Oct 24, 2022 at 2:18 PM Dmitry Torokhov > > <dmitry.torokhov@gmail.com> wrote: > > > > > > On Thu, Sep 22, 2022 at 02:48:26PM -0700, Dmitry Torokhov wrote: > > > > Hi Pavel, Marek, > > > > > > > > On Fri, Sep 02, 2022 at 05:55:24PM -0700, Dmitry Torokhov wrote: > > > > > This drops the last uses of devm_fwnode_get_[index_]gpiod_from_child() > > > > > from the tree and drops the stubs implementing this API on top of > > > > > devm_fwnode_gpiod_get_index(). > > > > > > > > > > Note that the bulk of users were converted in 2019, the couple of LED > > > > > drivers are all that have remained. > > > > > > > > > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > > > > > > > > > > --- > > > > > Dmitry Torokhov (3): > > > > > leds: gpio: switch to using devm_fwnode_gpiod_get() > > > > > leds: lgm-sso: switch to using devm_fwnode_gpiod_get() > > > > > gpiolib: remove devm_fwnode_get_[index_]gpiod_from_child() > > > > > > > > > > drivers/leds/blink/leds-lgm-sso.c | 5 ++--- > > > > > drivers/leds/leds-gpio.c | 5 ++--- > > > > > include/linux/gpio/consumer.h | 21 --------------------- > > > > > 3 files changed, 4 insertions(+), 27 deletions(-) > > > > > --- > > > > > base-commit: 7fd22855300e693668c3397771b3a2b3948f827a > > > > > change-id: 20220902-get_gpiod_from_child-remove-a62638849e91 > > > > > > > > > > > > > Could you please consider picking this up for 6.1? Or would you be OK > > > > with this going through other tree (GPIO maybe)? > > > > > > *ping* Could this go through GPIO tree? Dropping this API helps with > > > some outstanding work that I have... > > > > > > > Sure! I'll let it wait for another week - it would be great to get an > > ack from Pavel - but in case of no response I'll take it through my > > tree. > > I'd say just apply it at this point. > Right. Applied to gpio/for-next. Thanks! Bartosz
This drops the last uses of devm_fwnode_get_[index_]gpiod_from_child() from the tree and drops the stubs implementing this API on top of devm_fwnode_gpiod_get_index(). Note that the bulk of users were converted in 2019, the couple of LED drivers are all that have remained. Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> --- Dmitry Torokhov (3): leds: gpio: switch to using devm_fwnode_gpiod_get() leds: lgm-sso: switch to using devm_fwnode_gpiod_get() gpiolib: remove devm_fwnode_get_[index_]gpiod_from_child() drivers/leds/blink/leds-lgm-sso.c | 5 ++--- drivers/leds/leds-gpio.c | 5 ++--- include/linux/gpio/consumer.h | 21 --------------------- 3 files changed, 4 insertions(+), 27 deletions(-) --- base-commit: 7fd22855300e693668c3397771b3a2b3948f827a change-id: 20220902-get_gpiod_from_child-remove-a62638849e91 Best regards,