| Message ID | 20211110225808.16388-1-prabhakar.mahadev-lad.rj@bp.renesas.com |
|---|---|
| Headers | show |
| Series | Renesas RZ/G2L IRQC support | expand |
Hi Prabhakar, On Wed, Nov 10, 2021 at 11:58 PM Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > The RZ/G2L Interrupt Controller is a front-end for the GIC found on > Renesas RZ/G2L SoC's with below pins: > - IRQ sense select for 8 external interrupts, mapped to 8 GIC SPI interrupts > - GPIO pins used as external interrupt input pins out of GPIOINT0-122 a > maximum of only 32 can be mapped to 32 GIC SPI interrupts, > - NMI edge select. > > _____________ > | GIC | > | ________ | > ____________ | | | | > NMI ------------------------------------>| | SPI0-479 | | GIC-600| | > _______ | |------------>| | | > | | | | PPI16-31 | | | | > | | IRQ0-IRQ8 | IRQC |------------>| | | IRQ0-IRQ7? > P0_P48_4 ------>| GPIO |---------------->| | | |________| | > | |GPIOINT0-122 | | | | > | |---------------->| TINT0-31 | | | > |______| |__________| |____________| > > The proposed RFC patches, add the IRQ domains in GPIO (pinctrl driver) and the > IRQC driver. The IRQC domain handles the actual SPI interrupt and upon reception > of the interrupt it propagates to the GPIO IRQ domain to handle virq. > Out of GPIOINT0-122 only 32 can be mapped to GIC SPI, this mapping is handled by > the IRQC driver. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert, On Fri, Nov 12, 2021 at 2:12 PM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Hi Prabhakar, > > On Wed, Nov 10, 2021 at 11:58 PM Lad Prabhakar > <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > > The RZ/G2L Interrupt Controller is a front-end for the GIC found on > > Renesas RZ/G2L SoC's with below pins: > > - IRQ sense select for 8 external interrupts, mapped to 8 GIC SPI interrupts > > - GPIO pins used as external interrupt input pins out of GPIOINT0-122 a > > maximum of only 32 can be mapped to 32 GIC SPI interrupts, > > - NMI edge select. > > > > _____________ > > | GIC | > > | ________ | > > ____________ | | | | > > NMI ------------------------------------>| | SPI0-479 | | GIC-600| | > > _______ | |------------>| | | > > | | | | PPI16-31 | | | | > > | | IRQ0-IRQ8 | IRQC |------------>| | | > > IRQ0-IRQ7? > oops typo here. > > P0_P48_4 ------>| GPIO |---------------->| | | |________| | > > | |GPIOINT0-122 | | | | > > | |---------------->| TINT0-31 | | | > > |______| |__________| |____________| > > > > The proposed RFC patches, add the IRQ domains in GPIO (pinctrl driver) and the > > IRQC driver. The IRQC domain handles the actual SPI interrupt and upon reception > > of the interrupt it propagates to the GPIO IRQ domain to handle virq. Also this bit isnt true (copy pasted from v1 :(). IRQ now is handled by the slave driver requesting interrupts. IRQC now handles eoi callbacks. > > Out of GPIOINT0-122 only 32 can be mapped to GIC SPI, this mapping is handled by > > the IRQC driver. > Cheers, Prabhakar > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds
Hi Marc and Linus, On Wed, Nov 10, 2021 at 10:58 PM Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > > Hi All, > > The RZ/G2L Interrupt Controller is a front-end for the GIC found on > Renesas RZ/G2L SoC's with below pins: > - IRQ sense select for 8 external interrupts, mapped to 8 GIC SPI interrupts > - GPIO pins used as external interrupt input pins out of GPIOINT0-122 a > maximum of only 32 can be mapped to 32 GIC SPI interrupts, > - NMI edge select. > > _____________ > | GIC | > | ________ | > ____________ | | | | > NMI ------------------------------------>| | SPI0-479 | | GIC-600| | > _______ | |------------>| | | > | | | | PPI16-31 | | | | > | | IRQ0-IRQ8 | IRQC |------------>| | | > P0_P48_4 ------>| GPIO |---------------->| | | |________| | > | |GPIOINT0-122 | | | | > | |---------------->| TINT0-31 | | | > |______| |__________| |____________| > > The proposed RFC patches, add the IRQ domains in GPIO (pinctrl driver) and the > IRQC driver. The IRQC domain handles the actual SPI interrupt and upon reception > of the interrupt it propagates to the GPIO IRQ domain to handle virq. > Out of GPIOINT0-122 only 32 can be mapped to GIC SPI, this mapping is handled by > the IRQC driver. > > Cheers, > Prabhakar > > Changes for v3: > -> Re-structured the driver as a hierarchical irq domain instead of chained > -> made use of IRQCHIP_* macros > -> dropped locking > -> Added support for IRQ0-7 interrupts > -> Introduced 2 new patches for GPIOLIB > -> Switched to using GPIOLIB for irqdomains in pinctrl > Gentle ping. Cheers, Prabhakar > RFC v2: https://patchwork.kernel.org/project/linux-renesas-soc/cover/ > 20210921193028.13099-1-prabhakar.mahadev-lad.rj@bp.renesas.com/ > RFC v1: https://patchwork.kernel.org/project/linux-renesas-soc/cover/ > 20210803175109.1729-1-prabhakar.mahadev-lad.rj@bp.renesas.com/ > > Lad Prabhakar (7): > dt-bindings: interrupt-controller: Add Renesas RZ/G2L Interrupt > Controller > irqchip: Add RZ/G2L IA55 Interrupt Controller driver > soc: renesas: Enable IRQC driver for RZ/G2L > gpio: gpiolib: Allow free() callback to be overridden > gpio: gpiolib: Add ngirq member to struct gpio_irq_chip > pinctrl: renesas: pinctrl-rzg2l: Add IRQ domain to handle GPIO > interrupt > arm64: dts: renesas: r9a07g044: Add IRQC node to SoC DTSI > > .../renesas,rzg2l-irqc.yaml | 137 ++++++ > arch/arm64/boot/dts/renesas/r9a07g044.dtsi | 60 +++ > drivers/gpio/gpiolib.c | 13 +- > drivers/irqchip/Kconfig | 8 + > drivers/irqchip/Makefile | 1 + > drivers/irqchip/irq-renesas-rzg2l.c | 465 ++++++++++++++++++ > drivers/pinctrl/renesas/pinctrl-rzg2l.c | 197 ++++++++ > drivers/soc/renesas/Kconfig | 1 + > include/linux/gpio/driver.h | 8 + > 9 files changed, 885 insertions(+), 5 deletions(-) > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/renesas,rzg2l-irqc.yaml > create mode 100644 drivers/irqchip/irq-renesas-rzg2l.c > > -- > 2.17.1 >
Hi Marc and Linus, On Mon, Nov 22, 2021 at 7:25 PM Lad, Prabhakar <prabhakar.csengg@gmail.com> wrote: > > Hi Marc and Linus, > > On Wed, Nov 10, 2021 at 10:58 PM Lad Prabhakar > <prabhakar.mahadev-lad.rj@bp.renesas.com> wrote: > > > > Hi All, > > > > The RZ/G2L Interrupt Controller is a front-end for the GIC found on > > Renesas RZ/G2L SoC's with below pins: > > - IRQ sense select for 8 external interrupts, mapped to 8 GIC SPI interrupts > > - GPIO pins used as external interrupt input pins out of GPIOINT0-122 a > > maximum of only 32 can be mapped to 32 GIC SPI interrupts, > > - NMI edge select. > > > > _____________ > > | GIC | > > | ________ | > > ____________ | | | | > > NMI ------------------------------------>| | SPI0-479 | | GIC-600| | > > _______ | |------------>| | | > > | | | | PPI16-31 | | | | > > | | IRQ0-IRQ8 | IRQC |------------>| | | > > P0_P48_4 ------>| GPIO |---------------->| | | |________| | > > | |GPIOINT0-122 | | | | > > | |---------------->| TINT0-31 | | | > > |______| |__________| |____________| > > > > The proposed RFC patches, add the IRQ domains in GPIO (pinctrl driver) and the > > IRQC driver. The IRQC domain handles the actual SPI interrupt and upon reception > > of the interrupt it propagates to the GPIO IRQ domain to handle virq. > > Out of GPIOINT0-122 only 32 can be mapped to GIC SPI, this mapping is handled by > > the IRQC driver. > > > > Cheers, > > Prabhakar > > > > Changes for v3: > > -> Re-structured the driver as a hierarchical irq domain instead of chained > > -> made use of IRQCHIP_* macros > > -> dropped locking > > -> Added support for IRQ0-7 interrupts > > -> Introduced 2 new patches for GPIOLIB > > -> Switched to using GPIOLIB for irqdomains in pinctrl > > > Gentle ping. > I plan to post a non RFC version soon, can I have your feedback on this please. Cheers, Prabhakar > > > RFC v2: https://patchwork.kernel.org/project/linux-renesas-soc/cover/ > > 20210921193028.13099-1-prabhakar.mahadev-lad.rj@bp.renesas.com/ > > RFC v1: https://patchwork.kernel.org/project/linux-renesas-soc/cover/ > > 20210803175109.1729-1-prabhakar.mahadev-lad.rj@bp.renesas.com/ > > > > Lad Prabhakar (7): > > dt-bindings: interrupt-controller: Add Renesas RZ/G2L Interrupt > > Controller > > irqchip: Add RZ/G2L IA55 Interrupt Controller driver > > soc: renesas: Enable IRQC driver for RZ/G2L > > gpio: gpiolib: Allow free() callback to be overridden > > gpio: gpiolib: Add ngirq member to struct gpio_irq_chip > > pinctrl: renesas: pinctrl-rzg2l: Add IRQ domain to handle GPIO > > interrupt > > arm64: dts: renesas: r9a07g044: Add IRQC node to SoC DTSI > > > > .../renesas,rzg2l-irqc.yaml | 137 ++++++ > > arch/arm64/boot/dts/renesas/r9a07g044.dtsi | 60 +++ > > drivers/gpio/gpiolib.c | 13 +- > > drivers/irqchip/Kconfig | 8 + > > drivers/irqchip/Makefile | 1 + > > drivers/irqchip/irq-renesas-rzg2l.c | 465 ++++++++++++++++++ > > drivers/pinctrl/renesas/pinctrl-rzg2l.c | 197 ++++++++ > > drivers/soc/renesas/Kconfig | 1 + > > include/linux/gpio/driver.h | 8 + > > 9 files changed, 885 insertions(+), 5 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/renesas,rzg2l-irqc.yaml > > create mode 100644 drivers/irqchip/irq-renesas-rzg2l.c > > > > -- > > 2.17.1 > >
On Fri, Dec 10, 2021 at 2:09 AM Lad, Prabhakar
<prabhakar.csengg@gmail.com> wrote:
> I plan to post a non RFC version soon, can I have your feedback on this please.
I actually cannot see the patches (just this cover letter) I wonder if
they got stuck.
For
gpio: gpiolib: Allow free() callback to be overridden
gpio: gpiolib: Add ngirq member to struct gpio_irq_chip
I trust whatever Marc
says. If he agrees we need this, then we need this.
Yours,
Linus Walleij
On Fri, Dec 10, 2021 at 2:04 AM Linus Walleij <linus.walleij@linaro.org> wrote: > > On Fri, Dec 10, 2021 at 2:09 AM Lad, Prabhakar > <prabhakar.csengg@gmail.com> wrote: > > > I plan to post a non RFC version soon, can I have your feedback on this please. > > I actually cannot see the patches (just this cover letter) I wonder if > they got stuck. > I was able to locate them in gpio patchwork https://patchwork.ozlabs.org/project/linux-gpio/cover/20211110225808.16388-1-prabhakar.mahadev-lad.rj@bp.renesas.com/ > For > gpio: gpiolib: Allow free() callback to be overridden > gpio: gpiolib: Add ngirq member to struct gpio_irq_chip > > I trust whatever Marc > says. If he agrees we need this, then we need this. > OK. > Yours, > Linus Walleij Cheers, Prabhakar
Hi All, The RZ/G2L Interrupt Controller is a front-end for the GIC found on Renesas RZ/G2L SoC's with below pins: - IRQ sense select for 8 external interrupts, mapped to 8 GIC SPI interrupts - GPIO pins used as external interrupt input pins out of GPIOINT0-122 a maximum of only 32 can be mapped to 32 GIC SPI interrupts, - NMI edge select. _____________ | GIC | | ________ | ____________ | | | | NMI ------------------------------------>| | SPI0-479 | | GIC-600| | _______ | |------------>| | | | | | | PPI16-31 | | | | | | IRQ0-IRQ8 | IRQC |------------>| | | P0_P48_4 ------>| GPIO |---------------->| | | |________| | | |GPIOINT0-122 | | | | | |---------------->| TINT0-31 | | | |______| |__________| |____________| The proposed RFC patches, add the IRQ domains in GPIO (pinctrl driver) and the IRQC driver. The IRQC domain handles the actual SPI interrupt and upon reception of the interrupt it propagates to the GPIO IRQ domain to handle virq. Out of GPIOINT0-122 only 32 can be mapped to GIC SPI, this mapping is handled by the IRQC driver. Cheers, Prabhakar Changes for v3: -> Re-structured the driver as a hierarchical irq domain instead of chained -> made use of IRQCHIP_* macros -> dropped locking -> Added support for IRQ0-7 interrupts -> Introduced 2 new patches for GPIOLIB -> Switched to using GPIOLIB for irqdomains in pinctrl RFC v2: https://patchwork.kernel.org/project/linux-renesas-soc/cover/ 20210921193028.13099-1-prabhakar.mahadev-lad.rj@bp.renesas.com/ RFC v1: https://patchwork.kernel.org/project/linux-renesas-soc/cover/ 20210803175109.1729-1-prabhakar.mahadev-lad.rj@bp.renesas.com/ Lad Prabhakar (7): dt-bindings: interrupt-controller: Add Renesas RZ/G2L Interrupt Controller irqchip: Add RZ/G2L IA55 Interrupt Controller driver soc: renesas: Enable IRQC driver for RZ/G2L gpio: gpiolib: Allow free() callback to be overridden gpio: gpiolib: Add ngirq member to struct gpio_irq_chip pinctrl: renesas: pinctrl-rzg2l: Add IRQ domain to handle GPIO interrupt arm64: dts: renesas: r9a07g044: Add IRQC node to SoC DTSI .../renesas,rzg2l-irqc.yaml | 137 ++++++ arch/arm64/boot/dts/renesas/r9a07g044.dtsi | 60 +++ drivers/gpio/gpiolib.c | 13 +- drivers/irqchip/Kconfig | 8 + drivers/irqchip/Makefile | 1 + drivers/irqchip/irq-renesas-rzg2l.c | 465 ++++++++++++++++++ drivers/pinctrl/renesas/pinctrl-rzg2l.c | 197 ++++++++ drivers/soc/renesas/Kconfig | 1 + include/linux/gpio/driver.h | 8 + 9 files changed, 885 insertions(+), 5 deletions(-) create mode 100644 Documentation/devicetree/bindings/interrupt-controller/renesas,rzg2l-irqc.yaml create mode 100644 drivers/irqchip/irq-renesas-rzg2l.c